The newer version sets the connection.autoconnect-slaves=1 config
option[1]. This will ensure that slave interfaces will also reconnect
after bouncing the parent.

[1] https://github.com/michaelrigart/ansible-role-interfaces/releases/tag/v1.15.1

Closes-Bug: #2072340
Change-Id: I2d7a8f1368d4f0e02d199029c15c453a56582b41
(cherry picked from commit 447635ac)

This commit adds variables to configure authentication parameters in the
image-download role, which is used to download IPA images.

The new variables are image_download_url_username,
image_download_url_password, image_download_force_basic_auth and
image_download_unredirected_headers.

See Ansible documentation for more details about these variables [1,2].

[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/get_url_module.html
[2] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/uri_module.html

Change-Id: Ib149e97d42ca46b96b5c05030ba2cf871a63cde9
(cherry picked from commit 344008d8)

Change-Id: I134bcbece0f28bf5234f0afd8349b602ce2940a1
(cherry picked from commit 51b54d54)

Change-Id: I31bc776b2cd7f6543705c44609fbcf22d9259be5
(cherry picked from commit b4f63447)

Hosts that weren't part of the overcloud group would be included in the
list when this is run without a limit.

Closes-Bug: #2091621
Change-Id: Id3d68b55e18dfe9c44805b6e2602e00eadecc76a
(cherry picked from commit f27755ae)

If ironic-python-agent is not installed in the IPA image using
upper-constraints, the ironic-lib selected by pip for installation may
be newer than ipa.

Use upper-constraints for the same version as ironic-python-agent when
installing it, by passing the DIB_REPOREF_requirements environment
variable to ironic-python-agent-builder.

Closes-Bug: #2089263
Change-Id: I6e33f9897dc7efc57987872ffccdfbe0fc78cc52
(cherry picked from commit 89849c1c)

This avoids leaking repository credentials by suppressing the dict
output to only print the key.

Change-Id: Ic7aa0e4c4f625908aeb30de65edac8bce96af761
Related-Bug: #2087938

When using the custom playbook feature, it is possible to affect the
behaviour of internal kayobe playbooks by installing newer versions of
roles, collections, or plugins. This is almost always undesirable. It
occurs because ansible extensions in kayobe config currently have
precedence over the kayobe internal variants. We can prevent users
accidentally breaking kayobe internal playbooks by searching for
extensions in paths in the kayobe install first, followed by kayobe
config (but only when running internal playbooks). The behaviour when
running external playbooks is unchanged. This method still allows you to
install additional plugins, which can be useful in kayobe config e.g
processing a variable with a custom filter plugin.

Change-Id: I34f0351dbcb50104c9a4d6706d94a349c3ea3b9f
Closes-Bug: #2056473
Co-Authored-By: Matt Crees <mattc@stackhpc.com>

This brings in improvements like --check --diff support

Change-Id: I3a07902d5bd92d0e0178d93e2a0994a19b376884

Change-Id: I7a9aa9abf611cdaa47cc91f40a6753f23a7f187e
Closes-Bug: #2087556

TrivialFix

Change-Id: Ia56d98d5ad335de7b32261aa3617aee4780a1e70

This change bumps up the maximum supported Ansible version to 10.x
(ansible-core 2.17.x) and minimum to 9.x. This synchronises Kayobe with
Kolla Ansible.

Change-Id: Idfbf0eed0b2333d550f822e40a0d96ae227f6159

This matches a recent change in kolla-ansible [1].

[1] https://review.opendev.org/c/openstack/kolla-ansible/+/913724

Change-Id: I8a7a84025e93c4dcb1285bc28f3bd481bbdfff32

This should have been added when proxysql was added to kolla [1] and
kolla-ansible [2].

ProxySQL is disabled by default in this change to allow backports. It
will be enabled in a follow-up patch only for the master branch.

[1] https://review.opendev.org/c/openstack/kolla/+/769385
[2] https://review.opendev.org/c/openstack/kolla-ansible/+/770215

Change-Id: I683b685bf4e2f625144e4656bcd69c03eda7aa51

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/925581
Change-Id: Id9d90f424a5b0f7eedd1a11512bb8b72abba8959

Release 1.3.0 of stackhpc.linux fixes configuration of kernel parameters
for IOMMU when the GRUB_CMDLINE_LINUX_DEFAULT variable is absent from
/etc/default/grub.

Include a release note about a notable change in the sriov role.

[1] https://github.com/stackhpc/ansible-collection-linux/releases/tag/v1.3.0

Change-Id: I43295cd21fc4947fa877aa242070e3c132532fab
Closes-Bug: #2083874

This fixes IPA and host disk image build failures when Git was not
installed on the build host.

Change-Id: I057aefc45d1a8efe133fec9921e5c84cad556429
Closes-Bug: #2058922

Support for NCLU was added in Networking Generic Switch in the Zed
release[1].

Support for NVUE was added in Networking Generic Switch in the
2023.2 release[2].

[1] https://review.opendev.org/c/openstack/networking-generic-switch/+/743269
[2] https://review.opendev.org/c/openstack/networking-generic-switch/+/907551

Closes-Bug: #2083840

Change-Id: I973c6484ccd2a36990cf39df102e65be0376f08c

Change-Id: I4b9c4e5a2d6e943c85250b7b85ad52a8a620e80d

Change-Id: Id3e4e7ca285a94e7270eb4850c66e9094782f841

This updates the group and mode set on the /var/log/journal directory to
match default ownership and permissions used by systemd-journald.

Closes-Bug: #2083494
Change-Id: I15323b95199b9ef19504c7408dd89720f9ba9c32

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/923946
Change-Id: Icd6988668646e0ecb89822d46dafa33f9dd618e1

Use correct system scope - all - while getting the list of ironic
nodes in ipa-images role.

Closes-Bug: #2083014
Change-Id: I4da3a3739d57817ffbd094caea0fc80c3ad8eff8

When kolla_base_arch and ansible_facts.architecture differs
we need to run multiarch/qemu-user-static image - see [1].

[1]: https://github.com/multiarch/qemu-user-static



Co-Authored-By: Bartosz Bezak <bartosz@stackhpc.com>

Change-Id: If149418f509c687c3e5d1072cc39a80af33dec5a

Some network devices may use SSH key exchange algorithms that are no
longer supported by the Ansible control host. This will cause
ssh-keyscan to fail, preventing Kayobe from configuring the devices.
This change makes it possible to work around the issue by setting
switch_skip_keyscan to true for the affected devices. The SSH known
hosts file on the Ansible control host will need to be populated
manually.

Change-Id: I4e3394cff1fd86eb5c1a4be55d6fd7fd080b2944

eos_config does not support provider, nor connection: local from at
least 2022 [1] - since ansible>=7 (ansible-core 2.14).

[1]: https://github.com/ansible-collections/arista.eos/commit/588d94b2ed22817b63f996187e7d757d3ebad725

Closes-Bug: #2058365
Change-Id: Ief37b7bee758e34dddb881a9e68728013861c0ec

During the ``kayobe overcloud inventory discover`` command, Kayobe
queries the Bifrost ironic node list and updates the Kayobe inventory.
If the nodes have a driver_info.ipmi_address field set, an ipmi_address
variable will be defined in the Kayobe inventory for the host.

This does not work for Redfish based hosts, which use
driver_info.redfish_address in the Ironic node. This change adds a new
``redfish_address`` variable and extends the command to discover the
address from the Bifrost node inventory.

Change-Id: Ieb1e61ddadb542732739d1f478b1e5a176e0ac88

Previously Kolla Ansible hard-coded Neutron physical networks starting
at physnet1 up to physnetN, matching the number of interfaces in
neutron_external_interface and bridges in neutron_bridge_name.

Sometimes we may want to customise the physical network names used.
This may be to allow for not all hosts having access to all physical
networks, or to use more descriptive names.

For example, in an environment with a separate physical network for
Ironic provisioning, controllers might have access to two physical
networks, while compute nodes have access to one.

This change extends the 'physical_network' network attribute to make it
possible to customise the Neutron physical network names used for the
OVS, OVN, Linux bridge and OVS DPDK plugins. The default behaviour is
unchanged.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922320
Change-Id: I214444c60653f484fcda6275cc725879d14f9e7a

Added initial support for systemd-networkd link configuration, now
you can configure and rename the name of a network interface if you
know the MAC address of the interface.

Also added unit tests and fixed issues in the test_overcloud_host_configure.py:
 * Added unit test for networkd.
 * Fixed pep8 issues.
 * Removed unused import.
 * Fixed 'not in' issue in assert.

Change-Id: I8321183dbc747ef521aa0d2660ebeef8b0342c6a
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Change-Id: I7d71689ef9b5a8a092fe78da4ee3d2a645a1316e

Bump stackhpc.libvirt-vm to v1.16.1.

Change-Id: I88f20112ab4740fe114a6484f88f4fbfb66863e5

Follows the same pattern as apt config.yml

Change-Id: Ifb347372032120ec676747bad6201e0d82725976

This change bumps up the versions of Ansible installed in the
kolla-ansible virtualenv to a maximum of 10.x (ansible-core 2.17.x) and
minimum to 9.x. This is to align with the Kolla version requirements
currently in master.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/921743
Change-Id: I4147a27ed04d28e832f11662e45dbae2851f63a8

There's no good reason to provide our own defaults for Ironic driver and
interface configuration. It easily gets out of sync with changes in
Ironic. Let's remove our defaults, and let Ironic provide them.

Note that this changes several of the defaults, which are listed in the
release note. Users are still able to override them using the existing
variables in ironic.yml.

Change-Id: Ie27adca0029e41439720eaac49b24cf13fc8068d

There are various ways in which it is possible to operate Kayobe
incorrectly. One example is executing Kayobe from a different Kayobe
configuration repository than the one referred to by the
KAYOBE_CONFIG_PATH environment variable.

While this shouldn't necessarily cause any errors, it may lead to
unexpected results if the operator assumes they are operating against
the configuration in the current directory.

This change adds a validation step that checks for this case and fails
the command early if found.

Change-Id: I709884bbd7edebf1d409f39c11f293560e987506

When using overcloud Ironic, IPA images for Ironic inspector are
downloaded to the Ansible control host to a cache directory, by default
/opt/kayobe/images/ipa/. They are later copied into the local Kolla
Ansible configuration under
etc/kolla/config/ironic/ironic-agent.{initramfs,kernel}.

The use of a shared cache directory results in problems when multiple
users share a single Ansible control host, since the cache is created as
writeable only for the user that created it. Other users sharing the
same Ansible control host will be unable to write to the cache.

We may also see issues if multiple Kayobe environments using different
IPA images are deployed from one Ansible control host.

The cache is not strictly necessary, since we can download the images
directly to the kayobe-config repo. This change avoids the use of the
cache. The performance impact should be minimal, only requiring an
additional download when a fresh kayobe-config is used.

Change-Id: I022c53afc0f64ccc79eeff4a220ade4c9216edfc
Closes-Bug: #2069845

Currently Kayobe sets ipv4_interface_mac to pxe interface
MAC address.

In cases where provisioning network interface and admin
network interface are different - this feature can be used
to get MAC address from Ironic introspection data.

Change-Id: Ie3c9248f0b3e47e3645e1886c0492265d52969c9

Closes-Bug: #2073100
Change-Id: Ied06ee3380a149c4c8d082562c93f9b771457cb4

This works around a bug in the ansible packaged version of
community.docker when using requests>=2.32. It is also more flexible if
we can control the versions.

Also fixes an issue where kolla collections would not be installed if
the same role existed in the kayobe ansible collections path.

This relies on the support added in kolla-ansible to use ansible-core,
see: https://review.opendev.org/c/openstack/kolla-ansible/+/896406.

Closes-Bug: #2072980
Change-Id: Id9b19f10bc8ac38927914fb9782892b7daf1be82

Useful if you're configuring your own private repos, and don't/can't
sign them.

Change-Id: I2d592c5479530b2fe9a60c14ee59e817b8402490