seed-vm/infra-vms: Use efi as default

Change-Id: I7d71689ef9b5a8a092fe78da4ee3d2a645a1316e

ansible/inventory/group_vars/all/infra-vms

@@ -76,8 +76,8 @@ infra_vm_wait_connection_ssh_extra_args: '-o StrictHostKeyChecking=no'
 # OS family. Needed for config drive generation.
 infra_vm_os_family: "{{ 'RedHat' if os_distribution in ['centos', 'rocky'] else 'Debian' }}"
 
-# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'bios'.
-infra_vm_boot_firmware: "bios"
+# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'efi'.
+infra_vm_boot_firmware: "efi"
 
 # Machine type. Libvirt default configuration is used.
 infra_vm_machine:

ansible/inventory/group_vars/all/seed-vm

@@ -66,8 +66,8 @@ seed_vm_data_format: qcow2
 # List of network interfaces to attach to the seed VM.
 seed_vm_interfaces: "{{ network_interfaces | sort | map('net_libvirt_vm_network') | list }}"
 
-# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'bios'.
-seed_vm_boot_firmware: "bios"
+# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'efi'.
+seed_vm_boot_firmware: "efi"
 
 # Machine type. Libvirt default configuration is used.
 seed_vm_machine:

etc/kayobe/infra-vms.yml

@@ -58,7 +58,7 @@
 # OS family. Needed for config drive generation.
 #infra_vm_os_family:
 
-# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'bios'.
+# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'efi'.
 #infra_vm_boot_firmware:
 
 # Machine type. Libvirt default configuration is used.

etc/kayobe/seed-vm.yml

@@ -61,7 +61,7 @@
 #
 #seed_vm_interfaces:
 
-# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'bios'.
+# Boot firmware. Possible values are 'bios' or 'efi'. Default is 'efi'.
 #seed_vm_boot_firmware:
 
 # Machine type. Libvirt default configuration is used.

releasenotes/notes/seed-infra-vm-efi-default-9b2114a4e2fb4b8a.yaml

+---
+upgrade:
+  - |
+    Changes the default boot firmware for seed and infra VMs to ``efi``. Set
+    ``infra_vm_boot_firmware`` and ``seed_vm_boot_firmware`` to ``bios`` to
+    retain existing behaviour.
+fixes:
+  - |
+    Fixes compatibility with Rocky Linux 9.4 GenericCloud images by switching
+    to ``efi`` boot firmware.