Change-Id: Ief1598a017b7ff491c9fcb775fdb155628bc55d2

Change-Id: Iab40eb92c7e4a9092471bef9d4477a4fa34f1c85

The version that we were capping to is no longer compatible with latest
upper-constraints.txt, so let us free float again.

The resulting linting errors are included for now to unblock the gate,
these will still need to be discussed or fixed later.

NOTE(kevko): Temporarily disabling horizon deployment, as it's not
possible to unblock gates without it

Co-Authored-By: Michal Arbet <michal.arbet@ultimum.io>
Change-Id: Ib7f72b2663199ef80844a412bc436c6ef09322cc

Change-Id: I2326225ddde2216cc94a0486366d5ef4782384d7

Change-Id: I13ee17a96033da75cbb377bce483f027127d646d

Add fqcn-builtins to the skip list for now, we will watch how the
discussion about this evolves and defer updating all code according to
that [0].

[0] https://github.com/ansible/ansible-lint/issues/2050



Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I6dcdec4f029b87bad41530ad45d285909c8351f7

These are not needed for unit tests and we want to avoid conflicts when
running with older python versions that we still test against.

We intentionally duplicate ansible and reno as requirements in order to
avoid having to install more items than necessary.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I0ec83c3e4ae38f911b922a3bade65429d91169eb

ansible-lint 6.0.0 introduced requirement to use FQCNs

Change-Id: I3f27c6bcdd200252ebb089f6377294f7e3a911a0
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Also bumps the minimum to 4.

Change-Id: Ia373f9cc3bb69eba0288bbb3e497e8cadb7cc4d3

This change bumps up max supported Ansible version
to 4.x (ansible-core 2.11.x) and minimum to 2.10.

Change-Id: I8b9212934dfab3831986e8db55671baee32f4bbd

Min version stays as 2.9

Change-Id: I7ec8c5eb36757248c9aa016dc7d4e495ec5bb635

so that it matches what is tested otherwise.

Change-Id: I4eef9f89f1cd262ca2a96c20079756f5f1499ad3

Change-Id: I5befc72a4894d625ca352b27df9d3aa84a2f5b2c

See [1].

[1] https://github.com/ansible/ansible-lint/issues/969

Change-Id: I5ac8f20a2157d880b63a4c70bf6c782d06014f41

* Reworked tox pep8 into linters job, that runs:
  - pep8
  - bandit
  - bashate
  - doc8
  - yamllint
  - ansible-lint (validate-all-files.py + ansible-lint)

* Skip E701 - missing galaxy_info in meta and E602 see [1].
* Skip E301 and E503 - followup later in a separate change
* Added ansible-role-jobs to zuul.d/project.yaml which will run
  openstack-tox-linters job in check queue
* Fixed remaining style issue
* Made tox and docs reference the new env for linters
* Dropped pype environment (not supported)

[1]: https://github.com/ansible/ansible-lint/issues/457

Change-Id: I494b4b151804aac8173120e6c6e42bc2fdb00234

flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.

Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.

To avoid similar gate break in future, we need to bump the hacking min
version.

- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html

Change-Id: I4b11eaad9eac9985342a00e583f16e379a2ad04a

This causes non-local side effects that are hard to track down. E.g:

--- import errors ---
Failed to import test module: tests.test_merge_yaml
Traceback (most recent call last):
  File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/will/code/kolla-ansible/tests/test_merge_yaml.py", line 19, in <module>
    from ansible.errors import AnsibleModuleError
ModuleNotFoundError: No module named 'ansible.errors'; 'ansible' is not a package

This `'ansible' is not a package` message occurs because ansible is a Mock.

Depends-On: https://review.opendev.org/#/c/726768/
Change-Id: Iddbdd3d855daadbf12536cc990559e6b8e123051

Removes and/or replaces all mentions of py27.

Cleans up obsolete requirements and their lower-constraints.

Separates test-requirements.

Makes lower-constraints pass outside of CI (MarkupSafe).

Adds FIXMEs about some hacky Mocks that may misbehave.

Change-Id: Ifc090bf3c1db17d8542ee591c91e8225a597bfe2

The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Fix problems found by updated hacking version.

Remove hacking and friends from lower-constraints, they are not needed
during installation.

Change-Id: I7ef5ac8a89e94f5da97780198619b6facc86ecfe

These should not be necessary.

Change-Id: Ide02b7da2a2a2d528c171772f5552f4529ffe880

Use latest release 1.1.0 and compatible changes w.r.t pep8

Change-Id: Ie5e5417a1d8481bb59d516a320bd7cc1dd89591e

According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.

[1] https://etherpad.openstack.org/p/YVR-python-pti

Change-Id: I63079f352ff36dda4f3f64a8681431a319791f0e

The openstackdocstheme is included by ``doc/requirements.txt``. We
move all doc requirements to ``doc/requirements.txt``.

Change-Id: I3e3acf07826a496b3d8514941afa908624fb74f4

For compliance with the Project Testing Interface [1]
as described in [2]

[1]
https://governance.openstack.org/tc/reference/project-testing-interface.html
[2]
http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html

doc8 command is dropped from docs tox envs.
So this affect nothing and run in PEP8.

Related-Bug: #1765348

Depends-On: Icc7fe3a8f9716281de88825e9d5b2fd84de3d00a
Change-Id: Idf9a16111479ccc64004eac9508da575822a3df5

hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.

Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc

That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.

If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.

Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html

Change-Id: I05790c5f946a4127fe6c8d9867cc618cb83d67fb

Change-Id: Ib440c05aa88fcacbe64aadc6e1f9fd38c47d2d57

Change-Id: I836b0d6e915c32074d8062b5914277497ec4f444

Change-Id: Ie6fd05b52592ad48fd7acbd6b7e9a6f48ffd1150

Change-Id: Ia9a7b76a9db4a149d9e0df16ac576ecd706df22b

Change-Id: If0f42f15d8a92ce77ec7988bc04f795d795e2d89

Change-Id: I6cf2fce6afbaea4bb8c63c1dd0acc61bf1cf477d

Change-Id: I68a1f61af30f5cc3b0604fb988cf773107891b11

Change-Id: Ica929fd8d3ef1972fec0daeb4ae2c00b9a9be3a0

Change-Id: I89264d20cf97bab69ac6fb970c0a770a3b53bfe0

Change-Id: Ia70a5296c557ec54cdb47a28b163c9365d03506e

Change-Id: I8d097af4a75bdc4225e0df04bfbdc555d1529aae

Change-Id: I87ab7673dd74d9275dc043eb556ce980d353b810

Change-Id: If20101daba52df4a41abe5e4606b317761bc936b

Change-Id: Iaa85ff659906b438ef80efc70b51ee8b82755ddd

As part of the docs migration work[0] for Pike we need to switch to use the
openstackdocstheme.

[0]https://review.openstack.org/#/c/472275/

Change-Id: Id63951348211bdcb2b189455968bdfed40857815