Skip to content
Snippets Groups Projects
  1. May 17, 2020
    • Michal Nasiadka's avatar
      CI: Add ansible-lint to tox · d8f31e0a
      Michal Nasiadka authored
      * Reworked tox pep8 into linters job, that runs:
        - pep8
        - bandit
        - bashate
        - doc8
        - yamllint
        - ansible-lint (validate-all-files.py + ansible-lint)
      
      * Skip E701 - missing galaxy_info in meta and E602 see [1].
      * Skip E301 and E503 - followup later in a separate change
      * Added ansible-role-jobs to zuul.d/project.yaml which will run
        openstack-tox-linters job in check queue
      * Fixed remaining style issue
      * Made tox and docs reference the new env for linters
      * Dropped pype environment (not supported)
      
      [1]: https://github.com/ansible/ansible-lint/issues/457
      
      Change-Id: I494b4b151804aac8173120e6c6e42bc2fdb00234
      d8f31e0a
  2. May 13, 2020
    • Ghanshyam Mann's avatar
      Fix hacking min version to 3.0.1 · 7bb397a8
      Ghanshyam Mann authored
      flake8 new release 3.8.0 added new checks and gate pep8
      job start failing. hacking 3.0.1 fix the pinning of flake8 to
      avoid bringing in a new version with new checks.
      
      Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
      flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
      break the pep8 job if new check are added.
      
      To avoid similar gate break in future, we need to bump the hacking min
      version.
      
      - http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
      
      Change-Id: I4b11eaad9eac9985342a00e583f16e379a2ad04a
      7bb397a8
  3. May 11, 2020
    • Will Szumski's avatar
      Stop mocking ansible modules globally · 4fcbdd77
      Will Szumski authored
      This causes non-local side effects that are hard to track down. E.g:
      
      --- import errors ---
      Failed to import test module: tests.test_merge_yaml
      Traceback (most recent call last):
        File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
          module = self._get_module_from_name(name)
        File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
          __import__(name)
        File "/home/will/code/kolla-ansible/tests/test_merge_yaml.py", line 19, in <module>
          from ansible.errors import AnsibleModuleError
      ModuleNotFoundError: No module named 'ansible.errors'; 'ansible' is not a package
      
      This `'ansible' is not a package` message occurs because ansible is a Mock.
      
      Depends-On: https://review.opendev.org/#/c/726768/
      Change-Id: Iddbdd3d855daadbf12536cc990559e6b8e123051
      4fcbdd77
  4. Apr 26, 2020
    • Radosław Piliszek's avatar
      Cleanup py27 support · 234272eb
      Radosław Piliszek authored
      Removes and/or replaces all mentions of py27.
      
      Cleans up obsolete requirements and their lower-constraints.
      
      Separates test-requirements.
      
      Makes lower-constraints pass outside of CI (MarkupSafe).
      
      Adds FIXMEs about some hacky Mocks that may misbehave.
      
      Change-Id: Ifc090bf3c1db17d8542ee591c91e8225a597bfe2
      234272eb
  5. Apr 04, 2020
    • Andreas Jaeger's avatar
      Update hacking for Python3 · 45448976
      Andreas Jaeger authored
      The repo is Python 3 now, so update hacking to version 3.0 which
      supports Python 3.
      
      Fix problems found by updated hacking version.
      
      Remove hacking and friends from lower-constraints, they are not needed
      during installation.
      
      Change-Id: I7ef5ac8a89e94f5da97780198619b6facc86ecfe
      45448976
  6. Oct 23, 2019
  7. Dec 27, 2018
    • confi-surya's avatar
      Update hacking version · b41309ef
      confi-surya authored
      Use latest release 1.1.0 and compatible changes w.r.t pep8
      
      Change-Id: Ie5e5417a1d8481bb59d516a320bd7cc1dd89591e
      b41309ef
  8. Jul 24, 2018
  9. Jun 08, 2018
  10. May 21, 2018
  11. May 09, 2018
    • ghanshyam's avatar
      Gate fix: Cap hacking to avoid gate failure · ccd542f7
      ghanshyam authored
      hacking is not capped in g-r and it is in
      blacklist for requirement as hacking new version
      can break the gate jobs.
      
      Hacking can break gate jobs because of various
      reasons:
      - There might be new rule addition in hacking
      - Some rules becomes default from non-default
      - Updates in pycodestyle etc
      
      That was the main reason it was not added in g-r
      auto sync also. Most of the project maintained the
      compatible and cap the hacking version in
      test-requirements.txt and update to new version when
      project is ready. Bumping new version might need code
      fix also on project side depends on what new in that
      version.
      
      If project does not have cap the hacking version then,
      there is possibility of gate failure whenever new hacking
      version is released by QA team.
      
      Example of such failure in recent release of hacking 1.1.0
      - http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
      
      Change-Id: I05790c5f946a4127fe6c8d9867cc618cb83d67fb
      ccd542f7
  12. Mar 15, 2018
  13. Mar 14, 2018
  14. Mar 10, 2018
  15. Mar 06, 2018
  16. Jan 24, 2018
  17. Jan 17, 2018
  18. Jan 16, 2018
  19. Nov 16, 2017
  20. Sep 26, 2017
  21. Sep 13, 2017
  22. Sep 12, 2017
  23. Sep 06, 2017
  24. Jul 27, 2017
  25. Jul 14, 2017
  26. Jul 02, 2017
  27. Jun 27, 2017
  28. Jun 06, 2017
  29. May 22, 2017
  30. May 15, 2017
  31. Apr 06, 2017
    • Mohammed Naser's avatar
      Remove graphiz from test-requirements.txt · 034a0f58
      Mohammed Naser authored
      With the split of kolla and kolla-ansible, it seems that this
      dependency was carried over as it is used when generating
      graphs for build sequences.
      
      This patch removes it as the build process is not part of this
      project anymore.
      
      Change-Id: I7fd59fe703c2f06c003c8acda15f2a06d3fd7f3f
      034a0f58
    • Mohammed Naser's avatar
      Remove python-swiftclient from test-requirements.txt · 85b9da45
      Mohammed Naser authored
      It seems that it was added back in Liberty where an effort was
      started to setup functional tests, however it is not used at the
      moment.
      
      This patch removes it from the list of dependencies.  With time,
      Tempest should handle all integration checks.
      
      Change-Id: I9e1990e93abc6e3001f499ccc8d40b6104ed2d93
      85b9da45
    • Mohammed Naser's avatar
      Remove python-heatclient from test-requirements.txt · d6bd9e6b
      Mohammed Naser authored
      It seems that it was added back in Liberty where an effort was
      started to setup functional tests, however it is not used at the
      moment.
      
      This patch removes it from the list of dependencies.  With time,
      Tempest should handle all integration checks.
      
      Change-Id: Ieb3a000eda58dcb642cbd099273c91ad355bfb85
      d6bd9e6b
    • Mohammed Naser's avatar
      Remove python-barbicanclient from test-requirements.txt · c014d69b
      Mohammed Naser authored
      It seems that it was added back in Liberty where an effort was
      started to setup functional tests, however it is not used at the
      moment.
      
      This patch removes it from the list of dependencies.  With time,
      Tempest should handle all integration checks.
      
      Change-Id: I9dddd470db9dc42a6fa7dbe138c0c6189d8afdd7
      c014d69b
  32. Mar 29, 2017
  33. Feb 15, 2017
  34. Jan 27, 2017
  35. Jan 16, 2017
  36. Dec 05, 2016
  37. Nov 27, 2016
Loading