To make sure we can find the yaml warning before code merge[1].
We can enable strict mode to treat warning as error[2].

[1] https://review.openstack.org/#/c/573482/1
[2] http://yamllint.readthedocs.io/en/stable/configuration.html#errors-and-warnings

Change-Id: I0b54bc2bd384f092f2fcd1b0396e133a0d95befe

We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: Ie0eca8c8627ab67c7c4aeccdc8607e36a259f13c

For compliance with the Project Testing Interface [1]
as described in [2]

[1]
https://governance.openstack.org/tc/reference/project-testing-interface.html
[2]
http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html

doc8 command is dropped from docs tox envs.
So this affect nothing and run in PEP8.

Related-Bug: #1765348

Depends-On: Icc7fe3a8f9716281de88825e9d5b2fd84de3d00a
Change-Id: Idf9a16111479ccc64004eac9508da575822a3df5

This patchset implements yamllint test to all *.yml
files.

Also fixes syntax errors to make jobs to pass.

Change-Id: I3186adf9835b4d0cada272d156b17d1bc9c2b799

Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.

Change-Id: I4279572d8eff5434c997717e5cb973afdce97de8
Depends-On: https://review.openstack.org/555034


Signed-off-by: Doug Hellmann <doug@doughellmann.com>

Gates only build deploy-guide docs, not every doc.
This change clean doc errors, only Line to long.

Also, removes doc/build folder in tox doc environment.
doc/build is folder where previus executions are stored
causing next execution to fail due rendered versions does
not follow doc style checks.

Change-Id: I623a7ee245729a06509f3a7039d5d5ed3813d977

- Bandit tests are executed in kolla directory,
  in kolla ansible this directory is kolla_ansible.

- Error is silently ignored:
  Files skipped (1):
  	kolla (No such file or directory)

- Also, in ansible/ there is python code in more places
  than only ansible/library, remove library to pass test
  over the whole ansible directory

- Debug tests fails due cannot import tests.
  ImportError: Start directory is not importable: './kolla-ansible/tests'

Change-Id: I0716034c382209b385105bb3a6e0bb7334076e45

The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.

Change-Id: I7762918aa4d78028d1ceb2cc727c3c7dedd05a00

* This patch moves the tox environment and deployment
guide placeholder files introduced in https://review.openstack.org/#/c/422931
from the kolla/ repository to the kolla-ansible/repository
* Remove or add content as needed

Change-Id: I10cf4b5baaf7f7fed7df800194a0c326372a22fb

Enabled the cover environment for kolla-ansible in tox

Change-Id: Ic9f0dbc14ff9f4ef3d82bd06eb58fc145cb121d9
Closes-bug: #1655948

"etc/oslo-config-generator" is being use in kolla repo
too.
Closes-Bug: #1652650

Change-Id: I012830ac3212ebfe954483f076f84541f609bb44

To be co-installable with other OpenStack projects and have consistent
testing it's a good idea (tm) to use constraints when creating tox
environments.

Change-Id: I83d684d90309ad6109e7f6c21a9c2cad4a5371e2

* rename package name from kolla to kolla-ansible
* remove docker for data_files
* remove kolla docker
* remove kolla-build console_scripts

Change-Id: I53abbf79dffb54eb785a39ba04d375bc4e4f27b0

* Build kolla image by using kolla project's code
* bump openstack_release to 4.0.0
* Remove tox deploy related env, it is useless now.

Depends-On: I132ee005bce993cbadf411697817c2e95548dc81
Change-Id: Id899eb39d476b95130fbeb43adf4fd49ef32be32

Change-Id: If3cfda8a1bcb0ec0af39c0f7a067ead1f68cb4ff

Build related jobs are removed in project-config, remove the related tox
env.

Change-Id: If1112b688fed185ba93a2d28a1ba3e77037d392c

All json file in Kolla are json.j2 file, it shold be render as jinja
template, then validate by using json.

Change-Id: Ibabbe435116fd255d68347e00407156db76fedfe
Closes-Bug: #1634447

bandit is a security linter and can be made voting now. Instead of
starting another virtual machine, run it as part of the generic linting
target which is pep8.

Change-Id: I6a8f7aa2b60bd96d55b37b6cc2a371069d6d5e6a

TrivialFix

Change-Id: I817aa52caf56b7d54b266e553db6db1ceb38b773
Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>

TrivialFix

Change-Id: I6f32ce7033fe5a8b8f628a8f52dde67b9540083d

Currently __pycache__ directory, which also holds
python bytecode is not deleted when running tox.
TrivialFix

Change-Id: I0fdcf9a3f9b01cee813eefdbfe29d208dd67f826

* Inspected each error and fixed / added nosec where appropriate.
* build-swift-ring.py which was throwing sec errors is no longer used so
  removed it.
* Removed the dev/ directory from being checked.

Closes-Bug: #1617713
Change-Id: I25664cabca4137e5c9f499c1af3f5ce78b86fb56

This will test all rst files inside the doc directory for style issues with
doc8 (an opinionated style checker for rst styles of documentation).

This will fix all syntax issues identified by doc8 and will improve
the syntax.

Change-Id: Id1b9563e07e77e306aef5a0767c98c27f87c5c0e

Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.

Change-Id: Ia7b1fb88ac108e1e8fd6ed963967e731ae3ca5a4
Closes-Bug: #1603006

Change-Id: Icb47ba8b13b13889e28bb285321f11344400edc2
Closes-Bug:#1582618

The Ubuntu Mitaka repo is release, and we have add it.
So it is time to add the Ubuntu binary gate.

Closes-Bug: #1560386
Change-Id: I29d01147595c4ebebfa00798d01d5fd7398123a6

A recent change related to sudo securepath broke how sudo -E
works.  Now the PATH is reset by sudo as set by tox.  As a result
we can no longer rely on sudo -E anywhere in our gating system
relating to path inheritence from the parent shell.

This patch uses a shell operation in the setup_nodes.yml code
to chmod the docker socket to 666 so docker containers can build
properly.  Now docker operations don't return a permission denied
and we no longer require the sudo -E operation in any of our tox
scripts.  This isn't a security vulnerability because our gate
scripts are only meant to be run in OpenStack infrastructure.
To make this more clear I recommend moving these shell scripts to
tests/gate.

Change-Id: I5b3d6e280e3c12a25defedb14b5589ba642043fa
Closes-Bug: #1562383

For proper release note generation on the releases.openstack.org
website, this change will need to be backported into mitaka and
liberty as well.  Then a special one-file reno file will have to
be added for mitaka describing the features and the same story
for liberty.

See log of the discussion here:
http://eavesdrop.openstack.org/irclogs/%23openstack-release/%23openstack-release.2016-03-23.log.html#t2016-03-23T18:00:05

Change-Id: I3c298ae08ec4645f384ea5829cb0851fe82f4557
Partially-Implements: blueprint add-reno

Bandit is a job that parses and analyzes python code to detect
common insecure programming practices.

TrivialFix

Change-Id: Iea23a9bd23b25827043f02aa1a62fb0724f1d0ee

Implements: blueprint add-hacking

Change-Id: Ia24a263555b9c1eb11e61b9d3fe89612a89daed6

Change-Id: Ic5c0e266639c8ed76d0af473d076d9ae6749102a
Implements: bp oraclelinux-gate

TrivialFix

Change-Id: Icd69a4d6de8ef222b219e758fa38d58f2c98f505

According to the PTI (=Python Test Interface,
http://governance.openstack.org/reference/cti/python_cti.html), pep8
is the interface for codestyle checks. Move all tests from linters to
pep8.

This change will be followed by a change to project-config to use pep8
for testing in the gate.

Change-Id: I1a48f4b1e0b0950640192bcfc55121619a844b50

Change-Id: I5c83b28ce3ef6c4080c68fa2fa353ad118ef7b71
Depends-On: I48faeb61fd3d630e7d7b6c949afcf10f724b0b72

The existing gate partitioned a disk for use with docker, depending
on the gate it would use the swap disk (RAX) or a spare disk (HP).
However, with the new gates (Bluebox + OVH) there is neither a spare
disk nor a swap disk. This leaves us with one choice: File based loop
device.

This patch creates a file at /swapfile to ensure we have swap. It
creates a file at /docker to ensure we have a loop device for Docker.

Right now the /docker file is 10GB and the /swapfile is 4GB due to
size limitations in the gate across all servers and types. This has
proven to be enough space for all our current tests.

Additionally, reduce the number of threads the gate uses to 4 to
prevent the lockup and hour timeout we have been seeing as more
recently in the gate.

The scripts that setup the gate are moved to the tools directory
rather than the tests directory to match the structure of the other
projects.

Partially-Implements: blueprint functional-testing-gate

Change-Id: I3e370f2382b6df36103d8b2ceda9b21d9b4229d5

In an effort to reduce the number of gates, we can combine
non-conflicting jobs as we have already done with pep8 and bashate

TrivialFix

Change-Id: I81c2e523c563f8c761b57c8f20ca807d59da5d68

TrivialFix

Change-Id: I427bd3207de4ae87ab98dc024c4e2d98f0b572dd

To solve the problem of "db type could not
be determined" on py34 we have to run first
the py34 env to, then, run py27.

This patch puts py34 first on the tox.ini list
of envs to avoid this problem to happen.
Closes-Bug: #1489059

Change-Id: I4f791dfa620eacdd76cd46f193e190071ab64b6c

The linters gate combindes pep8 and bashate (and then any other
linters we want). This changes bashate to be a sript rather than doing
a script inline. This matches the way other projects (and
project-config themselves) uses bashate [1].

Once a change upstream merges we can remove the redundant pep8 and
bashate gates.

[1] https://github.com/openstack-infra/project-config/blob/master/tox.ini#L11
https://github.com/openstack-infra/project-config/blob/master/tools/run-bashate.sh

Related-Id: I2afa7931bf3e18798b95a8af33ccf5ef761c4ad5

TrivialFix

Change-Id: I2ea2c1156e1b4de008f19e333e2740795dc406de

Change-Id: Iaf58463bd156924839062b8284a2d7151a153db5