Skip to content
Snippets Groups Projects
  1. Nov 07, 2023
  2. May 31, 2023
    • Maksim Malchuk's avatar
      Fix passwords.yml permissions · 5fd81170
      Maksim Malchuk authored
      
      The kolla-genpwd, kolla-mergepwd, kolla-readpwd and kolla-writepwd
      commands now creates or updates passwords.yml with correct
      permissions. Also they display warning message about incorrect
      permissions.
      
      Closes-Bug: #2018338
      Change-Id: I4b50053ced9150499d1d09fd4a0ec2e243cf938b
      Signed-off-by: default avatarMaksim Malchuk <maksim.malchuk@gmail.com>
      5fd81170
  3. May 24, 2022
    • Marcin Juszkiewicz's avatar
      genpwd: handle lack of password file nicer · 333c74fe
      Marcin Juszkiewicz authored
      From:
      
      (kolla) 13:11 (s) marcin@puchatek:kolla-ansible$ kolla-genpwd
      Traceback (most recent call last):
        File "/home/marcin/.virtualenvs/kolla/bin/kolla-genpwd", line 8, in <module>
          sys.exit(main())
        File "/home/marcin/.virtualenvs/kolla/lib/python3.10/site-packages/kolla_ansible/cmd/genpwd.py", line 135, in main
          genpwd(passwords_file, length, uuid_keys, ssh_keys, blank_keys,
        File "/home/marcin/.virtualenvs/kolla/lib/python3.10/site-packages/kolla_ansible/cmd/genpwd.py", line 59, in genpwd
          with open(passwords_file, 'r') as f:
      FileNotFoundError: [Errno 2] No such file or directory: '/etc/kolla/passwords.yml'
      
      To:
      
      (kolla) 13:17 (s) marcin@puchatek:kolla-ansible$ kolla-genpwd
      ERROR: Passwords file "/etc/kolla/passwords.yml" is missing
      
      Change-Id: I18a9559daeb3d124a03dcb735ebb01a2cf24f617
      333c74fe
  4. Mar 30, 2022
    • Michal Nasiadka's avatar
      neutron: add ssh key · 7fcf3ca3
      Michal Nasiadka authored
      This key can be used by users in networking-generic-switch
      scenario instead of adding cleartext password in ml2_conf.ini.
      
      Change-Id: I10003e6526a55a97f22678ab81c411e4645c5157
      7fcf3ca3
  5. Dec 22, 2020
  6. Oct 02, 2020
    • wu.chunyang's avatar
      Implement automatic deploy of octavia · 4a58f423
      wu.chunyang authored
      
      this patchset has implemented:
        - network (lb-mgmt-net)
        - security groups and rules (used by amphora and health manager)
        - amphora flavor (used by amphora)
        - nova keypair (used by amphora at the time of debugging)
      
      Add a octavia_amp_listen_port variable which used by amphora
      Add amp_image_owner_id in octavia.conf
      
      Implements: blueprint implement-automatic-deploy-of-octavia
      Co-Authored-By: default avatarzhangchun <zhangchun@yovole.com>
      
      Depends-On: https://review.opendev.org/652030
      
      Change-Id: I67009d046925cfc02c1e0073c80085c1471975f6
      4a58f423
  7. May 22, 2020
    • Mark Goddard's avatar
      Improve error reporting in password utilities · 620b808c
      Mark Goddard authored
      The kolla-genpwd and kolla-mergepwd commands can be used to manipulate
      the kolla passwords.yml file. The format is a YAML encoded dict of
      password variable names to their values. If the format is not a dict,
      the error messages are unhelpful.  In particular, this can happen if the
      file is encrypted e.g. via Ansible Vault.
      
      For kolla-genpwd:
      
          AttributeError: 'NoneType' object has no attribute 'items'
      
      For kolla-mergepwd:
      
          AttributeError: 'NoneType' object has no attribute 'update'
      
      This change adds a more friendly message.
      
      Change-Id: I27f0835b904e05006ae401adf383090322e1b891
      Closes-Bug: #1880220
      620b808c
  8. May 17, 2020
    • gugug's avatar
      Enable W503 for flake8 check · 22f7aecb
      gugug authored
      W503 and W504 are incompatible and we need to choose one of them.
      Existing codes follows W503, so we disable W504.
      
      Change-Id: Ic745e956dd332eb0fa49b93c1e6acb12f8a7f26c
      22f7aecb
  9. Feb 11, 2020
  10. Oct 15, 2019
    • Ionut Balutoiu's avatar
      Fix Python3 compatibility for kolla-genpwd · e3fccdfa
      Ionut Balutoiu authored
      The method `Fernet.generate_key()` generates a binary string in Python 3:
      ```
      >>> Fernet.generate_key()
      b'qSMZlOK23pZUw_Uyy-ZRPUfPskMXKGCGmhG6AHCFiV8='
      ```
      
      Unless properly written as a string to the Kolla `passwords.yml` file,
      the Fernet key will end up in the final Barbican config like this:
      ```
      [simple_crypto_plugin]
      kek = b'qSMZlOK23pZUw_Uyy-ZRPUfPskMXKGCGmhG6AHCFiV8='
      ```
      
      Due to the fact that the key is incorrectly written to the barbican
      config file (it should be written as a string), every barbican secret
      store fails with:
      
      ```
      barbican.api.controllers   File "/var/lib/kolla/venv/lib/python3.6/site-packages/barbican/plugin/store_crypto.py", line 83, in store_secret
      barbican.api.controllers     encrypting_plugin, context.project_model)
      barbican.api.controllers   File "/var/lib/kolla/venv/lib/python3.6/site-packages/barbican/plugin/store_crypto.py", line 290, in _find_or_create_kek_objects
      barbican.api.controllers     kek_meta_dto = plugin_inst.bind_kek_metadata(kek_meta_dto)
      barbican.api.controllers   File "/var/lib/kolla/venv/lib/python3.6/site-packages/barbican/plugin/crypto/simple_crypto.py", line 104, in bind_kek_metadata
      barbican.api.controllers     encryptor = fernet.Fernet(self.master_kek)
      barbican.api.controllers   File "/var/lib/kolla/venv/lib/python3.6/site-packages/cryptography/fernet.py", line 38, in __init__
      barbican.api.controllers     "Fernet key must be 32 url-safe base64-encoded bytes."
      barbican.api.controllers ValueError: Fernet key must be 32 url-safe base64-encoded bytes.
      ```
      
      This commit fixes the issue described above by properly writing
      the Fernet key as a string to the Kolla `passwords.yml` file.
      
      Closes-Bug: #1848191
      Change-Id: I27fc0159c889bc2e1576fdd69b7d02a320b620f8
      e3fccdfa
  11. Mar 10, 2019
  12. Jul 26, 2018
    • Eduardo Gonzalez's avatar
      Use fernet for barbican crypto key · b80a63f3
      Eduardo Gonzalez authored
      Sha password is not always valid for barbican cripto key.
      Use a fernet key so it always gets valid.
      
      Not need release note for upgrade, users with a working
      barbican not regenerate passwords, only new passwords will
      get new type.
      
      Change-Id: Ic8c4ca63219295d697062cff9cbf30fadbe49bf3
      b80a63f3
  13. May 22, 2018
    • Borne Mace's avatar
      Updated genpwd to work with python35 · f1768ef7
      Borne Mace authored
      Due to the changes in hmac.new and how binary strings
      are dumped in yaml.safe_dump some changes were needed to
      make sure that we dumped only strings, not binary strings.
      
      Change-Id: Ic2fbcf2347023c1e9e666203dfe40dbeaf24ce5f
      f1768ef7
  14. Sep 13, 2017
  15. Jun 02, 2017
  16. Apr 24, 2017
  17. Mar 30, 2017
  18. Mar 22, 2017
  19. Mar 08, 2017
    • Jeffrey Zhang's avatar
      Fix booting from volume failure · d06efcec
      Jeffrey Zhang authored
      Booting from volume require cinder's ceph client secret now. Move cinder
      before nova in site.yml, because nova depends on cinder ceph client key
      now.
      
      Change-Id: I01c9ed80843d98305b8963894c4917c21a35d3ac
      Closes-Bug: #1670676
      d06efcec
  20. Feb 15, 2017
    • Jeffrey Zhang's avatar
      Rename kolla namespace to kolla_ansible · 177fbea7
      Jeffrey Zhang authored
      * Rename kolla namespace to kolla_ansible
      * remove oslo.config.opts entry points which is uesless
      * delete useless tools/version-check.py script
      
      Change-Id: I005dd7223ff23afbb2ce8cbfd0ebec0969102798
      177fbea7
  21. Jan 05, 2017
  22. Dec 20, 2016
  23. Nov 23, 2016
  24. Oct 14, 2016
    • Martin André's avatar
      Consistently set sys path when using local tools · 9660b578
      Martin André authored
      Consistently set the search path to prefer PROJECT_ROOT as the source
      of packages to import if we are using local tools instead of pip
      installed kolla tools.
      
      TrivialFix
      
      Change-Id: Idd1d98bb82a8f1ddb32d1bdb23f346b461534b9f
      9660b578
  25. Sep 06, 2016
    • zhubingbing's avatar
      Add gnocchi ansible role · 89392f4f
      zhubingbing authored
      Partially-Implements: blueprint ansible-gnocchi
      
      Change-Id: I8dd0460bd21ac0a233fab0142ec7b6079459bdc2
      89392f4f
  26. Aug 31, 2016
    • Sean Mooney's avatar
      adds bifrost ssh key generation · 538dbac2
      Sean Mooney authored
      - This change extend the genpwd.py
        command to generate an ssh key pair
        bifrost.
      - This change bifrost config and bootstrap
        task to install the generated keys.
      - This change updates the bifrost guide to
        discribe how to provide your own key.
      
      Change-Id: I05243f58843d9195cace253dff5628fae89c78e8
      Implements: blueprint bifrost-support
      538dbac2
  27. Aug 28, 2016
    • Paul Bourke's avatar
      Fix bandit gate jobs · fc30d583
      Paul Bourke authored
      * Inspected each error and fixed / added nosec where appropriate.
      * build-swift-ring.py which was throwing sec errors is no longer used so
        removed it.
      * Removed the dev/ directory from being checked.
      
      Closes-Bug: #1617713
      Change-Id: I25664cabca4137e5c9f499c1af3f5ce78b86fb56
      fc30d583
  28. Aug 25, 2016
    • Shaun Smekel's avatar
      Add full support for fernet · 1c68ae38
      Shaun Smekel authored
      This addresses the ansible aspects of fernet key bootstrapping as
      well as distributed key rotation.
      
      - Bootstrapping is handled in the same way as keystone bootstrap.
      - A new keystone-fernet and keystone-ssh container is created to allow
        the nodes to communicate with each other (taken from nova-ssh).
      - The keystone-fernet is a keystone container with crontab installed.
        This will handle key rotations through keystone-manage and trigger
        an rsync to push new tokens to other nodes.
      - Key rotation is setup to be balanced across the keystone nodes using
        a round-robbin style. This ensures that any node failures will not
        stop the keys from rotating. This is configured by a desired token
        expiration time which then determines the cron scheduling for each
        node as well as the number of fernet tokens in rotation.
      - Ability for recovered node to resync with the cluster. When a node
        starts it will run sanity checks to ensure that its fernet tokens
        are not stale. If they are it will rsync with other nodes to ensure
        its tokens are up to date.
      
      The Docker component is implemented in:
        https://review.openstack.org/#/c/349366
      
      Change-Id: I15052c25a1d1149d364236f10ced2e2346119738
      Implements: blueprint keystone-fernet-token
      1c68ae38
  29. Aug 10, 2016
  30. May 21, 2016
  31. Apr 03, 2016
    • Jeffrey Zhang's avatar
      Implement nova-ssh container · 42420830
      Jeffrey Zhang authored
      Add a nova-ssh container to handle the `nova migrate` and
      `nova resize` case, in which the nova will use ssh to copy
      files between machines.
      
      Change-Id: Ie6675943f3aeabfbba8589d308d55b9c89d732db
      Closes-Bug: #1562141
      42420830
  32. Mar 21, 2016
    • SamYaple's avatar
      Add generate_passwords.py to generate passwords · f03e06e0
      SamYaple authored
      
      As with all tools, this is a first pass at the generation. Perhaps we
      even want to move this into kolla/kolla/cmd and be generated with tox
      itself in the future.
      
      This tool, when run, will only populate empty fields that have no
      values meaning that it is safe to run repeatedly on the same file.
      
      Of note, there is no way to preserve comments in the file after it has
      been processed by the yaml parser in python. Comments and sections
      will remain in the passwords.yml template for additional documentation
      if the user wishes to populate the file themselves.
      
      Use SystemRandom and clean up the docs a bit to not use pronouns.
      
      Co-Authored-By: default avatarSteven Dake <stdake@cisco.com>
      
      Closes-Bug: #1559266
      Change-Id: I2932d592df8871f1b7811059206d0b4d0553a687
      f03e06e0
Loading