Skip to content
Snippets Groups Projects
  1. Mar 17, 2020
    • Doug Szumski's avatar
      Make Fluentd config folders readable · c92378d7
      Doug Szumski authored
      Currently, config folders lack the execute bit so Fluentd
      cannot read the config and just does nothing when it starts up. This
      change explicitly sets the execute bit on folders which need it,
      rather than doing it in a more generic way which is more risky from
      a security perspective.
      
      Change-Id: Ia840f4b67043df4eaa654f47673dcdc973f13d9c
      Closes-Bug: #1867754
      c92378d7
  2. Mar 15, 2020
  3. Mar 10, 2020
    • Will Szumski's avatar
      Use macro to avoid repetition · a1c51b73
      Will Szumski authored
      I didn't use a for loop as the logic for omitting the
      comma for the final element dirties the logic.
      
      Change-Id: Id29d5deebcc5126d69a1bd8395e0df989f2081f0
      a1c51b73
    • yj.bai's avatar
      Add notify restart container when cert changed · d3cc2f67
      yj.bai authored
      
      When change the cert file in /etc/kolla/certificate/.
      The certificate in the container has not changed.
      So I think can use kolla-ansible deploy when certificate is
      changed. restart <container>
      
      Partially-Implements: blueprint custom-cacerts
      
      Change-Id: Iaac6f37e85ffdc0352e8062ae5049cc9a6b3db26
      Signed-off-by: default avataryj.bai <bai.yongjun@99cloud.net>
      d3cc2f67
    • Will Szumski's avatar
      Delete stale fluent config on restart · e7870e9d
      Will Szumski authored
      We already only include .conf files in fluent.conf:
      
      (fluentd)[fluentd@cpu-e-1041 /etc/fluentd]$ cat fluent.conf
      @include input/*.conf
      @include filter/*.conf
      @include format/*.conf
      @include output/*.conf
      
      so this change should not cause ill effect. This works because of the
      merge option in config files:
      
      merge: merges the source directory into the target directory instead of
      replacing it. Boolean, defaults to false.
      
      see https://docs.openstack.org/kolla/latest/admin/kolla_api.html#kolla-api-external-config
      
      Change-Id: I28f63ec81f1ea5bc4a213d053bfb2c04388d5925
      Closes-Bug: #1862211
      e7870e9d
  4. Mar 02, 2020
  5. Feb 11, 2020
  6. Feb 04, 2020
    • Doug Szumski's avatar
      Disable Fluentd Monasca plugin retry limit · f19eb7de
      Doug Szumski authored
      By default a retry limit of 17 exists. When the limit is reached buffered
      logs are discarded. To avoid this, we disable the retry limit. The risk of
      bringing down the host by filling the Fluent data docker volume is managed
      by the maximum buffer size which is 2GB by default.
      
      In summary, after this change, the net behaviour is that Fluentd should
      buffer up to a maximum of 2GB of logs locally, and attept to post them to
      the Monasca Log API at intervals not exceeding 30 minutes.
      
      Closes-Bug: #1855702
      Change-Id: I0d5a3dab29635c00411f4f51e5a0721726df2abd
      f19eb7de
    • Doug Szumski's avatar
      Enable buffering to file for Monasca logs · 5293b129
      Doug Szumski authored
      This enables buffering to file, rather than memory for Monasca logs.
      A dedicated docker volume is used for the file buffer. If a post
      to the Monasca Log API fails, retries will be made using an exponential
      backoff algorithm with a maximum retry interval of 30mins. The maximum
      interval is set relatively low to try and reduce the risk of large
      buffers accumulating, and therefore the risk of overloading the Monasca
      Log API.
      
      Closes-Bug: #1855700
      Change-Id: Ib5286e9dbaf2bc92d2f4960b2131223ab5dbdbec
      5293b129
  7. Jan 28, 2020
    • James Kirsch's avatar
      Copy CA into containers. · 511ba9f6
      James Kirsch authored
      When kolla_copy_ca_into_containers is set to "yes", the Certificate
      Authority in /etc/kolla/certificates will be copied into service
      containers to enable trust for that CA. This is especially useful when
      the CA is self signed, and would not be trusted by default.
      
      Partially-Implements: blueprint custom-cacerts
      
      Change-Id: I4368f8994147580460ebe7533850cf63a419d0b4
      511ba9f6
  8. Jan 14, 2020
  9. Jan 10, 2020
    • Mark Goddard's avatar
      CentOS 8: Support variable image tag suffix · 9755c924
      Mark Goddard authored
      For the CentOS 7 to 8 transition, we will have a period where both
      CentOS 7 and 8 images are available. We differentiate these images via a
      tag - the CentOS 8 images will have a tag of train-centos8 (or
      master-centos8 temporarily).
      
      To achieve this, and maintain backwards compatibility for the
      openstack_release variable, we introduce a new 'openstack_tag' variable.
      This variable is based on openstack_release, but has a suffix of
      'openstack_tag_suffix', which is empty except on CentOS 8 where it has a
      value of '-centos8'.
      
      Change-Id: I12ce4661afb3c255136cdc1aabe7cbd25560d625
      Partially-Implements: blueprint centos-rhel-8
      9755c924
  10. Dec 30, 2019
  11. Dec 18, 2019
  12. Dec 09, 2019
  13. Dec 01, 2019
  14. Nov 18, 2019
  15. Nov 05, 2019
  16. Oct 29, 2019
    • Isaac Prior's avatar
      Parse MariaDB log messages in different formats into Fluentd · 233a187a
      Isaac Prior authored
      MariaDB logs contain two different log message formats, one output
      from mysqld and one from mysqld_safe. This patch splits the message
      formats by tag and parses them separately.
      
      Change-Id: I58857be67ae387eeda7487811a6af85b0f95970c
      Closes-Bug: #1845629
      233a187a
  17. Oct 16, 2019
    • Radosław Piliszek's avatar
      Implement IPv6 support in the control plane · bc053c09
      Radosław Piliszek authored
      Introduce kolla_address filter.
      Introduce put_address_in_context filter.
      
      Add AF config to vars.
      
      Address contexts:
      - raw (default): <ADDR>
      - memcache: inet6:[<ADDR>]
      - url: [<ADDR>]
      
      Other changes:
      
      globals.yml - mention just IP in comment
      
      prechecks/port_checks (api_intf) - kolla_address handles validation
      
      3x interface conditional (swift configs: replication/storage)
      
      2x interface variable definition with hostname
      (haproxy listens; api intf)
      
      1x interface variable definition with hostname with bifrost exclusion
      (baremetal pre-install /etc/hosts; api intf)
      
      neutron's ml2 'overlay_ip_version' set to 6 for IPv6 on tunnel network
      
      basic multinode source CI job for IPv6
      
      prechecks for rabbitmq and qdrouterd use proper NSS database now
      
      MariaDB Galera Cluster WSREP SST mariabackup workaround
      (socat and IPv6)
      
      Ceph naming workaround in CI
      TODO: probably needs documenting
      
      RabbitMQ IPv6-only proto_dist
      
      Ceph ms switch to IPv6 mode
      
      Remove neutron-server ml2_type_vxlan/vxlan_group setting
      as it is not used (let's avoid any confusion)
      and could break setups without proper multicast routing
      if it started working (also IPv4-only)
      
      haproxy upgrade checks for slaves based on ipv6 addresses
      
      TODO:
      
      ovs-dpdk grabs ipv4 network address (w/ prefix len / submask)
      not supported, invalid by default because neutron_external has no address
      No idea whether ovs-dpdk works at all atm.
      
      ml2 for xenapi
      Xen is not supported too well.
      This would require working with XenAPI facts.
      
      rp_filter setting
      This would require meddling with ip6tables (there is no sysctl param).
      By default nothing is dropped.
      Unlikely we really need it.
      
      ironic dnsmasq is configured IPv4-only
      dnsmasq needs DHCPv6 options and testing in vivo.
      
      KNOWN ISSUES (beyond us):
      
      One cannot use IPv6 address to reference the image for docker like we
      currently do, see: https://github.com/moby/moby/issues/39033
      (docker_registry; docker API 400 - invalid reference format)
      workaround: use hostname/FQDN
      
      RabbitMQ may fail to bind to IPv6 if hostname resolves also to IPv4.
      This is due to old RabbitMQ versions available in images.
      IPv4 is preferred by default and may fail in the IPv6-only scenario.
      This should be no problem in real life as IPv6-only is indeed IPv6-only.
      Also, when new RabbitMQ (3.7.16/3.8+) makes it into images, this will
      no longer be relevant as we supply all the necessary config.
      See: https://github.com/rabbitmq/rabbitmq-server/pull/1982
      
      For reliable runs, at least Ansible 2.8 is required (2.8.5 confirmed
      to work well). Older Ansible versions are known to miss IPv6 addresses
      in interface facts. This may affect redeploys, reconfigures and
      upgrades which run after VIP address is assigned.
      See: https://github.com/ansible/ansible/issues/63227
      
      Bifrost Train does not support IPv6 deployments.
      See: https://storyboard.openstack.org/#!/story/2006689
      
      
      
      Change-Id: Ia34e6916ea4f99e9522cd2ddde03a0a4776f7e2c
      Implements: blueprint ipv6-control-plane
      Signed-off-by: default avatarRadosław Piliszek <radoslaw.piliszek@gmail.com>
      bc053c09
  18. Oct 01, 2019
    • Mark Goddard's avatar
      Add service-rabbitmq role · 039cc2be
      Mark Goddard authored
      This role can be used by other roles to register RabbitMQ resources.
      Currently support is provided for creating virtual hosts and users.
      
      Change-Id: Ie1774a10b4d629508584af679b8aa9e372847804
      Partially Implements: blueprint support-nova-cells
      Depends-On: https://review.opendev.org/684742
      039cc2be
  19. Sep 26, 2019
    • Kris Lindgren's avatar
      Add a job that *only* deploys updated containers · 2fe0d98e
      Kris Lindgren authored
      Sometimes as cloud admins, we want to only update code that is running
      in a cloud.  But we dont need to do anything else.  Make an action in
      kolla-ansible that allows us to do that.
      
      Change-Id: I904f595c69f7276e71692696471e32fd1f88e6e8
      Implements: blueprint deploy-containers-action
      2fe0d98e
  20. Sep 04, 2019
    • Xing Zhang's avatar
      Improve admin-openrc · f8c3dccd
      Xing Zhang authored
      add clear old environment
      set openstack client to use internalURL
      set manila client to use internalURL
      
      Change-Id: I263fa11ff5439b28d63a6a9ce7ba460cb56fb8e2
      f8c3dccd
  21. Aug 22, 2019
    • Krzysztof Klimonda's avatar
      Implement TLS encryption for internal endpoints · b0ecd8b6
      Krzysztof Klimonda authored
      This review is the first one in a series of patches and it introduces an
      optional encryption for internal openstack endpoints, implementing part
      of the add-ssl-internal-network spec.
      
      Change-Id: I6589751626486279bf24725f22e71da8cd7f0a43
      b0ecd8b6
    • Michal Nasiadka's avatar
      Use fluentd image labels · 4180bee0
      Michal Nasiadka authored
      In order to orchestrate smooth transition to fluentd 0.14.x
      aka 1.0 stable branch aka td-agent 3
      from td-agent repository - use image labels (fluentd_version
      and fluentd_binary).
      
      Depends-On: https://review.opendev.org/676411
      Change-Id: Iab8518c34ef876056c6abcdb5f2e9fc9f1f7dbdd
      4180bee0
  22. Aug 15, 2019
  23. Aug 14, 2019
  24. Jul 30, 2019
  25. Jun 27, 2019
    • Mark Goddard's avatar
      Simplify handler conditionals · de00bf49
      Mark Goddard authored
      Currently, we have a lot of logic for checking if a handler should run,
      depending on whether config files have changed and whether the
      container configuration has changed. As rm_work pointed out during
      the recent haproxy refactor, these conditionals are typically
      unnecessary - we can rely on Ansible's handler notification system
      to only trigger handlers when they need to run. This removes a lot
      of error prone code.
      
      This patch removes conditional handler logic for all services. It is
      important to ensure that we no longer trigger handlers when unnecessary,
      because without these checks in place it will trigger a restart of the
      containers.
      
      Implements: blueprint simplify-handlers
      
      Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
      de00bf49
    • ZijianGuo's avatar
      Add extra volumes support for services that were not previously supported · e610a73e
      ZijianGuo authored
      We don't add extra volumes support for all services in patch [1].
      In order to unify the management of the volume, so we need add extra volumes
      support for these services.
      
      [1] https://opendev.org/openstack/kolla-ansible/commit/12ff28a69351cf8ab4ef3390739e04862ba76983
      
      
      
      Change-Id: Ie148accdd8e6c60df6b521d55bda12b850c0d255
      Partially-Implements: blueprint support-extra-volumes
      Signed-off-by: default avatarZijianGuo <guozijn@gmail.com>
      e610a73e
  26. Jun 19, 2019
  27. Jun 18, 2019
    • Doug Szumski's avatar
      Format internal Fluentd logs · d89a89c2
      Doug Szumski authored
      This change formats internal Fluent logs in a similar way to other
      logs. It makes it easier for a user to identify issues with Fluent
      parsing logs. Any failure to parse a log will be ingested into the
      logging framework and can easily be located by searching for
      'pattern not match' or by filtering for Fluent log warnings.
      
      Change-Id: Iea6d12c07a2f4152f2038d3de2ef589479b3332b
      d89a89c2
    • Doug Szumski's avatar
      Don't drop unmatched Kolla service logs · cfeb9dd9
      Doug Szumski authored
      Kolla service logs which don't match a Fluentd rewriterule get dropped.
      This change prevents that by tagging them with 'unmatched'.
      
      Change-Id: I0a2484d878d5c86977fb232a57c52f874ca7a34c
      cfeb9dd9
    • Doug Szumski's avatar
      Increase log coverage for Monasca · cb404743
      Doug Szumski authored
      Monasca Python service logs prior to this change were being dropped
      due to missing entries in the Fluent record_transformer config file.
      This change adds support for ingesting those logs, and explicitly
      removes support for ingesting Monasca Log API logs to reduce the risk
      of feedback, for example if debug logging is turned on in the Monasca
      Log API.
      
      Change-Id: I9e3436a8f946873867900eed5ff0643d84584358
      cb404743
    • Doug Szumski's avatar
      Ingest non-standard Monasca logs · 4b31fdcf
      Doug Szumski authored
      Presently, errors can appear in Fluentd and Monasca Log API logs due
      to log output from some Monasca services, which do not use Oslo log,
      being processed alongside other OpenStack logs which do.
      
      This change parses these log files separately to prevent these errors.
      
      Change-Id: Ie3cbb51424989b01727b5ebaaeba032767073462
      4b31fdcf
  28. Jun 16, 2019
  29. Jun 06, 2019
    • Mark Goddard's avatar
      Use become for all docker tasks · b123bf66
      Mark Goddard authored
      Many tasks that use Docker have become specified already, but
      not all. This change ensures all tasks that use the following
      modules have become:
      
      * kolla_docker
      * kolla_ceph_keyring
      * kolla_toolbox
      * kolla_container_facts
      
      It also adds become for 'command' tasks that use docker CLI.
      
      Change-Id: I4a5ebcedaccb9261dbc958ec67e8077d7980e496
      b123bf66
Loading