XenServer drivers can be used to deploy hosts with Ironic by
using XenServer VMs to simulate bare metal nodes.

Ironic provides support via the pxe_ssh and agent_ssh drivers
for using a XenServer VM as a bare metal target and do provisioning on it.

Change-Id: Icd39f9f4573cf7c8c654591256f0228ef21d6117

While is not an issue, just an style format,
etc/hosts generated by baremetal role have
some tabs where it shouldn't.

Change-Id: I90d82ea78b3dac7e8ec3f8cc546b67cc61c41536
Closes-Bug: #1692913

Useful api_interface_address variable has been define here:
https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L57
In order to simplify codebase we must use it as much as possible.

Change-Id: I18fec19bf69e05a22a4142a9cd1165eccd022455

cinder-volume will convert the disk locally when boot image from volume
with create new volume. whereas the container only have 10G space in
default, cinder-volume will complain that no space if image is large.

This patch mount cinder volume for cinder-volume and cinder-backup all
the time.

Change-Id: I8c68ea49374dc67839699b81e345cfc390a01fe3
Close-Bug: #1692485

Add configure the VMware Storage Backend in glance-api.
Because of the following document was not updated:
https://docs.openstack.org/developer/glance/configuring.html#configuring-the-vmware-storage-backend

So,see code:
https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/vmware_datastore.py
https://github.com/openstack/glance_store/blob/master/glance_store/backend.py

Partially-implements: blueprint kolla-ansible-support-vsphere

Change-Id: Icb73ec501aabd938eb23257518ce0650a329bef3

Recently added post_config for Kibana does some uri queries, these can
be problematic if run across every node.

Change-Id: I71d2611ae034ff2a85babb8d01419729f406a136

Fix the following error:
openstack_swift_auth is undefined
unsupported parameter for module: project
unsupported parameter for module: role

Change-Id: Id60e3f06e90e708d9054b905bbfd28ff5450fa49
Closes-Bug: #1691388

The Orchestration service automatically assigns the heat_stack_user
role to users that it creates during stack deployment.
To avoid conflicts, do not add this role to users with the heat_stack_owner role.

Closes-Bug: #1690975

Change-Id: I7a4cb7f4a13de7be4fc9ce9c24057ece6a0ced5c

If enable vpnaas,service_plugins value is 'neutron_vpnaas.services
.vpn.plugin.VPNDriverPlugin'.
It throw warning for 'stevedore.named [-]Could not load
neutron_vpnaas.services.vpn.plugin.VPNDriverPlugin'

Closes-Bug: #1690693

Change-Id: Ia00f733da2dcbdd50e3d62dfe98c8f44cc4a1d26

If enable lbaas,service_plugins value is 'neutron_lbaas.services
.loadbalancer.plugin:LoadBalancerPluginv2'.
It throw warning for 'stevedore.named [-]Could not load neutron_lbaas
.services.loadbalancer.plugin.LoadBalancerPluginv2'

Closes-Bug: #1690694

Change-Id: I38d61405710ca88fbdb3cfd72a534986cf933195

Option "notify_on_state_change" from group "DEFAULT" is deprecated. Use
option "notify_on_state_change" from group “notifications".

refer to
https://docs.openstack.org/ocata/config-reference/compute/config-options.html

Change-Id: I18e80ccd5981b81bfd597b94717ed77b13c05222
Closes-Bug: #1690494

On RedHat libvirt is just a metapackage and it does
nothing with libvirt daemon itself if we remove it.
On Ubuntu the correct package name with libvirt daemon
is libvirt-bin.

Closes-Bug: #1690356
Change-Id: Ief8dfd8c038b10878621aefcc8f559aa20dc498b
Signed-off-by: Pavel Glushchak <pglushchak@virtuozzo.com>

Closes-Bug: #1690302
Change-Id: Ice9e6ece862c4102883c6a5f3bbfe2d291077c8d

when statements should not include jinja2 templating delimiters such as
{{ }} or {% %}. Found: {{ ceph_enable_cache | bool }}
Closes-Bug: #1689550

Change-Id: I2ca039b80260cd753026f8fb077c7d25e46c8b13

During cleanup-host, we need remove swift references from fstab.

Change-Id: I18e9a84b0664eb834cf397bcf6d2406abcab47a7
Closes-Bug: #1689285

There is no swift_api_port.
swift_proxy_server_port should be the correct one.

Closes-Bug: #1689260
Change-Id: I63e0edb76603374b479eabf0199c4024ad3e2dbd

The local keyword is used to allow chronyd to appear synchronised to
real time (from the viewpoint of clients polling it), even if it has no
current synchronisation source.

Change-Id: I27d945abb87a37d2fdf972a58c51e2f0994e3de8
Closes-Bug: #1688682

* Use absolute path for panko.conf.j2
* Fix the destination path.

Change-Id: I3abc0bf000be8af3a0cde1f43901245e027bb469
Closes-Bug: #1688681

This patch fix log rotation issue on the following services/program:
- ceph
- chrony
- collectd
- congress
- etcd
- influxdb
- ironic
- kibana
- kuryr
- mongodb
- rally
- tempest
- trove

Change-Id: I1246c071b7340b3267226cefb64a04da1cce9f26
Closes-Bug: #1688649

At this moment haproxy  config.yml notifies
handlers that are not skipped when running
genconfig

Change-Id: I2eab18e3ba709075f21f8dce323fcb2acef43de5
Closes-Bug: #1664674

neutron-openvswitch-agent enter in restarting status in multinode
deployments because br-ex is no longer created on compute nodes
unless DVR is enabled.

This change add a conditional to only add bridge_mappings when
the node is in network or in compute when dvr is enabled.

Change-Id: I9d49158127af7fd78ecbc3d64a7509d1e4ae5672
Closes-Bug: #1688571

Cinder backup requires iSCSI volume and host mount for backing
any iSCSI volume, not only from LVM backend. 'enable_iscsid' is
a catch-all setting for all iSCSI backends that also runs
necessary iSCSI client on the same host.

Change-Id: Ic486a9f72820df2e0a48a18166f043e5ddb5bd0a
Closes-Bug: #1688519

Wait conditions are commonly used by instances to signal various events
back to heat. These instances are unlikely to have access to the
internal API endpoints. OpenStack-Ansible had a similar issue[1] back in
juno and changed to use the public endpoint[2]. The code has now moved
but the default is still in place[3].

This change configures heat to advertise the public API as the endpoint
for wait conditions.

[1] https://bugs.launchpad.net/openstack-ansible/+bug/1459414
[2] https://review.openstack.org/#/c/186221/
[3] https://github.com/openstack/openstack-ansible-os_heat/blob/b1721a7460ba816afabd9bded6e5c79c635bca3a/defaults/main.yml#L48

Change-Id: Id1d66aaa298efa8407db579a899a5aacebe1e6c7
Closes-Bug: #1688331

Chrony drops root to user 'chrony' on startup, so it's config file
should be owned by user this user.

Change-Id: I8ba976cc685d2e50e09211f67507487a1e0e3c5f

wait_for module waits 300 seconds for the port started or stopped.  This
is meaningless and useless in precheck. This patch change timeout to 1
seconds.

Change-Id: I9b251ec4ba17ce446655917e8ef5e152ef947298
Closes-Bug: #1688152

Change-Id: I9978cb714e423863afd5b892419f4176b6d73d92
Closes-Bug: #1686761

sahara-engine service need to run ip netns command in container
when set use_namespaces=true in saraha.conf

Change-Id: I8b10cdd0127e1895ae40dfeed1a5910e6bcd701c
Related-Bug: #1687602
Closes-Bug: #1687624

Change-Id: Ieb6ad24bf76efaafa0f8e7391ad671ce094a8ece
Closes-Bug: #1687635

When Kibana interface is opened for the first time, it requires creating
a default index pattern. To view, analyse and search logs, at least one
index pattern has to be created.
This patch automate "flog-*" default index pattern creation and set it
has default config.

Partially-implements: blueprint default-kibana-dashboard
Change-Id: Ie36696f9ad38ba7e49e65e0793a3b98d9f03ee8d

The following Neutron agents:
- neutron-metadata
- neutron-dhcp-agent
- neutron-l3-agent
- neutron-lbaasv2-agent
- neutron-vpn-agent
doesn't require ml2_conf.ini file.
ml2_conf.ini file is used to managed L2 network configuration.
This config doesn't have to be in DHCP, L3, metadata agents...

We should remove it to avoid restarting these agents in case of
ml2_conf.ini file modification.
Only neutron-server, neutron-openvswitch-agent,
neutron-linuxbridge-agent must be restarted.

Closes-Bug: #1677163
Change-Id: I0876b8a3845d1c2bccd996426a65df1a3a6f7085

With nova cells_v2 at least one compute node is required in
inventory to deploy nova.

This change add prechecks to ensure at least 1 compute is present.

Change-Id: I242518ad3bd149ad245515299301777f6b3bdd08
Closes-Bug: #1686410

Telegraf always restart containers when doing reconfigure, due to
"pid_mode" attribut missing during compare_container.
Hence compare_container always evaluated to True.

Change-Id: I335816ebf99a218a5400b2baae5b55788459bfff
Closes-Bug: #1686349

Rally and Tempest containers doesn't required "privileged" attribut.
This must be cleanup.

Change-Id: Ic8de5162523314dd78dad7d25b36145350749bcc

In order to automate Grafana configuration, this fix automatically
set the InfluxDB datasource. This avoid doing a annoying manual
configuration after Kolla-ansible deployment.

Change-Id: I2b1a63fd371966192f1df0a82cee4711c6324710

YAML files are supposed to start with three dashes to indicate the
beginning of the document.
Nota: Ansible won’t complain if they are missing.

Change-Id: I5cd417971f7af2977e7527b7b454a999718cfcda

The pxelinux.cfg directory gets created but isn't owned by the correct
user. This patch ensures that the permissions are correctly updated.

Change-Id: Ifcb80018b72d40c5d4eccf059d1c3442b71be6f8

Change-Id: I6c769e5231e9d0e327ef6b9928666369d694f5fe
Closes-Bug: #1685692

When docker-py is newer than docker daemon following
APIError may be raised:

client is newer than server (client API version: 1.24, server API version: 1.22)

So it's better to pass api_version='auto' to docker client,
so client will discover suitable version if not specified.

Change-Id: Ib747ed91b315ca762936a6efa6b71a29b2d2ae1e
Signed-off-by: Pavel Glushchak <pglushchak@virtuozzo.com>

The OpenStack Integration Test Suite (Tempest) doesn't use oslo.policy
library.
oslo.policy is not used in codebase and not set in requirements.txt:
https://github.com/openstack/tempest/blob/master/requirements.txt#L14

All policy.json related stuff must be removed.

Change-Id: I0d8ee710979a7eebba1e8fc176450e4c0bcbe757

If used external ceph for cinder,the ceph storage not enable cephx.
So ceph keyring file not does not exist.
Task throw warning of copy over ceph keyring files.

Change-Id: Ibb3cd536c982ad9dede3c2a0ecfc02cdf6e4c1b9
Closes-Bug: #1684461