Fix log rotation for fluentd created files

Overrides default fluentd buffer config to stop log files from using
datestamped filenames, allowing logrotate to manage them.

Closes-Bug: #1940118
Change-Id: I40c4e209470d21e0a02fd447fb628acfdae9fa9d

ansible/roles/common/templates/conf/output/00-local.conf.j2

@@ -3,11 +3,11 @@
   @type copy
   <store>
     @type file
-    path /var/log/kolla/swift/swift_latest.*.log
+    path /var/log/kolla/swift/swift_latest
     append true
-    compress gzip
-    <buffer>
-      timekey_use_utc
+    # Disable timestamp in filename for logs
+    <buffer []>
+      path /var/log/kolla/swift/swift_latest.*.buffer
     </buffer>
   </store>
 {% if log_direct_to_elasticsearch %}
@@ -66,14 +66,17 @@
   @type copy
   <store>
     @type file
-    path /var/log/kolla/haproxy/haproxy_latest.*.log
-    output_tag false
-    output_time false
+    path /var/log/kolla/haproxy/haproxy_latest
     append true
-    compress gzip
-    <buffer>
-      timekey_use_utc
+    # Disable timestamp in filename for logs
+    <buffer []>
+      path /var/log/kolla/haproxy/haproxy_latest.*.buffer
     </buffer>
+    # Don't prepend syslog tag or timestamp to log output
+    <format>
+      output_tag false
+      output_time false
+    </format>
   </store>
 {% if log_direct_to_elasticsearch %}
   <store>
@@ -131,14 +134,17 @@
   @type copy
   <store>
     @type file
-    path /var/log/kolla/glance-tls-proxy/glance-tls-proxy.*.log
-    output_tag false
-    output_time false
+    path /var/log/kolla/glance-tls-proxy/glance-tls-proxy
     append true
-    compress gzip
-    <buffer>
-      timekey_use_utc
+    # Disable timestamp in filename for logs
+    <buffer []>
+      path /var/log/kolla/glance-tls-proxy/glance-tls-proxy.*.buffer
     </buffer>
+    # Don't prepend syslog tag or timestamp to log output
+    <format>
+      output_tag false
+      output_time false
+    </format>
   </store>
 {% if log_direct_to_elasticsearch %}
   <store>
@@ -193,14 +199,17 @@
   @type copy
   <store>
     @type file
-    path /var/log/kolla/neutron-tls-proxy/neutron-tls-proxy.*.log
-    output_tag false
-    output_time false
+    path /var/log/kolla/neutron-tls-proxy/neutron-tls-proxy
     append true
-    compress gzip
-    <buffer>
-      timekey_use_utc
+    # Disable timestamp in filename for logs
+    <buffer []>
+      path /var/log/kolla/neutron-tls-proxy/neutron-tls-proxy.*.buffer
     </buffer>
+    # Don't prepend syslog tag or timestamp to log output
+    <format>
+      output_tag false
+      output_time false
+    </format>
   </store>
 {% if log_direct_to_elasticsearch %}
   <store>

ansible/roles/common/templates/cron-logrotate-haproxy.conf.j2

-"/var/log/kolla/haproxy/haproxy.log"
+"/var/log/kolla/haproxy/*.log"
 {
 }

releasenotes/notes/fix-haproxy-logrotate-e299a0000728fd8f.yaml

+---
+issues:
+  - |
+    Existing fluentd log rotation failed to delete old haproxy, swift,
+    glance-tls-proxy and neutron-tls-proxy logs. These will not be
+    deleted by the new logrotate config and will have to be removed
+    manually.
+fixes:
+  - |
+    Existing fluentd log rotation failed to delete old haproxy, swift,
+    glance-tls-proxy and neutron-tls-proxy logs. Standardise rotation
+    and deletion of logs using logrotate.