Change-Id: I407191b1d1e9b3656c6f86325a13bb8937400dbb

In the Victoria release, deployment images fail to build with the
following error:

/opt/kayobe/venvs/ipa-build-dib/lib/python3.6/site-packages/diskimage_builder/lib/common-functions: line 343: element-info: command not found

This is caused by the virtualenv bin directory not being included in
PATH while executing code from common-functions, which results in the
element-info script not being found.

This doesn't happen in Ussuri because older versions of DIB were
activating the virtualenv automatically [1].

This doesn't happen in master because its upper constraints allow a
newer DIB which doesn't use element-info anymore.

The fix is to activate the DIB virtualenv, which is done since
stackhpc.os-images v1.10.1 [2]. Bump in master first then backport to
stable/victoria.

[1] https://review.opendev.org/c/openstack/diskimage-builder/+/734414
[2] https://github.com/stackhpc/ansible-role-os-images/releases/tag/v1.10.1

Change-Id: I5efdbd52556721914fe69d7c6ba454b2c721b643
Story: 2008550
Task: 41673

This unit test was failing because /tmp is a symlink to /private/tmp on
macOS. _detect_install_prefix() returns a different path because it
calls os.path.realpath().

Change-Id: I2482c86efebd66a5d22a761df82763cecd764386

Kayobe allows specifying a --limit argument, which is passed through to
Ansible. In some cases we wish to add an intersection with a group. This
allows us to reuse playbooks for the seed, overcloud etc.

For example, the lvm.yml playbook specifies a host list of
seed-hypervisor:seed:overcloud. When executed as part of a kayobe
overcloud host configure command, Kayobe passes a limit of overcloud. If
the user specifies a --limit argument, this gets intersected with the
overcloud limit: host1:&overcloud.

The problem happens if the user specifies multiple parts to the host
pattern in their limit using a comma, e.g. host1,host2. This results in
host1,host2:&overcloud. Ansible ignores the colon, and treats this as
host1 or host2:&overcloud.

The solution is to use a comma to join the patterns if the user has used
a comma: host1,host2,&overcloud

Change-Id: Ibe42fa372c6fa0c539d2c2b0e238601286dc213d
Story: 2008255
Task: 41111

Ubuntu uses sh rather than bash by default, which does not support the
source keyword.

Change-Id: Ic36531c0f26fc7dee361bebb83a1d3089166c1eb
Story: 2004960
Task: 41490

In the Wallaby cycle, Bifrost changed the default value of
enable_inspector_discovery from true to false. To maintain backwards
compatibility, we override the setting to true.

Depends-On: https://review.opendev.org/762998/
Change-Id: Ie504fe9e7934e3e9f399d010cd8c5e242a152bb7

Fixes a link to storyboard in release note added in
Ibe44583cb93b7dca8f5091c893386a15288af915.

Change-Id: I7360953c6b5b579392d746971df7200e998ed3ef

As announced on the openstack-discuss ML[1], Karbor is retiring
this cycle (Wallaby).

Needed-By: https://review.opendev.org/c/openstack/karbor/+/767032

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018643.html

Change-Id: I5a3af41e4cc3988540ff95c880207279133a19d4

Affects master & Victoria only.

Since Victoria, Bifrost added a play to gather facts for localhost at
the beginning of deploy-dynamic.yaml. Kayobe executes the playbook with
a limit, which does not include localhost. This causes fact gathering to
be skipped for localhost:

    PLAY [Gather facts on localhost] ***********************************
      skipping: no hosts matched

This change fixes the issue by adding localhost to the limit.

Change-Id: I1264832398744c48a6f706efe91f084890a37772
Story: 2008388
Task: 41311

Change-Id: Ib869ae5146948abcb11eb20691ccc2311db24bb1
Story: 2008458
Task: 41485

A temporary file is removed by multiple test hosts, which all have
connection=local. This leads to a race between multiple executions of
the file module on localhost.

Add run_once.

Change-Id: I976122f72bdca7f91cbfcd81fca431b81a6b6aef

If a seed's bifrost_deploy container is deployed using a CentOS 8.2 base
image, prior to the CentOS 8.3 release, then a user runs 'kayobe seed
service deploy', the following task may fail:

    TASK [Ensure the overcloud host image has bogus name server entries removed]

This seems to be an issue with libgcrypt not being upgraded with
qemu-kvm, and becoming incompatible. The workaround is to ensure
libgcrypt is upgraded also.

Story: 2008430
Task: 41379

Change-Id: I82313fcd258e58969e0b68ae91a78943df537a7f

* Bump stackhpc.libvirt-host to v1.7.1. On seed-hypervisors installed
  using CentOS 8.2 or earlier, interaction with libvirt may fail due to
  libgcrypt being incompatible. See
  https://github.com/stackhpc/ansible-role-libvirt-host/issues/42

* Bump MichaelRigart.interfaces to v1.9.2. The CentOS 8.3 cloud image
  includes an ifcfg-ens3-1 file. See
  https://github.com/michaelrigart/ansible-role-interfaces/pull/93

* Previously a second libvirt daemon was installed by Tenks on the host,
  however changes in libvirt 6.0.0 to separate libvirtd into multiple
  daemons do not allow for customisation of the PID files used by the
  new daemons. This leads to a conflict between the container and host
  daemons. Update the Tenks config to use the containerised Nova libvirt
  daemon. This depends on a change to the stackhpc.libvirt-host role:
  https://github.com/stackhpc/ansible-role-libvirt-host/pull/44

* Not CentOS 8.3 related, but tox jobs are now failing on python
  dependencies. Remove upper limits from docker and paramiko.

* Not CentOS 8.3 related, but Bifrost has enabled authentication by
  default. We are not ready to support this, so override it.

Story: 2008429
Task: 41378

Change-Id: Ie8fd965165e8d347d27528a2c16d0647e412ccdc

Ubuntu hosts come often without python preinstalled, this task ensures
python gets installed with raw: module on hosts missing it.

Change-Id: I8c5561b2997b5bcb3957e7d52f2b298d8a72a80d

Since python2 is not supported long time - there's
no need to use /usr/libexec/platform-python.
Also for supporting Debian/Ubuntu - we need to
change that to /usr/bin/python3.

Change-Id: I0d477325e0edd13d1aba211c13dc2e8b7a9b4c98

Add permission escalation to the swift ring generation playbook

Task: 41256
Story: 2008354
Change-Id: I7fa88a203274c3030b3d8e5208f94b2230d43c68

Searchlight project is retiring in Wallaby cycle[1].
This commit removes the usage of Searchlight project
before its code is removed.

Needed-By: https://review.opendev.org/c/openstack/searchlight/+/764526

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018637.html

Change-Id: Iedcc7710ee85202bd4c68443bc0f429bd133c05b

Qinling project is retiring in Wallaby cycle[1].
This commit removes the usages of Qinling project
before its code is removed.

Needed-By: https://review.opendev.org/c/openstack/qinling/+/764521

[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018638.html

Change-Id: I59a61dda68e66eeaa0526e2b91de9316fd04dee8

UPPER_CONSTRAINTS_FILE is old name and deprecated
-https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file
This allows to use lower-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.

Change-Id: Ibd73999e54586b88d26adb688305af3c60595fbd

This reverts commit 074024d6.

Depends-On: https://review.opendev.org/763959

Change-Id: Ia5715c6914ac454081a95b6e1788e80f53c72e30