Change-Id: I4b9c4e5a2d6e943c85250b7b85ad52a8a620e80d

Use correct system scope - all - while getting the list of ironic
nodes in ipa-images role.

Closes-Bug: #2083014
Change-Id: I4da3a3739d57817ffbd094caea0fc80c3ad8eff8

When kolla_base_arch and ansible_facts.architecture differs
we need to run multiarch/qemu-user-static image - see [1].

[1]: https://github.com/multiarch/qemu-user-static



Co-Authored-By: Bartosz Bezak <bartosz@stackhpc.com>

Change-Id: If149418f509c687c3e5d1072cc39a80af33dec5a

Change-Id: Id597daad620d90d30187fa74f9d21d220cafacd5

There is a race condition in Ansible that can result in this failure:

  msg: |-
  MODULE FAILURE
  See stdout/stderr for the exact error
  rc: -13

Disabling SSH pipelining prevents the issue at the cost of Ansible
execution duration.

See:
 - https://github.com/ansible/ansible/issues/78344
 - https://github.com/ansible/ansible/issues/81777

Change-Id: I62221df4650ddd02afdbc0993e783bf66b706a1c

Some network devices may use SSH key exchange algorithms that are no
longer supported by the Ansible control host. This will cause
ssh-keyscan to fail, preventing Kayobe from configuring the devices.
This change makes it possible to work around the issue by setting
switch_skip_keyscan to true for the affected devices. The SSH known
hosts file on the Ansible control host will need to be populated
manually.

Change-Id: I4e3394cff1fd86eb5c1a4be55d6fd7fd080b2944

eos_config does not support provider, nor connection: local from at
least 2022 [1] - since ansible>=7 (ansible-core 2.14).

[1]: https://github.com/ansible-collections/arista.eos/commit/588d94b2ed22817b63f996187e7d757d3ebad725

Closes-Bug: #2058365
Change-Id: Ief37b7bee758e34dddb881a9e68728013861c0ec

During the ``kayobe overcloud inventory discover`` command, Kayobe
queries the Bifrost ironic node list and updates the Kayobe inventory.
If the nodes have a driver_info.ipmi_address field set, an ipmi_address
variable will be defined in the Kayobe inventory for the host.

This does not work for Redfish based hosts, which use
driver_info.redfish_address in the Ironic node. This change adds a new
``redfish_address`` variable and extends the command to discover the
address from the Bifrost node inventory.

Change-Id: Ieb1e61ddadb542732739d1f478b1e5a176e0ac88

Previously Kolla Ansible hard-coded Neutron physical networks starting
at physnet1 up to physnetN, matching the number of interfaces in
neutron_external_interface and bridges in neutron_bridge_name.

Sometimes we may want to customise the physical network names used.
This may be to allow for not all hosts having access to all physical
networks, or to use more descriptive names.

For example, in an environment with a separate physical network for
Ironic provisioning, controllers might have access to two physical
networks, while compute nodes have access to one.

This change extends the 'physical_network' network attribute to make it
possible to customise the Neutron physical network names used for the
OVS, OVN, Linux bridge and OVS DPDK plugins. The default behaviour is
unchanged.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922320
Change-Id: I214444c60653f484fcda6275cc725879d14f9e7a

This bumps the hacking library, which is used to enforce OpenStack code
guidelines, to the latest released version. No code changes are required
to pass checks with this version.

Change-Id: I05ab9cb5db5c30cf537476cb494f707338ea67e9

Added initial support for systemd-networkd link configuration, now
you can configure and rename the name of a network interface if you
know the MAC address of the interface.

Also added unit tests and fixed issues in the test_overcloud_host_configure.py:
 * Added unit test for networkd.
 * Fixed pep8 issues.
 * Removed unused import.
 * Fixed 'not in' issue in assert.

Change-Id: I8321183dbc747ef521aa0d2660ebeef8b0342c6a
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Change-Id: I7d71689ef9b5a8a092fe78da4ee3d2a645a1316e

Bump stackhpc.libvirt-vm to v1.16.1.

Change-Id: I88f20112ab4740fe114a6484f88f4fbfb66863e5

Follows the same pattern as apt config.yml

Change-Id: Ifb347372032120ec676747bad6201e0d82725976

Follow up to [1] where I wasn't sure if this package was necessary.

[1] https://review.opendev.org/c/openstack/kayobe/+/923556/11

TrivialFix

Change-Id: Id4b3d26b869ba3999a4c8a647eaccdf19539bfad

This change bumps up the versions of Ansible installed in the
kolla-ansible virtualenv to a maximum of 10.x (ansible-core 2.17.x) and
minimum to 9.x. This is to align with the Kolla version requirements
currently in master.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/921743
Change-Id: I4147a27ed04d28e832f11662e45dbae2851f63a8

There's no good reason to provide our own defaults for Ironic driver and
interface configuration. It easily gets out of sync with changes in
Ironic. Let's remove our defaults, and let Ironic provide them.

Note that this changes several of the defaults, which are listed in the
release note. Users are still able to override them using the existing
variables in ironic.yml.

Change-Id: Ie27adca0029e41439720eaac49b24cf13fc8068d

Since I8f5338b7eee31f1b8bc3e783d10666e3092a6540 we have not been running
pep8 jobs in CI.

This change fixes the issues introduced since then, returning to use the
openstack-python3-jobs template, which includes openstack-tox-pep8.

Change-Id: Ie15019f91b9e7b7f8cf97b628886f6b0beeb24fa

There are various ways in which it is possible to operate Kayobe
incorrectly. One example is executing Kayobe from a different Kayobe
configuration repository than the one referred to by the
KAYOBE_CONFIG_PATH environment variable.

While this shouldn't necessarily cause any errors, it may lead to
unexpected results if the operator assumes they are operating against
the configuration in the current directory.

This change adds a validation step that checks for this case and fails
the command early if found.

Change-Id: I709884bbd7edebf1d409f39c11f293560e987506

When using overcloud Ironic, IPA images for Ironic inspector are
downloaded to the Ansible control host to a cache directory, by default
/opt/kayobe/images/ipa/. They are later copied into the local Kolla
Ansible configuration under
etc/kolla/config/ironic/ironic-agent.{initramfs,kernel}.

The use of a shared cache directory results in problems when multiple
users share a single Ansible control host, since the cache is created as
writeable only for the user that created it. Other users sharing the
same Ansible control host will be unable to write to the cache.

We may also see issues if multiple Kayobe environments using different
IPA images are deployed from one Ansible control host.

The cache is not strictly necessary, since we can download the images
directly to the kayobe-config repo. This change avoids the use of the
cache. The performance impact should be minimal, only requiring an
additional download when a fresh kayobe-config is used.

Change-Id: I022c53afc0f64ccc79eeff4a220ade4c9216edfc
Closes-Bug: #2069845

Currently Kayobe sets ipv4_interface_mac to pxe interface
MAC address.

In cases where provisioning network interface and admin
network interface are different - this feature can be used
to get MAC address from Ironic introspection data.

Change-Id: Ie3c9248f0b3e47e3645e1886c0492265d52969c9