Allow remove all kolla images
Allow remove specific kolla version images
Allow remove dangling images
Allow remove single images, all images matched

Usage examples:
   * cleanup-images --all
     - Remove all kolla images
   * cleanup-images --image-version 4.0.0
     - Remove all images matching 4.0.0 kolla_version
   * cleanup-images --dangling
     - Remove all dangling images
   * cleanup-images --image nova
     - Remove all nova images
   * cleanup-images --image nova-scheduler
     - Only remove nova-scheduler image

Implements: blueprint add-cleanup-images-cli-options
Change-Id: I997272098879350e13e0ac00762ae3485e618355

The OpenStack Integration Test Suite (Tempest) doesn't use oslo.policy
library.
oslo.policy is not used in codebase and not set in requirements.txt:
https://github.com/openstack/tempest/blob/master/requirements.txt#L14

All policy.json related stuff must be removed.

Change-Id: I0d8ee710979a7eebba1e8fc176450e4c0bcbe757

The path of firewall plugin in kolla-ansible is wrong.

Change-Id: I979af769d8bc31e3b6373a629e9e090b987d0058
Closes-Bug: #1684459

When using cinder lvm backend storage driver, lvcreate will load dm_*
linux modules when need. So /lib/modules is needed by cinder_volume
container.

Change-Id: I80985794d6aaa6b4ddc71680a97e0d07085dafa7
Closes-Bug: #1684378

Currently Cinder configuration hard-codes tgtadm as the only
iSCSI management utility. tgtd and tgtadm are older tools to
manage iSCSI volumes. Newer versions of Linux distros use
targetcli and kernel based iSCSI facilities (LIO) and can be
a preferred way for some users.

Change-Id: I10c0a7d596994a9201218e58ca2ad184774a8ce2
Closes-Bug: #1684139

When using panko event dispatcher and publisher in ceilometer, it
depends on panko.conf file.

Change-Id: Ie91c072b233597758955b70bd526b2603b86e995
Closes-Bug: #1672241

In task "Running Neutron vpnaas bootstrap container",
parameter "volumes" of kolla_docker should be
"{{ neutron_vpnaas_agent.volumes }}"
NOT
"{{ neutron_vpnaas_agent.image }}"

Change-Id: Id7c95d4d6f53dfab384e387951eecf4d87459de
Closes-Bug: #1683669

Change-Id: I3b3ad184dea6b93f21c8778386c04a93b38bc2af
Closes-Bug: #1683802

Currently if Ceph is used for Cinder volumes the only choice of
backup driver is Ceph. It should be possible to use any backup
driver for any volume type, e.g. iSCSI volumes can go to Ceph
based backup storage.

Change-Id: Ifc8a767b9030391580de6a24383bb6b87053835d
Closes-Bug: #1683715

"/run/:/run/:shared" is previously declare as "mounted" in container,
hence "/run/netns/:/run/netns/:shared" directory volume mount is not
required and must be removed.

Related-Bug: #1683584
Change-Id: Ia7032843c493e8a883edd2f4ec12e0fdefc823a3

This change updates the ironic_inspector container deployment tasks
to use the new kolla ironic-inspector image (see kolla change
Ibdc5ba35db61f4974d4282aff34bcb5ccd952d45). The new image uses the
ironic-inspector user rather than the ironic user to execute the
ironic inspector service as this more closely aligns with what is
typically done by downstream packagers (specifically, Ubuntu and
RDO).

This change sets the owner and group to ironic-inspector when
copying configuration files into place, and uses the log directory
/var/log/kolla/ironic-inspector.

Change-Id: I8579d5c2d741636406ff60bececc74b50743b83e
Depends-On: Ibdc5ba35db61f4974d4282aff34bcb5ccd952d45
Closes-Bug: #1624457

Ceph is not able to determine the size of a cache pool automatically,
so the configuration on the absolute size is required here
otherwise the flush/evict will not work.
see
http://docs.ceph.com/docs/master/rados/operations/cache-tiering/

Change-Id: I4d4abb50787093a292e1ee6eb790c10ecf5ccb94
Closes-Bug: #1654375

Some roles made a bad usage of the 'node_config_directory' variable.

As described here:
https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L16

'node_config_directory' is the directory to store the config files on
the destination node.

This variable MUST be changed to 'node_custom_config'.
Futhermore this will unified all roles.

Closes-Bug: #1682445
Change-Id: Id8d8a1268c79befac8938c1e0396267314b40301

Freezer service configuration can't be override has describe here:
https://github.com/openstack/kolla-ansible/blob/master/doc/advanced-configuration.rst#L161

Kolla-ansible should look for files in /etc/kolla/config/ but it doesn't
take config files into account. This patch fix it.

Change-Id: Ia7d8d0892d13ba9785951a7b1291abb868fc714b
Closes-Bug: #1682404

The 'ansible_python_interpreter' has already defined in /etc/bifrost/bifrost.yml
we should remove the redundant variable

Change-Id: Ie799170d3318a731d31e1f39bcf940a1b220bd53

Change-Id: I6c725efd9d08a079ced2abca5be188b6ceac55c2
Closes-bug: #1682000

Creates Openvswitch role and splits
openvswitch from Neutron role to enable
third party networking solutions that use
Openvswitch or customize Openvswitch.
For example Openvswitch with dpdk or
OpenDaylight.

Change-Id: I5a41c42c5ec0a5e6999b2570ddac0f5efc3102ee
Co-Authored-By: Mauricio Lima <mauriciolimab@gmail.com>
Partially-Implements: blueprint opendaylight-support

Nova service-list is returning empty registered service
when in database they are. Because of this, simple_cell_setup
is not executed and deploy stucks waiting for nova-compute.

This change temporaly checks the database for existing nova services
instead of openstack compute service list.

This change will need to be reverted once the command is fixed.

Change-Id: Ic508eb3ff03b5f233186353fc7697305cc792d14

Panko fails to create users in mongo when deploy
is executed more than once.

Change-Id: I89d164220e874f7cffe0f2c70797c61a147bcafb
Closes-Bug: #1681747

Now, I see mariadb are using utf8_general_ci as a default collation.
- https://mariadb.com/kb/en/mariadb/supported-character-sets-and-collations/

This mean all of Devstack database will be created with utf8_general_ci collation,
so may be, one service/project can be deployed successfully via Devstack
but will be fail with Kolla deployment.

Therefore, we should use above default collation for Kolla-ansible.

Change-Id: Icbb6c15f536fc6986816c58f4fd68bfb95813e46
Closes-Bug: 1680783

Cloudkitty processor use tooz to handle multi processor processes.
Otherwise, duplicated billing will be inserted into mysql.

Change-Id: Ifdc1be78afa89499ee4c3bbec5b9db8ddb2929cf
Closes-Bug: #1681160

Metadata Proxy UNIX domain socket is only used by neutron-l3-agent,
neutron-dhcp-agent and neutron-metadata-agent. Hence it must be removed
from neutron-bgp-agent, neutron-vpn-agent and neutron-lbaas-agent.

See comment here:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/neutron/templates/neutron.conf.j2#L22

Change-Id: Ie493194a5dcd5979eb29382ecbd0c8db1b9e286d

The current module 'kolla_sanity' was written as a shim before full
shade support was added to Ansible. This should now no longer be needed,
we can implement the checks using Ansible provided modules.

Begin by updating the Keystone check to use 'os_auth' to fetch a token,
I think this is a good basic smoke test to verify Keystone is working.

Change-Id: I16049d9201fd8138c781ef2e1e0c1827ea817259
Partially-implements: blueprint sanity-check-container

Issue seems not fixed, it requires more work

This reverts commit 4f6470bb.

Change-Id: I308ea4e0d5ace60cf730944e1883966fc6f8f8ce

The InfluxDB plugin will collect metrics on the given InfluxDB servers.

Change-Id: I23f0433f56047369ce19bbf3236f6dd7038eb06e

Change-Id: Ib684e3f4bcd26e40c5bfde9bec8a1d83563d5460
Signed-off-by: Pavel Glushchak <pglushchak@virtuozzo.com>

New version of influxdb use "autogen" as default retention policy name.
Please see https://github.com/influxdata/influxdb/issues/3733 for more
info.

Change-Id: I8aeb47f60b3aeb022e0cd7aaac630d7cad5b0099
Closes-Bug: #1673914

Actual InfluxDB config is deprecated, it must be updated based on the
following documentation:
https://docs.influxdata.com/influxdb/v1.2/administration/config

* remove following options:
  lease-duration = "1m0s"
  pprof-enabled = false
https://github.com/influxdata/influxdb/commit/22173acb707af833b832126f8631e0afda445ea9

* rename "cluster" section to "coordination":
https://github.com/influxdata/influxdb/commit/75e89e35d80dfad65146c8d8a1df2d7b9930c99a

* remove shard-writer-timeout option:
  shard-writer-timeout = "5s"
https://github.com/influxdata/influxdb/commit/db7d58c867513d019c1b9f1718772062b5c491bc

Closes-Bug: #1678982
Change-Id: Id905336123bc5aa76d6e6903a82f915c3702669f

In case of karbor-protection providers.d/openstack-infra.conf config file modification,
karbor-operationengine and karbor-api are restarted too, but they should
not.

karbor-operationengine startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/karbor/templates/karbor-operationengine.json.j2#L2

karbor-api startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/karbor/templates/karbor-api.json.j2#L2

Change-Id: I91a0273ccf46e340315cf885ea01db6e14653182
Closes-Bug: #1677542

Refer to
https://docs.openstack.org/ocata/install-guide-rdo/glance-verify.html

Change-Id: Ic2a32a3f17a11f1f6e8ecf0f7271d7d1f12ca5bc

Fluentd actually parse all files in /var/log/kolla/*/*.log as Openstack
services files.
Dnsmasq file /var/log/kolla/neutron/dnsmasq.log, must be add to
exclude_path to avoid this warning message:
"/var/log/kolla/neutron/dnsmasq.log unreadable. It is excluded and would
be examined next time."

Change-Id: I8dc5320b9ed299200c4f1e6ee52d34a918e2f110
Closes-Bug: #1678530

If the Open vSwitch agent is being used, set extensions to qos
in the [agent] section of ml2_conf.ini.
see
https://docs.openstack.org/ocata/networking-guide/config-qos.html

Change-Id: I85272b03222775b14a311a110077a8eed736f56c
Closes-Bug: #1676319

In case of trove-api service config file modification (trove.conf file),
trove-conductor and trove-taskmanager are restarted too, but they should
not.

trove-conductor startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/trove/templates/trove-conductor.json.j2#L2
=> trove.conf is not used

trove-taskmanager startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/trove/templates/trove-taskmanager.json.j2#L2
=> trove.conf is not used

Change-Id: Ic4703a571cec5bf8b3f91cfcb9da1a23e2bb300b
Closes-Bug: #1677531

Change-Id: I79d99acfb9410d83ab1c84df3553db463f3f948f
Closes-Bug: #1677952

- fix the zun deploy failed
- remove the unnecessary register

Change-Id: I06bbad44de3f391a1c8939e8a587feababebc986
Closes-Bug: #1677665

Co-Authored-By: caoyuan <cao.yuan@99cloud.net>
Change-Id: Iddde03760ff85af5263868ebc47b8b9438e92e8e
Partially-implements: blueprint better-reconfigure

Change-Id: I13cf03d6a97fb94dd7cb309e99a417ad101dc21a
Co-Authored-By: Mauricio Lima <mauriciolimab@gmail.com>
Partially-implements: bp add-zun-ansible-role

Option "secure_proxy_ssl_header" from group "DEFAULT" is deprecated
in Keystone.

see
https://docs.openstack.org/ocata/config-reference/identity/samples/keystone.conf.html

Change-Id: I390969fce5b592c0267399969abc54e5caffbfc8
Closes-Bug: #1675982

If disable cinder in openstack environment.
Cinder of configuration items do not need to configure in nova.conf

Change-Id: Ie346dfe45f8c2d3fd383095d0c64f8e9421100ff

min_l3_agents_per_router parameter has been removed in neutron[0].
So we can remove it.

[0] https://github.com/openstack/neutron/blob/master/releasenotes/notes/remove-min-l3-agents-per-router-27aef7d91dec0348.yaml

Change-Id: Ia3f3686e2cc27e4bd0707add50ebc552117d6b03
Closes-Bug: #1677101