The version that we were capping to is no longer compatible with latest
upper-constraints.txt, so let us free float again.

The resulting linting errors are included for now to unblock the gate,
these will still need to be discussed or fixed later.

NOTE(kevko): Temporarily disabling horizon deployment, as it's not
possible to unblock gates without it

Co-Authored-By: Michal Arbet <michal.arbet@ultimum.io>
Change-Id: Ib7f72b2663199ef80844a412bc436c6ef09322cc

Taken from [1].

[1]: https://ansible.readthedocs.io/projects/lint/configuring/#ansible-lint-configuration

Change-Id: I29c1abb4d518a4da6788e06804f28c5f6853c581

Add noqa for:
Object of type PosixPath is not JSON serializable

Change-Id: Id6ef88bb8cd16120bf31da679d1129d99f4b9fd8

removed:
- 701 [galaxy_info missing] is no longer emited
- 602 [empty string compare] is now opt-in
- 208 [permissions not mentioned] is no longer emited
- 106 [role name] is no longer emited

renamed from number to role name:
- 503 [no-handler]
- 301 [no-changed-when]

Change-Id: I8b059d87c94499decbd9b115ef2cde033aa88fbd

With the release of ansible-lint 6.7.0, the openstack-tox-linters job
started failing with these errors:

    WARNING  Listing 30 violation(s) that are fatal
    ansible/roles/ceilometer/tasks/config.yml:66: name: Jinja templates should only be at the end of 'name' (name[template])
    [...]

Add this new check to skip_list for now.

Change-Id: Ia82a88ee3b9bb6a3cb09f09c6568d1914ee2592d

Add fqcn-builtins to the skip list for now, we will watch how the
discussion about this evolves and defer updating all code according to
that [0].

[0] https://github.com/ansible/ansible-lint/issues/2050



Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I6dcdec4f029b87bad41530ad45d285909c8351f7

Change-Id: I27b0e42fba93a35c6d878d108bf1e7fdebc9e3db

Change-Id: Ie3ca5526e2af30db06631e7c215fe2db13c92f2f

The 5.0.3 release of ansible-lint makes the linters job fail, due to the
addition of an unnamed-task rule. We have quite a large number of
unnamed tasks, typically include_tasks or include_role. We may want to
address this at some point, but not right now.

Change-Id: I4ee706fe2463d62e4e16412117d4373748ea43e3

Change-Id: Ic58a27e517004768433a1e793d4d8e90e2c3383a

Change-Id: I3a31c74608b48919c1563bac88313a8c4219dedc
Co-Authored-By: Radosław Piliszek <radoslaw.piliszek@gmail.com>

* Reworked tox pep8 into linters job, that runs:
  - pep8
  - bandit
  - bashate
  - doc8
  - yamllint
  - ansible-lint (validate-all-files.py + ansible-lint)

* Skip E701 - missing galaxy_info in meta and E602 see [1].
* Skip E301 and E503 - followup later in a separate change
* Added ansible-role-jobs to zuul.d/project.yaml which will run
  openstack-tox-linters job in check queue
* Fixed remaining style issue
* Made tox and docs reference the new env for linters
* Dropped pype environment (not supported)

[1]: https://github.com/ansible/ansible-lint/issues/457

Change-Id: I494b4b151804aac8173120e6c6e42bc2fdb00234