Following deployment of Grafana, a check is made to ensure that the
login page is accessible. If the Grafana container has been deployed
to a remote host, but is not directly accessible over the deployment
network then the check will fail because the task is set to run with
connection: local. For example, if Ansible is using a different
network to the network on which grafana is exposed to connect to the
remote host then the task may fail. A similar problem exists for the
remaining two tasks in the post_config file.

Further to this, if Grafana is not accessible, the ansible uri
module does not return a status field, so no retry attempts are made
and the task fails with an obscure message:

TASK [grafana : Wait for grafana application ready] *****************
fatal: [some_remote_node]: FAILED! => {"failed": true, "msg": "The
conditional check 'result.status == 200' failed. The error was: error
while evaluating conditional (result.status == 200): 'dict object' has
no attribute 'status'"}

$ ansible --version
ansible 2.3.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.5 (default, Aug 4 2017, 00:39:18) [GCC 4.8.5 20150623
(Red Hat 4.8.5-16)]

Change-Id: I77e2129b4a1c5f2f0802fb92eb03395ff72cf5f3
Closes-Bug: #1742501

Change-Id: I419cd02aeb899d93bba5f330d7e4535afd8c0ed8
Closes-bug: #1708655

Provide support fot kolla dev mode in Keystone. When
'kolla_dev_mode' or 'keystone_dev_mode' variables are
enabled, source code of Keystone project is cloned
and bindmounted.

Partially implements: blueprint mount-sources

Change-Id: Ie4cf401ecd9a507e739a53dfdf16f65292ab57e5

Enable docker-ce on AArch64 platform in Debian.
Set the docker daemon name according to the existing of "dockerd" binary.

Closes-Bug: #1734255

Co-authored-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Change-Id: Ie0b3bac72b408dccf3fb99912b4fe2d4788705e5
Signed-off-by: Tone.Zhang <tone.zhang@arm.com>

Before cleanup containers and hosts, it should be ensure the
docker serivce running but the destroy action missing it,
this patch to fix it

Change-Id: I85ca806c1fd395daf937b585d466e16fbad4e20c
Closes-Bug: #1741852

Depends-On: I5846b48d336583ae82743f61bfbdadc99c755e8d
Change-Id: Iaf15dad5e4d527b8721409e56fc081043c1cb174
Implements: blueprint vitrage-roles

Current debian stretch use mariadb 10.1.26 which integrates
a backup tool call 'MariaDB Backup' [1]. It is based on
Percona XtraBackup and support full backup capability for
MariaDB Server that includes encrypted and compressed data.

This patch also fixs muti-node deployment failed on Debian
aarch64. Percona's repo has no XtraBackup package for Debian
aarch64. In such case we can use MariaDB builtin backup tool
'MariaDB Backup'.

[1] https://mariadb.com/kb/en/library/mariadb-backup-overview/

Change-Id: I7271d3f93b41d4839670a2c4a358744333411cd7

This will copy both of yaml or json policy file
if it exists

Change-Id: Ie5e03e0307d239f1079d2522e353367f7f954e77
Implements: blueprint support-custom-policy-yaml
Co-authored-By: Duong Ha-Quang <duonghq@vn.fujitsu.com>

Fixes a bug where the Baremetal Introspection service's public endpoint
registered in the Identity service referenced the internal API endpoint.

Also updates keystone endpoints for the Baremetal and Baremetal
Introspection services during reconfigure and upgrade operations.
Previously this was only done during deploy.

Change-Id: I32d475f288bb4a3834c13cc86f0c53b5437c3d25
Closes-Bug: #1738418

Instance failed to spawn: libvirtError: unsupported configuration: CPU
mode 'host-model' for aarch64 kvm domain on aarch64 host is not
supported by hypervisor.

Change-Id: Iad530457aef24ee8f561a8f7d2c6c6150c55bc42

Change-Id: Ie6e1d30d2fcbdd7c138c05585f24931e8495fc28

show_multiple_locations is missing for external ceph, and it will
cause tempest run failed.
it means the conditon for show_multiple_locations is
glance_backend_ceph but not enable_ceph, this patch it fix it.

Change-Id: I3c95c3b0a7e34639b376bdfd0205f3930b06e2cd
Closes-Bug: #1741022
Co-Authored-By: chenqiaomin <chen.qiaomin@99cloud.net>

Prevent cinder conf from copy nfs_shares to all nodes instead of
just cinder-volume.

Change-Id: I4f94b6c0ca8b628c1babee7fff0b66fb5a8df257
Closes-Bug: #1713010

Using Docker volumes for persistent data in the bifrost container is
necessary for upgrading the bifrost services.

This change adds the following volumes:

* bifrost_httpboot
* bifrost_ironic
* bifrost_mariadb
* bifrost_rabbitmq
* bifrost_tftpboot

Ironic creates hardlinks between the TFTP master image store and the
HTTP root path when iPXE is enabled. With different Docker volumes
used for these locations we run into
https://bugs.launchpad.net/ironic/+bug/1507894 during deployment. If
we use a directory under /httpboot to store the master images this
issue is avoided.

Change-Id: I8653268d3598e7a59d2eb45c8750d45b6fc9e35f
Partially-implements: blueprint bifrost-upgrade

Using a kolla_logs volume ensures that logs are persistent beyond the
lifespan of the bifrost_deploy container. This is necessary to support
upgrading the bifrost services. It also opens the possibility of log
forwarding, although we do not currently deploy a fluentd container on
the bifrost host.

Change-Id: If3118cd75ccc87b0d003d5f382695aeaa43ed0f8
Partially-implements: blueprint bifrost-upgrade

Kolla-ansible typically configures services to access the internal API
endpoint of other services, rather than the default public endpoint.

This change ensures that this is the case for ironic inspector.

Change-Id: I998f12435fc1bd306444f9a68bd7f99f5b78f6f8
Closes-Bug: #1740591

Previously ironic inspector logs were not being collected, as they are
stored in /var/log/kolla/ironic-inspector/ rather than
/var/log/kolla/ironic/. This change modifies the fluentd input
configuration to use the correct directory.

Also adds the ironic-inspector service to the fluentd programname
rewrite rule.

Change-Id: Ie5d67f395e4c32fef992e674f2d53dbd6a17f238

Kolla assumes mariadb 10.0 where galera stuff was always enabled. And
this works for CentOS and Ubuntu as they use 10.0 on x86-64.

Debian uses mariadb 10.1 by default (and CentOS on !x86-64 and
Ubuntu/aarch64) where galera stuff is disabled by default.

Closes-Bug: 1740060
Co-Authored-By: Xinliang Liu <xinliang.liu@linaro.org>
Change-Id: I8374ac2219ad7880970cd789727d01af7cac1077

To fix it we change the default param to True.
'show_image_direct_url' will be overridden.
Currently glance v2 doesn't allow to specify custom
locations for image by default, it returns 403.


Closes-Bug: #1740223

Related to https://review.openstack.org/#/c/279630/2

Change-Id: Ib4dd54c69830ab8f3f9812877b026f81c23c224a

Now we have upgraded to ceph Luminous, need start ceph mgr during
upgrade from Pike( which is ceph Jewel ).

Implements: blueprint ceph-luminous
Change-Id: I16ac0fc5d963b5725f9a19ecd396290fea7c0399

ceph mgr should use the each node name rather than the first node
inventory_hostname

Change-Id: Ib4530ee95b4201a941b836a3fbcbe27d2d03b06f

Change-Id: I235e16e98dab38f20213cc48672c6e862a04d95f

The option neutron_endpoint_type is duplicate on these files:
 - trove/templates/trove.conf.j2
 - trove/templates/trove-taskmanager.conf.j2

We just have to remove one occurrence.

Change-Id: If5c91cf7b491966b1deac42c694af5995df9b11e

Provide support for kolla dev mode in Kuryr. When
'kolla_dev_mode' or 'kuryr_dev_mode' variables are
enabled, source code of Kuryr project is cloned
and bindmounted.

Partially implements: blueprint mount-sources

Change-Id: I74c1ea70b4220a0e91f19403971303ca55652371

kuryr changed driver option to default_driver

Ref: https://review.openstack.org/#/c/508778/

this change updates the template to apply the change.

Change-Id: I38669564a769bbe7b55386db5208a3341b15da9e

If ironic is in use it is valid to have no (virtualised) compute nodes.

Change-Id: I100540fbfd81be5642c1d4ed135fcd500924a47e
Closes-Bug: #1701317

Closes-Bug: #1738801

Change-Id: I345be79b9aa4d106e7721f44ccdb7f8342c94d3a

interface_driver parameter is missing when using vmware DVS on the
dhcp_agent configuration. As a result we get the following error:
Error loading interface driver 'None'

Change-Id: I302a1392615792bd65cab9c0933cb7f7e5e1880d
Closes-Bug: #1736410

On AArch64 we run VMs without any graphics so nova console is not
available. For now we had to disable it by hand but it can be automated.

Change-Id: Ib903044493ca98c0dd29d3096f66272e130668b0

Co-Authored-By: caoyuan <cao.yuan@99cloud.net>
Co-Authored-By: Eduardo Gonzalez <dabarren@gmail.com>

Depends-on I7ffb991adbd05275e331401cd73fc84362084ebd
Change-Id: I85afeb5dfce0bf6350a444000bdb885c6fe079c9
Partially-implements: blueprint vitrage-roles

Although there is an option "enable_fluentd", but there are still
some tasks that make fluentd not configurable.

Change-Id: Ic0a9deb36fce154022925d26411e01a8ffe18b50
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>

In a HAProxy precheck task, the command module is used, and the results
inspected by checking the stdout attribute of the result. However, if
the command fails (non-zero exit code), in some cases there may not be a
stdout attribute in the result object. This causes an AttributeError and
prevents ansible's useful diagnostic output from being displayed.

Change-Id: Id502b5d0b71fe2150a29df43154c925dca96ef06
Trivial Fix

When a RabbitMQ node in multiple RabbitMQ nodes is started during
multinode deployment, it is required to communicate with each other
to be clustered. However, RabbitMQ nodes cannot communicate between
them due to missing host name in the nodename environment variable
of RabbitMQ. Subsequently, all of RabbitMQs cannot be started and
it will give rise to a deployment failure.

Change-Id: I7b4ba76807750db4a14d859454ba650bdaaf23ca
Signed-off-by: Taeha Kim <kthguru@gmail.com>

This is required for some tempest tests and in turn to achieve 100%
refstack certification for clouds deployed by Kolla. tempurl is default in
Swift[0] but we're missing as we override the pipeline.

[0] https://github.com/openstack/swift/blob/\
    b86bf15a644db4438770801a312fe074a09c91ef/\
    etc/proxy-server.conf-sample#L97

Change-Id: I0e36fcd7a785f878005d51159eb51725c284229c

This fix libvirtError Unable to open logfile issue.
Related-Bug: #1668654
Change-Id: I36720af0c7d3dd7c69d2404843f54c0991aea1bb

In some deployment scenarios the current timeouts
for mariadb bootstrap and kibana registration with
elasticsearch have been found to be too short. These
timeout increases shouldn't introduce any deployment
slowdown in current environment and eliminate
deployment failures in environments with slower
systems.

Change-Id: If33dfff2b42b23eff7ec2230c9b0c5a4c010072e

some tasks miss permissions to be run as a normal user

Change-Id: Ic53308adb7fa3a10a7b1f1caa27ca7dd67037cdd

Change-Id: Ia776017b8e33ef7acf65e603bd87720a620eabf0

In the previous patch to address broken replication in Swift the account
and container replicators were missed.

Change-Id: I34a58b137dbba99c66e7680546fe85e2ef6131e9
Co-Authored-By: Thorsten Frueauf <thorsten.frueauf@oracle.com>
Partial-Bug: #1733851

Closes-Bug: #1734019
Change-Id: I203db11955189971640fcf8470e7a326d591b296