Perform the interface specific checks first, then do the network
related checks (not the other way around)

TrivialFix

Change-Id: Iae2c9fb9491060f1e33f067c08d22479108c3c98

TrivialFix

Change-Id: Idf2a53025afb53a12cbe3c4e2feed1dd3dddfe02

TrivialFix

Change-Id: Ib9b199c2edcc48972491b46b41ae502953cd8a81

TrivialFix

Change-Id: I47fa57087258bad33ad21033f76f4fb2bf5f6f31

This change adds copying iscsid logrotate
conf file for config task in common role.

Closes-bug: #1633127
Change-Id: I7da1f9ff794ed62f1baf70c04a2f6d0ca8d426aa

Change-Id: I1d374efb49b6d50b95641278376b21a61e054924

This patch [1] adds support to config multiple physical networks for
ovs neutron plugin, but it missed to change ml2_conf.ini.j2
correspondingly.

[1]: https://review.openstack.org/#/c/373455/

Change-Id: I1937e1e5986657470add07d4bcf8587642aa45ec
Closes-bug: #1631903

Add /etc/localtime:/etc/localtime:ro to volume for aodh, barbican, etcd,
gnocchi, kuryr and sahara.
All the containers are added in Netwon cycle, so no need to backport

Closes-Bug: #1633049
Change-Id: I9cdba54cf730af44fb1a9ff6f2c936d23dadbe9a

* enable iscsid when ironic is enabled
* update sample inventory files with above
* add logrotate conf template for iscsid
* add 'common' role dependency for iscsi role

Change-Id: I3054b9139a43542febf26c3ce9a71b65f2fcdd84
Closes-bug: #1632850

cinder_volume_group property is not seen by precheck tasks -
moving it to common group variables.

Change-Id: Id7614bb428bb0bf7217eab71b3ec28189e4032b5
Closes-Bug: #1631569

Currently, when there are some qemu processes which may be some useful
virtual machines running by the operator running on non compute node, the
cleanup script will fail the cleanup operation for that node. We need to
ignore the qemu process check for non compute nodes.

Change-Id: If49a1a30764063935b2a65312de8f3b2357c7fbc
Closes-bug: 1633005

Change-Id: Ie42f75d0779b8e2bd835e9cdc165e73751ce5172
Closes-bug: #1632840

During the upgrade from Mitaka to Newton, the uid/gid may change for the
same image. Especially on Ubuntu, we moved to Ubuntu Xenial in Newton
and it added systemd related user which break all the uid/gid during an
upgrade. It will the permissions in all docker named volumes.

This fix extends set_config.py to set the proper permission during
container start. This is super light then add commands in
extend_start.sh file  or add ansible tasks.

This patch just fixes rabbitmq case. Other services will be fixed in
following patches.

Partial-Bug: #1631503
Change-Id: Ib17027b97abbc9bf4e3cd503601b8010325b5c5b

* install openssh client in keystone-fernet container
* install rsync in keystone-ssh container
* fix syntax issue in ssh configuration
* copy ssh configuration into keystone-fernet container
* copy id_rsa.pub into keystone-ssh container
* copy id_rsa into keystone-fernet container
* use full path to ssh binary in used scripts
* add missing newlines at EOF
* when using type source set /var/lib/keystone as home
  directory for the user keystone

Co-Authored-By: Jeffrey Zhang <jeffrey.zhang@99cloud.net>
Change-Id: Id6b41030056a69f6516a054beb2fc0e08226e876
Closes-bug: #1623013