Bifrost in Yoga will change the default TFTP and HTTP boot directories
to reside under /var/lib/ironic/. We already avoid the cross-filesystem
linking issue that the patch aims to address, by overriding
tftp_master_path. Avoid this breaking us by reverting to the previous
defaults.

Needed-By: https://review.opendev.org/c/openstack/bifrost/+/822743

Change-Id: Idc54c78c618ae90b4d933c2c401bb1789b0abd36

Details in the attached reno.

Change-Id: I438a453ca522493524fdb9760c1edb330916084b

Change-Id: I5d6af3707c3de4466699f1a0e6ff2f2e2fe4e123

Change-Id: I2d4a4fab35771723be82a1c8b98dbe4cc3164f58

By default those are saved in /var/log/ironic/deploy.
Change of path was introduced by [1] since Victoria.

[1]: https://review.opendev.org/c/openstack/bifrost/+/742854

Change-Id: I0fb69a06d6565d633f9ea0e37e0a780a70bb0ced

The initial migrations when starting grafana for the first time may
sometimes take much longer than 20s, we have seen samples up to near
60s. Allow 120s to have some margin. Also make the timeout parameters
configurable.

Closes-Bug: 1769962
Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: If9186d8aa65150c492657550064789e211dbb570

Based on some variables like tunnel_interface_address that are not present in nodes without ovn-controller like controller nodes this task will be failed because of undefined variable

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Change-Id: Ic511bf6479438f9288a008afb2aae43083a4e69f
Closes-Bug: #1953367

This patch is fixing file path for WSGIScriptAlias
as debian/ubuntu binary packages installs /usr/bin/aodh-api
as it is in source images also. For details please check
LP bug report.

Closes-Bug: #1953059
Change-Id: I9efe73193bf828b084c2844be73c9813a969c9c7

With the previous setting of optIn=False, users still get nagged on the
starting page to enable telemetry, let's disable completely instead.

Change-Id: I258006c09edf7e36570f6575db07cce474c2ef8b

The documentation for novncproxy_base_url says:

    If using noVNC >= 1.0.0, you should use ``vnc_lite.html`` instead of
    ``vnc_auto.html``.

While novnc packages in CentOS, Debian, and Ubuntu still provide
vnc_auto.html for compatibility, this could be dropped in the future.

Change-Id: I04883c877015c1835c8b6b2c8be1fb7156ceb340

Change Ib225d76076782d695c9387e1c2693bae9a4521d7 introduced a new
upgrade task for monasca-thresh. Because the task is not restricted to
the correct group, it fails while trying to stop monasca_thresh on hosts
not running this container.

Change-Id: I33c2c458a98145315b0de0c069f13b83f59622eb
Closes-Bug: #1952408

Remove the role directory and one file left atfer
If3cf073e88c83f670c867a49afe48845f9e81008

Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Change-Id: I6c3b46b858ef4f1954a99bccd10b80973a57ba77

Nova provides a mechanism to set static vendordata via a file [1].
This patch provides support in Kolla Ansible for using this
feature.

Arguably this could be part of a generic mechansim for copying
arbitrary config, but:

- It's not clear if there is anything else that would take
  advantage of this
- One size might not fit all

[1] https://docs.openstack.org/nova/latest/configuration/config.html#api.vendordata_jsonfile_path

Change-Id: Id420376d96d0c40415c369ae8dd36e845a781820

Change-Id: Ifee8af246312cad5b68ff1bf2793963bf7028dc8

The check condition is similar to the previous if and it can be merged

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Change-Id: I62213d91945de42ffc87ecad1e96fa4fc0760f10

This service was disabled in the Wallaby release and all
references to it can now be removed.

Change-Id: I482640dd63959143732d86fcffb320cc94611247

[1] https://docs.openstack.org/releasenotes/ironic/xena.html

Change-Id: Ic0dd9fa7ef76b647682e124b1bae52e931a38225

When only the directory is specified, separate log files
are created for the Nova API / metadata services with a
-wsgi postfix. This affects the 'programname' field in
Fluentd which affects the processing of these logs. This
is a regression.

When the log file name is specified, the directory is
not required.

Closes-Bug: #1950185
Change-Id: I8fec8b787349f83c05d8af7f52fc58da7c3e9cc4

This patch adding way to change schedule
for logrotate.

Depends-On: https://review.opendev.org/c/openstack/kolla/+/813008
Change-Id: I033c51704bfb806f6515db26b8159fae12469ba5

This defines which release we upgrade from in CI.

Also remove some Wallaby upgrade compatibility code in CI playbooks

Change-Id: I18912178392973337ca4115dec3816f1b3944ad5

the gateway_ip should be in subnet dict.

Closes-Bug: #1949260
Change-Id: Iaa3fc69ee7954b5b202b0a6052c30bfb1780e84b

In case of running mariadb role with --limit the group_by module will only include the limited hosts and other hosts that are not limited by ansible will not be included.
Using add_host will add all hosts in mariadb group to their shards group

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Change-Id: I1331698e313bd714a16fc35f38fb579d75b56370
Closes-Bug: #1947589

Add an empty line between memcache_servers and www_authenticate_uri

Closes-Bug: #1941704
Change-Id: Ied83865eb33aceaf738c21363f02bcccbcd05738

This reverts commit 15259002.

Reason for revert: The iptables_firewall produces warnings without it.

Change-Id: Id046a3048436c4c18dd1fd9700ac9971d8c42c57

Correct typo in role's playbook in order to be able to deploy
the service with customized policy file.

Change-Id: I252ffaf73dd2a649387ddacc73286b49f36dfdf2
Closes-Bug: #1948835

It seems some cases were missed in reviews and not fixed by
the previous iterations:
Ifc252ae793e6974356fcdca810b373f362d24ba5
I838e526b930d5276d3ce24f5188262af7eb33280

Change-Id: Id57da1c5024e1efc5810baca8fbe18967cf95a68

As promised for Xena.

Change-Id: Id634426a1961f0b883068e4ed80e7d1633e5708e

The copy job for the grafana home dashboard file needs to run
priviliged, otherwise permission denied error occurs.

Closes-Bug: #1947710

Change-Id: Ib15e961e5193af55e45a443305a96667295f3cb7

Closes-Bug: #1947534

Change-Id: I08be074c3633cc4fb0a0bc6c9cb8d03eb5226d89

There seems to be a bug in Galera that causes
TASK [mariadb : Check MariaDB service WSREP sync status]
to fail.
One (in case of 3-node cluster) or more (possible with
more-than-3-node clusters) nodes may "lose the race" and get stuck
in the "initialized" state of WSREP.
This is entirely random as is the case with most race issues.
MariaDB service restart on that node will fix the situation but
it's unwieldy.
The above may happen because Kolla Ansible starts and waits for
all new nodes at once.
This did not bother the old galera (galera 3) which figured out
the ordering for itself and let each node join the cluster properly.
The proposed workaround is to start and wait for nodes serially.

Change-Id: I449d4c2073d4e3953e9f09725577d2e1c9d563c9
Closes-Bug: #1947485

This change adds the dnsmasq.log for the ironic-dnsmasq container and
also enables more verbose logging when debug logging enabled.
This can be triggered globbaly via 'openstack_logging_debug' or per
service via 'ironic_logging_debug' or 'neutron_logging_debug'.

Change-Id: I0e6b089beb88827effbcc365625eb2df902f5470
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

The section [ovs] is needed only for ovs/ovn configurations.

TrivialFix

Change-Id: If9015b8f53c04cf3257331449ebd50163fabcab0
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Weight for haproxy backend was merged in [1] with
tiny bug, there is need to convert to int to check
conditional <= 256. Otherwise, it's not working as
expected.

[1] https://review.opendev.org/c/openstack/kolla-ansible/+/775627

Change-Id: Icb6f5147ebd2a0be52ba4ef6ba4a00bbd0242d3d

This is unused since we switched to a single config file for logrotate.

Change-Id: I79a5fd84b071b2a127c09ac41c3de9074289fca0

Change-Id: I86aeafccd2a2bff1d89a40785e1a6715097bb849

"BINLOG MONITOR" and "SLAVE MONITOR" replace
"REPLICATION CLIENT" (which is now an alias for "BINLOG MONITOR").
The validation in Ansible MySQL collection is too simple to
understand aliases and breaks. Hence, let's use the canonical
names and adapt per service according to its needs.

Change-Id: I1175e4846384accd19942620dc155d0c5728e64b

We do not need anymore as APT already knows how to do HTTPS.

Change-Id: I0b89b17ea2443e4578906afe4b518477462f981f

Change-Id: I6da412d6d3e7d067c8d903ee884711ac509d24aa

Nor set related sysctls.
More details in the reno.

Change-Id: I898548ecc6df3caa094c3222159b7ba1e16dc211
Closes-Bug: #1945789

Updates the default value of 'monasca_ntp_server' from
'external_ntp_servers[0]' to '0.pool.ntp.org'.  This is due to the
removal of the 'external_ntp_servers' variable as part of the removal of
Chrony deployment.

Change-Id: I2e7538a2e95c7b8e9280eb051ee634b4313db129