* enable iscsid when ironic is enabled
* update sample inventory files with above
* add logrotate conf template for iscsid
* add 'common' role dependency for iscsi role

Change-Id: I3054b9139a43542febf26c3ce9a71b65f2fcdd84
Closes-bug: #1632850

If enable_rabbitmq or enable_keystone are false, the configs will not be
copied to target nodes for these. This resulted in Heka failing to
start.

Change-Id: I93d15534802b671f1f42e8b2dfb523a17526ffb7
Closes-Bug: #1630613

Change-Id: I66138f3d033461363d8cbf30104afa7a4643cff8

Horizon was missing SESSION_ENGINE from it's conf which means it was not
making use of memcached.

Change-Id: I450aee05f59e344902f1e92d913f4c1ce9e8dcc6
Closes-Bug: 1630509

Change-Id: I6f88a4ecb4ba980836b4778252bb49731463f4eb
Closes-bug: #1630377

The if/else blocks in this file cause a rendering error on control nodes
when enable_neutron_dvr: yes

ParsingError: File contains parsing errors: <???>
        [line  3]: u'    external_network_bridge =\n'

Change-Id: Ia461dcbbec531c4c6295b3c7e10da12c57b7d58b
Closes-Bug: 1626995

On RedHat family distro, util-linux provides the hexdump. On Debian
family distro, bsdmainutils provides the hexdump.

Change-Id: If762f570639782ca477ae4697f354d88c992613b
Closes-Bug: #1627755

pxelinux.0 and chain.c32 files are provided by two
separate packages on xenial compared to 1 on trusty.
This change adds the required package to be installed
and new paths the files reside on xenial.

Change-Id: I48a3622f7257f4cbf994258f82ba91947aae3be4
Closes-bug: #1629337

the bad pycparser wheel package has beed removed.

This reverts commit 195bcd0f.

Change-Id: I4669a627b68c4bd7534288c4a594a49226db3832

Sahara endpoint need api version and tenant_id
in the URL, otherwise will fail with an incorrect
path/resource could not be found.

Change-Id: I348919b8ff1d00a1f6ce782f07ce2354201bac8b
Closes-Bug: #1629895

By default HAProxy send pre-4.1 authentication packets which are cause
warnings on server side. To use modern MySQl authentication mysql-check
configuration have to include post-41 option.

Change-Id: I88609d3a0cc3ce4a10e64ba65230ba4d97f34419
Closes-Bug: 1629911

We need install rabbitmq_clusterer plugin in the rabbitmq server folder.
create a rabbitmq_server-3.6 folder to handle the z stream change for
rabbitmq-server.

TrivialFix

Change-Id: I5254c1909f169e542d1a5efc910d5e17a53de7ff

When the iscsid containers is included in the kolla deployment it starts
successfully on a compute node but fails to start on a storage node, if
cinder is enabled because the config file is not copied to the container
BTW, if cinder is not enabled the iscsid container starts successfully
on both the compute and storage nodes.

Change-Id: I665535d858affebc9623b29f79c89c18f7cc399f
Closes-Bug: #1629381

command fails since it is a compound command. Changed to a single awk
command instead.

Closes-Bug: #1629206

Change-Id: Id7963b15c3321eca6f891a625b1ba140dc57aa22

* set the push queue worker daemon
* force exit when using twice Ctrl + c in build.py script.

Change-Id: Ib3278ee9909f94a5129854c3c6fc9720a91a19f3
Closes-Bug: #1629654

* Mount system folder in ironic-conductor
* Add package need in ironic-conductor
* Fix the log path issue
* Add ironic sudoer in ironic-base
* Fix credential issue
* Do not start nova-compute when enable ironic

Closes-Bug: #1629334
Change-Id: If9d478c6513de37465403d458a88cf0da7ebd8a6

rabbitmq-server version upgrade to 3.6.5 in RDO repo. This patch set

* Download the rabbitmq_clusterer plugins to the correct path
* Install 3.6.5 rabbitmq-server for Ubuntu/Debian distro

Closes-Bug: #1611655
Co-Authored-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Change-Id: I8de9a553b506a15f4d96cc6b55f21e3a27887a1d

pycparser-2.14-py2.py3-none-any.whl is broken or something
misconfigured, while pycparser-2.14.tar.gz is ok.  Revert this PS when
the bug is fixed[0]

[0] https://github.com/eliben/pycparser/issues/147

TrivialFix

Change-Id: If719a5fdfbcedfe4770354b18dc47cc94e90dc3d

By default CADF events added even if they are disbaled in all.yml.
Boolean check is missing is added so that CADF configurations will
be added only if it is enabled.

Change-Id: I757ae176228cc4e74d06ce85b27200bdcdd5dd5c
Closes-Bug: #1607904

In cf0c25c3 [0] a play was added to run the common role against all
hosts. This ends up being redundant since every role includes the common
role as a dependancy. The reasoning behind this change as pointed out by
the author in the review comments [1] was so that an operator could run
with '--tags common' and just have the common role applied.

To avoid redundancy, the common play has been removed and tags have been
added to the common role. This allows for just the common role to run
when another role is including it while reducing redundancy.

A side affect of removing the common playbook which runs against all
hosts is that not all facts on all hosts are gathered at the beginning
of the site.yml. This breaks the haproxy role since it relies heavily on
facts to build out the haproxy.cfg file.

Previously, the haproxy role would include several hosts purely for fact
gathering purposes as pointed out in c68c9d95 [2] and a guard was put in
place so that the tasks would only run against the 'haproxy' group. In
423e3f3f [3] these hosts were removed. After reading the review [4],
this seems to have been done without fully understanding why the hosts
were there in the first place.

This change did not break anything however since the common role that
ran on all hosts mentioned previously would gather all of the facts
necessary.

To fix this fact gathering issue replace the common role play with a
play that will simply gather facts with an 'always' tag to ensure it is
run regardless of what might be passed in the '--tags' argument by the
operator.

Kudos to Paul Bourke for helping identify many of these issues.

[0] https://github.com/openstack/kolla/commit/cf0c25c37d4dd901a839a12247212c22493e1409
[1] https://review.openstack.org/#/c/369212/
[2] https://github.com/openstack/kolla/commit/c68c9d95fca6485c79a607b3716a88e284c7a64e
[3] https://github.com/openstack/kolla/commit/423e3f3fdf07f40b46fed1125076880660d14c53
[4] https://review.openstack.org/#/c/355861

TrivialFix
Closes-Bug: #1628472

Change-Id: Ia94146579e743935501f1ff4b4c1bf6cb7c43aa3