* Use 'apt install' command instead of legacy 'apt-get'

Change-Id: Idae8d325bce354fa3b4c5be412965122af8f1413

The concept of splitting the compute group into external/internal just
to specify agent_mode for Neutron DVR was deemed to be heavy handed, and
depreacated in the Pike cycle.

Now that Rocky has been released we can remove these completely for Stein.

Change-Id: I28a1eba7f40fee55a7ec41c27451e39e4d7fd8f0

The parameter "NUMBER_OF_MONITOR_NODES" is needed when run
bootstrap.sh[0], but it's missing, this ps to add it.

[0]: https://github.com/openstack/kolla-ansible/blob/master/contrib/dev/vagrant/bootstrap.sh#L206

Change-Id: If83620bbdeaf8c4805e021242ca44da069e43922

Change-Id: Ibc06f614604150a331787889a59407803a411b90

When bootstrapping the vagrant dev environment run commands on the
operator node to set up the kolla-cli, and to set up the host
inventory as appropriate for either multinode or aio deployment.

Change-Id: I7765d5302329919dce6317d78b84af1c7bf572b3

when use bootstrap.sh script to prepare the development
environment, the /etc/kolla/globlas.yml and
/etc/kolla/passwords.yml is missing, this ps to fix it.

Change-Id: Id00187ec032c7a6c98d0772def12f142ef13fb22
Closes-Bug: #1766081

Updated the vagrant dev environment to include support
for development and testing of the kolla-cli

Change-Id: I1d8f66cced7f0a9cc37e3b296c5ae10ab989f736

With libvirt 2.0, when using qemu cpu mode is not properly
evaluated and need to be set to cpu_mode = none.

Add this option when kvm is not supported, otherwise user
will still facing errors when launching instances over qemu.

Change-Id: I7aa6df356085263d25c6afcc812f035d3ded942b

Firewall managers in
Ubuntu  ufw
Centos  firewalld
Closes-bug: #1716912

Change-Id: I7556fcfe4947e73f4b7f4b37c2477d9694a36c26

The pypi package 'docker-py' [1] has been renamed to 'docker' [2].
It is better to move to the new 'docker' package because the old
package will be deprecated and all the new features will go into
the new package only.

Package 'docker' has been added to requirements [3]. The old
package 'docker-py' is still allowed to be in the global requirements
during the transition period but it should be removed after all or
most of the projects finsih the migration.

[1] https://pypi.python.org/pypi/docker-py
[2] https://pypi.python.org/pypi/docker
[3] https://review.openstack.org/#/c/423715/

Change-Id: Ibcd5a57a1fbf55dcc5a690e41f20917f95b63da0

 - Updated Ubuntu image to use 16.04.
 - VirtualBox provider to use centos/7 image + vagrant-vbguest plugin.
 - Improved docs so it is clear that vagrant-vbguest plugin is only
   required with VirtualBox.
 - Clarified comment and made it independent of the release.
 - Refactored the kolla and kolla-ansible paths to be based on the
   username used by Vagrant, that can change depending on the image.

Change-Id: I23d84dcc3297c43eb12eff9c443d282281fc6c82

The 's' command wasn't closed properly. This was fixed in kolla repo
before it was decided that the dev env should go in kolla-ansible.

Change-Id: Ia1434ebb276f0fc76bf88fe386b8e9527133ce4d

After the repo split into kolla and kolla-ansible the Vagrant
development environment was broken.

With this change Vagrant will run from kolla-ansible and kolla
repo is expected to be in the same directory level so the
bootstrap can include it inside the VM.

 - Modified the bootstrap code to copy both repos into the VM.
 - Added one configuration token to specify kolla-ansible location
   inside the VM.
 - Updated the docs.

Change-Id: I6b56822d50472f8eda6fc60f69196d3c9b8b6cf8
Closes-Bug: 1693847

The file path was not properly passed to the '-x' test which caused it
to always return true.

This commit simplifies the test for existing command by relying only on
the exit code of `type` rather than checking that the file path is
executable.

Change-Id: Iaf47d92ff9fd1ef34d8d7492c08ec24d2b8a9536
Closes-Bug: #1635341

Keep consistent with other "if" condition
TrivialFix

Change-Id: I18fea71bd50729642543afd4d3bab0b7dfaecd3d

Correct relative path of kolla root directory after vagrant environment was
moved from dev/vagrant to contrib/dev/vagrant.

Closes-Bug: #1635329

Change-Id: Ib13a6123f34d69884e27029f5144ff1ad165e73e

TrivialFix

Change-Id: Ifb8f19afa1514488bd288670d08b96f84982a4e1