Closes-Bug: #2036741

Change-Id: Ib448d04e43dff78e344064161beadae917c41206

Initially Ubuntu/Debian used /var/run/openvswitch as default OVN run dir,
it seems it has changed long time ago - but we haven't picked that up on latest
OVN DB refactor.

Adding in OVN and OVN upgrade Debian jobs to enhance coverage.

Closes-Bug: #2035584

Change-Id: I78967c4499269578ac921ad9a553946b65e1293f

it is already in test_openstack_logged function

Change-Id: I2d092b4cf6dc6527d1c3c5e172349e480c2366d3

Change-Id: If9636aaa76a7dc094223c3f096d96c96ecd0c8e7

This reverts commit 2524ec42.

Reason for revert: I don't think we need it anymore

Change-Id: I9f2871cf3de1a09952fc5c236da2f78e4d930bf5

Up till now the ARA plugin has been pinned to a very old version,
and is no longer functional.

This installs a much newer version of ARA and adds a README file
to guide developers on how to view the sqlite file.

The ARA plugin is installed by default, but not activated. This
is intended to catch a small amount of regressions and
integration failures.

Developers can enable the plugin by adding the string `#ara`
to their commit message. This avoids extra load on the CI.

Change-Id: Id8328e374c9590b1363026fa2b2b24e191183987

Change-Id: Ia982df80d688522dbaa5fc3e462c1a009d512cb6

Sets the variable ``om_enable_rabbitmq_high_availability`` to ``true``
by default. An upgrade will therefore require some manual steps to
migrate from transient to durable queues. Note that this will be
caught by this precheck:
https://review.opendev.org/c/openstack/kolla-ansible/+/880274

Also updates the CI upgrade jobs to perform this migration. This will
need to be removed in Caracal.

Related-Bug: #2031294

Change-Id: I26a70d4722aaa4663eced5f5337840474c7b961c

MariaDB bootstrap has a phase where the first MariaDB container
is running with Galera bootstrap - after a check that WSREP
is synced is successful - we restart the container.

The bootstrap container is named mariadb and running with
docker_restart_policy: "no" - the restarted container should be running
in systemd.

Before this patch the code created a systemd unit but it was initially
stopped - so stopping was always a success - and the container would be
killed with SIGKILL on removal (which obviously breaks MariaDB).

This patch also improves docker/systemd stops by waiting for real
unit/container stop and adds failing CI for containers that are
killed with signal 9.

Closes-Bug: #2029613

Change-Id: I0a03e509ce228a50e081fcab44d2b4831251190c

Change-Id: I4c5ade2d687684f37df83b44a852d88c77067680

Change-Id: I7b998b34881084a68669dc9351ea1937c61534fa

It's not needed anymore, since both Ceph and ansible-collection-kolla
are setting that by default.

Also fix test-core-openstack so it doesn't delete a server before
volume attachment test.

Change-Id: I20bd352479ee5562514084d0d11063e45e8b956a

We've seen issues in CI when keepalived haproxy check script returns
an error and keepalived is switching to backup and then again to primary
on a single node environment.

Closes-Bug: #2025219

Change-Id: Iba62e76b3cf83f3ade6df81288d2d77129ffc725

Ansible 2.14.3 introduced a change that broke the method used for
restarting MariaDB and RabbitMQ serially [1][2]. In
I57425680a4cdbf0daeb9b2cc35920f1b933aa4a8 we limited to 2.14.2 to work
around this. Ansible upstream claim this behaviour was unintentional,
and will not fix it.

This change moves to a different approach where we use separate plays
with a 'serial' keyword to execute the restart.

This change also removes the restriction on the maximum supported
version of 2.14.2 on ansible-core - any 2.14 release is now supported.

[1] https://github.com/ansible/ansible/commit/65366f663de7d044f42ae6dd53368fd4c1f88b35
[2] https://github.com/ansible/ansible/issues/80848

Depends-On: https://review.opendev.org/c/openstack/kolla/+/884208

Change-Id: I5a12670d07077d24047aaff57ce8d33ccf7156ff

The kolla-genpwd, kolla-mergepwd, kolla-readpwd and kolla-writepwd
commands now creates or updates passwords.yml with correct
permissions. Also they display warning message about incorrect
permissions.

Closes-Bug: #2018338
Change-Id: I4b50053ced9150499d1d09fd4a0ec2e243cf938b
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Setting the CONTAINER_ENGINE env var was missed in one spot in [0].

[0] I395d2bdb0dfb4b325b6ad197c8893c8a0f768324

Change-Id: I29868d59cbef2bd5707ab20d2c30a2d8f6d6060e

Depends-On: https://review.opendev.org/c/openstack/neutron/+/878535
Change-Id: I05d8b29b59a7de76da488f68775547a8f0f11d0f

We limit to 2.14.2 due to a regression in ansible-core [1] that breaks
conditional include_task loops in handlers. This is used for controlled
restarts of MariaDB and RabbitMQ.

[1]: https://github.com/ansible/ansible/commit/65366f663de7d044f42ae6dd53368fd4c1f88b35



Change-Id: I57425680a4cdbf0daeb9b2cc35920f1b933aa4a8
Co-Authored-By: Michal Nasiadka <michal@stackhpc.com>

Sometimes services have problems connecting to the database
or rmq on upgrade jobs, and we're not retrying the test.

Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/882344

Change-Id: I9fca3d4336375b72d09633b51c8596e0c08abbf9

This patch add a way to choose container engine inside tool and test
scripts. This is in preparation for Podman introduction but still
leaves Docker as default container engine.

Signed-off-by: Martin Hiner <m.hiner@partner.samsung.com>
Change-Id: I395d2bdb0dfb4b325b6ad197c8893c8a0f768324

Adds a flag ``kolla-ansible octavia-certificates --check-expiry <days>``
to the ``octavia-certificates`` command to check if the certificates
will expire within a given number of days.

Change-Id: I869b8afd85fe282d823ecf3593aa22f94a61b2a0

New openstack collection modules have changed output
dicts/variable names - adapting to that.

Also changing octavia amphora image to focal, since bionic
hasn't been rebuilt since May 2021.

Closes-Bug: #2012255
Change-Id: Icf38a52472d02ef7d69bcd3716afb16e859d44a2

This reverts commit 9867060b.

Reason for revert: seems this broke some jobs

Change-Id: I1ca81214ece403351c0a522ea05bf07802e4c4c0

Change-Id: Ibc9cc91f64b0450de3cae6e2830b4ff2c52c0395

Make sure to actually test IPv6 connectivity to our test instance in the
IPv6 jobs.

Change-Id: I7845448804e191af356e82f8ad33c563ffd8ebd5

Closes-Bug: #2012654

Change-Id: I9735b4409a48d80851cbc26a9edbf370af1d45bf

Related-Bug: #2007142

Change-Id: I9ce2a9ce5413e77625201f3986967e31a679ad9c

CentOS Storage SIG rpms have a recommended install
section that installs podman - let's stop doing that.

Ceph is also suffering from the enormous open files
ulimit that EL9 defaults to - let's set a default
in docker engine for now.

Change-Id: I41f39f520dfecec307ad3b86e1e0363570198e42

Fourth part of patchset:
https://review.opendev.org/c/openstack/kolla-ansible/+/799229/


which was suggested to be split into smaller patches.

This commit refactors select methods from DockerWorker class
into ContainerWorker class. New class contains Docker independent
methods also used in Podman introduction and is inteded as a
parent class for specific worker classes.

Signed-off-by: Ivan Halomi <i.halomi@partner.samsung.com>
Co-authored-by: Martin Hiner <m.hiner@partner.samsung.com>
Change-Id: I2dd5920410dda053f2dfedc4e2666c56b1a7095a

Change-Id: I186651e2ad05a76a606444ee673b73e171456312

cpu_model is deprecated

Change-Id: If30fb6aec745a48c42a2f281f726a869017ba9b9

Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/872590
Change-Id: Ia8283f28147fbbd2d24028d01e021f95598b86fb

Change-Id: I115b491eca413437926f5bcaf53336151f9a7c0b

Change-Id: I99145322f65468e9926b1412844ad4ccaa6829d7

This patch fixes kolla_docker module
as it did not take into account common_options
parameter. From patchset it's visible that module's
default values are used always - even if user overrided
some param in common_options dict.

Closes-Bug: #2003079

Change-Id: I677fde708dd004decaff4bd39f2173d8d81052fb

It is deprecated in 20.10 and removed in 23.0 (and 23.0 is out) [1], [2].

[1]: https://docs.docker.com/engine/deprecated/#kernel-memory-limit
[2]: https://docs.docker.com/engine/api/version-history/#v142-api-changes

Change-Id: Ia6fa85172aad7bcd5f958922d3c224ef79882e6c

This commit adds SystemdWorker class to kolla_docker ansible module.
It is used to manage container state via systemd calls.

Change-Id: I20e65a6771ebeee462a3aaaabaa5f0596bdd0581
Signed-off-by: Ivan Halomi <i.halomi@partner.samsung.com>
Signed-off-by: Martin Hiner <m.hiner@partner.samsung.com>

Change-Id: Iac88aece372102835b03f7e0e5684d0285857e97

It's not supported in ansible-collection-kolla since Zed release,
and Kolla executed Kolla-Ansible CI jobs fail on it, because
they build images.

Change-Id: Ib0358f780a77af152225761a4aa3b6acbea2eeaf

Change-Id: I110c642da925a5f6b3bd071e7844c20fda673c66