During cleanup-host, we need remove swift references from fstab.

Change-Id: I18e9a84b0664eb834cf397bcf6d2406abcab47a7
Closes-Bug: #1689285

Freezer service configuration can't be override has describe here:
https://github.com/openstack/kolla-ansible/blob/master/doc/advanced-configuration.rst#L161

Kolla-ansible should look for files in /etc/kolla/config/ but it doesn't
take config files into account. This patch fix it.

Change-Id: Ia7d8d0892d13ba9785951a7b1291abb868fc714b
Closes-Bug: #1682404

The 'ansible_python_interpreter' has already defined in /etc/bifrost/bifrost.yml
we should remove the redundant variable

Change-Id: Ie799170d3318a731d31e1f39bcf940a1b220bd53

Change-Id: I6c725efd9d08a079ced2abca5be188b6ceac55c2
Closes-bug: #1682000

Creates Openvswitch role and splits
openvswitch from Neutron role to enable
third party networking solutions that use
Openvswitch or customize Openvswitch.
For example Openvswitch with dpdk or
OpenDaylight.

Change-Id: I5a41c42c5ec0a5e6999b2570ddac0f5efc3102ee
Co-Authored-By: Mauricio Lima <mauriciolimab@gmail.com>
Partially-Implements: blueprint opendaylight-support

Nova service-list is returning empty registered service
when in database they are. Because of this, simple_cell_setup
is not executed and deploy stucks waiting for nova-compute.

This change temporaly checks the database for existing nova services
instead of openstack compute service list.

This change will need to be reverted once the command is fixed.

Change-Id: Ic508eb3ff03b5f233186353fc7697305cc792d14

Change-Id: Icb9b097299011cc09f3012bbee9629a5457c920c
Closes-Bug: #1681316

Now, I see mariadb are using utf8_general_ci as a default collation.
- https://mariadb.com/kb/en/mariadb/supported-character-sets-and-collations/

This mean all of Devstack database will be created with utf8_general_ci collation,
so may be, one service/project can be deployed successfully via Devstack
but will be fail with Kolla deployment.

Therefore, we should use above default collation for Kolla-ansible.

Change-Id: Icbb6c15f536fc6986816c58f4fd68bfb95813e46
Closes-Bug: 1680783

Cloudkitty processor use tooz to handle multi processor processes.
Otherwise, duplicated billing will be inserted into mysql.

Change-Id: Ifdc1be78afa89499ee4c3bbec5b9db8ddb2929cf
Closes-Bug: #1681160

The example to pull images is incorrect, this patch
addresses it and corrects it accordingly.

Change-Id: Ice79e7f73d99c024781cb379d190f6d05e1a34a9

Turns out this variable is not so useless...! In
I2c167bae6f34a102cd7fe66401d7defe13bf2bf7 we need to determine if a file
based backend is in use in order to determine how many api servers to
start. Without this variable these kind of checks would all need to be
updated every time a new shared storage backend is added.

This reverts commit 867c3bda.

Change-Id: I335acc12b68b577b33d6cb28675225c40e6231cd

The current module 'kolla_sanity' was written as a shim before full
shade support was added to Ansible. This should now no longer be needed,
we can implement the checks using Ansible provided modules.

Begin by updating the Keystone check to use 'os_auth' to fetch a token,
I think this is a good basic smoke test to verify Keystone is working.

Change-Id: I16049d9201fd8138c781ef2e1e0c1827ea817259
Partially-implements: blueprint sanity-check-container

Issue seems not fixed, it requires more work

This reverts commit 4f6470bb.

Change-Id: I308ea4e0d5ace60cf730944e1883966fc6f8f8ce

The InfluxDB plugin will collect metrics on the given InfluxDB servers.

Change-Id: I23f0433f56047369ce19bbf3236f6dd7038eb06e

Change-Id: Ib684e3f4bcd26e40c5bfde9bec8a1d83563d5460
Signed-off-by: Pavel Glushchak <pglushchak@virtuozzo.com>

New version of influxdb use "autogen" as default retention policy name.
Please see https://github.com/influxdata/influxdb/issues/3733 for more
info.

Change-Id: I8aeb47f60b3aeb022e0cd7aaac630d7cad5b0099
Closes-Bug: #1673914

Actual InfluxDB config is deprecated, it must be updated based on the
following documentation:
https://docs.influxdata.com/influxdb/v1.2/administration/config

* remove following options:
  lease-duration = "1m0s"
  pprof-enabled = false
https://github.com/influxdata/influxdb/commit/22173acb707af833b832126f8631e0afda445ea9

* rename "cluster" section to "coordination":
https://github.com/influxdata/influxdb/commit/75e89e35d80dfad65146c8d8a1df2d7b9930c99a

* remove shard-writer-timeout option:
  shard-writer-timeout = "5s"
https://github.com/influxdata/influxdb/commit/db7d58c867513d019c1b9f1718772062b5c491bc

Closes-Bug: #1678982
Change-Id: Id905336123bc5aa76d6e6903a82f915c3702669f

In case of karbor-protection providers.d/openstack-infra.conf config file modification,
karbor-operationengine and karbor-api are restarted too, but they should
not.

karbor-operationengine startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/karbor/templates/karbor-operationengine.json.j2#L2

karbor-api startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/karbor/templates/karbor-api.json.j2#L2

Change-Id: I91a0273ccf46e340315cf885ea01db6e14653182
Closes-Bug: #1677542

Refer to
https://docs.openstack.org/ocata/install-guide-rdo/glance-verify.html

Change-Id: Ic2a32a3f17a11f1f6e8ecf0f7271d7d1f12ca5bc

Fluentd actually parse all files in /var/log/kolla/*/*.log as Openstack
services files.
Dnsmasq file /var/log/kolla/neutron/dnsmasq.log, must be add to
exclude_path to avoid this warning message:
"/var/log/kolla/neutron/dnsmasq.log unreadable. It is excluded and would
be examined next time."

Change-Id: I8dc5320b9ed299200c4f1e6ee52d34a918e2f110
Closes-Bug: #1678530

If the Open vSwitch agent is being used, set extensions to qos
in the [agent] section of ml2_conf.ini.
see
https://docs.openstack.org/ocata/networking-guide/config-qos.html

Change-Id: I85272b03222775b14a311a110077a8eed736f56c
Closes-Bug: #1676319

In case of trove-api service config file modification (trove.conf file),
trove-conductor and trove-taskmanager are restarted too, but they should
not.

trove-conductor startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/trove/templates/trove-conductor.json.j2#L2
=> trove.conf is not used

trove-taskmanager startup command:
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/trove/templates/trove-taskmanager.json.j2#L2
=> trove.conf is not used

Change-Id: Ic4703a571cec5bf8b3f91cfcb9da1a23e2bb300b
Closes-Bug: #1677531

Change-Id: I79d99acfb9410d83ab1c84df3553db463f3f948f
Closes-Bug: #1677952

Co-Authored-By: caoyuan <cao.yuan@99cloud.net>
Change-Id: Iddde03760ff85af5263868ebc47b8b9438e92e8e
Partially-implements: blueprint better-reconfigure

When glance_backend_ceph is not enabled, glance uses file as
backend store by default. Since glance_backend_file is useless
and not overriding glance backend when glance_backend_ceph is
enabled. I think it is good to remove it.

Change-Id: I94cbd8661e43ab296478470ed57d0effc5622ee5

Change-Id: I13cf03d6a97fb94dd7cb309e99a417ad101dc21a
Co-Authored-By: Mauricio Lima <mauriciolimab@gmail.com>
Partially-implements: bp add-zun-ansible-role

Option "secure_proxy_ssl_header" from group "DEFAULT" is deprecated
in Keystone.

see
https://docs.openstack.org/ocata/config-reference/identity/samples/keystone.conf.html

Change-Id: I390969fce5b592c0267399969abc54e5caffbfc8
Closes-Bug: #1675982

If disable cinder in openstack environment.
Cinder of configuration items do not need to configure in nova.conf

Change-Id: Ie346dfe45f8c2d3fd383095d0c64f8e9421100ff

min_l3_agents_per_router parameter has been removed in neutron[0].
So we can remove it.

[0] https://github.com/openstack/neutron/blob/master/releasenotes/notes/remove-min-l3-agents-per-router-27aef7d91dec0348.yaml

Change-Id: Ia3f3686e2cc27e4bd0707add50ebc552117d6b03
Closes-Bug: #1677101

Replace all DOS carriage returns (^M) with Unix line feeds.

Change-Id: I0cb757e2aa9c08d87d5da64cc416b3d468219df6

'v1' is missing in DEFAULT/swift_url property for trove.conf and
trove-taskmanager.conf file.

Closes-Bug: #1677362
Change-Id: I7f625b1ac665a26c4207c3cbb9b0238da82993d8

There are to parameter for ceph-mon/ceph-osd/radosgw, "-f" and "-d".

    -d run in foreground, log to stderr.
    -f run in foreground, log to usual location.

When log tin stderr, docker engine will collect the logs. It is useless
and we should write the log into file only. Then stop writing log to
stderr.

ceph-mon log location is controlled by "mon cluster log file".

Change-Id: I7883a4316420bc2bf4c772cb7248b663359f54b7
Closes-Bug: #1677237

During "Optimize reconfigure action for Telegraf" previous commit, a
regression has been introduced on the "reconfigure" action.
https://review.openstack.org/#/c/424202/

The start.yml file has been deleted but reconfigure.yml still using it.

This patch fix it.

Change-Id: I8879b83ce7a1f886f6870d79f63c3f1cc706059b
Closes-Bug: #1676403

cinder-volume will be hanged if rados_connect_timeout is disabled. And
no error message will be thrown. Disable timeout is not a good idea.

This patch sets the rados_connect_timeout to 5.

Change-Id: I05e7343d09d75399a7031013b4329a2cb81792fb
Closes-Bug: #1676267

Last Openstack version supported on Ubuntu 14.04 is Mitaka.
Hence Ubuntu 14.04 related code can be safely remove from Ansible tasks
since Kolla Newton release.

Change-Id: I7202c1f6d21a2e6f3536c0420a7cc889aff0f5ed

The following WARN logs always appears in nova-api.log:
- Option "firewall_driver" from group "DEFAULT" is deprecated for removal.
- Option "linuxnet_interface_driver" from group "DEFAULT" is deprecated
for removal.

These 2 options can be removed for the following reasons:
- nova-network will be deprecated
- moreover Kolla doesn't configure nova-network

Options deprecation notes is here:
https://github.com/openstack/nova/blob/master/releasenotes/notes/deprecate-more-nova-network-opts-a9f87c79f7d26438.yaml#L8
https://github.com/openstack/nova/blob/master/releasenotes/notes/deprecate-more-nova-network-opts-a9f87c79f7d26438.yaml#L37

Change-Id: I12f80a02b9d27f2bdbb8926eb648ea4f6e6dd945

Link https://docs.openstack.org/project-install-guide/key-manager/newton/barbican-backend.html#simple-crypto-plugin

Change-Id: I351738c2a98090c56ac69e477fbe5ddec4cc5b26
Closes-Bug: #1672001

Given keepalived runs on the network node, we should have a minimum of
two by default for high availability.

Change-Id: Ifbd68e456dc93319df8e85017fd9f4db09f05929

Heat can send RPC notifications to Ceilometer as define here:
https://github.com/openstack/ceilometer/blob/master/ceilometer/pipeline/data/event_definitions.yaml#L139

oslo_messaging_notifications section MUST be managed in heat.conf file.

Closes-Bug: #1674935
Change-Id: I314e34a7a7b6caab72b916331f5f20c29afde438

service_name variable is defined in tasks but not used everywhere.

Change-Id: I67a95f49d277cf004338a9c184e7be70608714b7