Skip to content
Snippets Groups Projects
Select Git revision
  • deployment default
1 result
Search by author
  • Any Author
0 authors
  1. Sep 30, 2016
    • Andrew Widdersheim's avatar
      Remove redundant common play and add haproxy hosts · 4963898b
      Andrew Widdersheim authored 
      In cf0c25c3 [0] a play was added to run the common role against all
hosts. This ends up being redundant since every role includes the common
role as a dependancy. The reasoning behind this change as pointed out by
the author in the review comments [1] was so that an operator could run
with '--tags common' and just have the common role applied.

To avoid redundancy, the common play has been removed and tags have been
added to the common role. This allows for just the common role to run
when another role is including it while reducing redundancy.

A side affect of removing the common playbook which runs against all
hosts is that not all facts on all hosts are gathered at the beginning
of the site.yml. This breaks the haproxy role since it relies heavily on
facts to build out the haproxy.cfg file.

Previously, the haproxy role would include several hosts purely for fact
gathering purposes as pointed out in c68c9d95 [2] and a guard was put in
place so that the tasks would only run against the 'haproxy' group. In
423e3f3f [3] these hosts were removed. After reading the review [4],
this seems to have been done without fully understanding why the hosts
were there in the first place.

This change did not break anything however since the common role that
ran on all hosts mentioned previously would gather all of the facts
necessary.

To fix this fact gathering issue replace the common role play with a
play that will simply gather facts with an 'always' tag to ensure it is
run regardless of what might be passed in the '--tags' argument by the
operator.

Kudos to Paul Bourke for helping identify many of these issues.

[0] https://github.com/openstack/kolla/commit/cf0c25c37d4dd901a839a12247212c22493e1409
[1] https://review.openstack.org/#/c/369212/
[2] https://github.com/openstack/kolla/commit/c68c9d95fca6485c79a607b3716a88e284c7a64e
[3] https://github.com/openstack/kolla/commit/423e3f3fdf07f40b46fed1125076880660d14c53
[4] https://review.openstack.org/#/c/355861

TrivialFix
Closes-Bug: #1628472

Change-Id: Ia94146579e743935501f1ff4b4c1bf6cb7c43aa3
      4963898b
  3. Sep 26, 2016
  5. Sep 25, 2016
  7. Sep 24, 2016
  9. Sep 23, 2016
  11. Sep 22, 2016
  13. Sep 21, 2016
    • bjolo's avatar
      missing space breaks haproxy from starting · 419454c6
      bjolo authored 
      TrivialFix

Change-Id: I11efb23a51d424710cdb3bab520b572486b16be6
      419454c6
    • James McCarthy's avatar
      Remove ansible serial: option for haproxy and rabbitmq. · d5e5700f
      James McCarthy authored 
      By having serial in site.yml for these roles will mean (particularly
during an upgrade) that tasks can be executed out of the intended
order across hosts, leading to unexpected results.

Change-Id: I44f0c66c445d853a2e4af69119562f13b4424936
Closes-Bug: #1626096
      d5e5700f
    • Vladislav Belogrudov's avatar
      Cinder cannot use external non-LVM iSCSI storage · b1f986c3
      Vladislav Belogrudov authored 
      Currently Cinder enables iscsid service only when LVM is choosen as
backend. This fix will allow to specify external iSCSI storage via
configuration add-on and to run iscsid independently of LVM settings.

Change-Id: Iaae0f8025534e5ab1c5f9d5e812a7d41129915ef
Closes-Bug: 1614125
      b1f986c3
    • caoyuan's avatar
      Add "---" into some files of yaml · a071bce0
      caoyuan authored 
      TrivialFix

Change-Id: Id2cd736f136068514f26977b434b15a8b1ffc8be
      a071bce0
    • Paul Bourke's avatar
      Allow operators to provision multiple physical networks · d1673ad1
      Paul Bourke authored 
      
Currently Kolla operators are restricted to configuring one physical
network (physnet1).

This change along with ml2_conf.ini augmentation can be used to setup
multiple physical networks in openvswitch.

E.g. To configure two physical networks, physnet1 and physnet2, with
ports eth1 and eth2 associated respectively:

In /etc/kolla/globals.yml, set

neutron_bridge_name: "br-ex,br-ex2"
neutron_external_interface: "eth1,eth2"

In /etc/kolla/config/neutron/ml2_conf.ini

[ovs]
bridge_mappings = physnet1:br-ex,physnet2:br-ex2

Co-Authored-By: default avatarMick Thompson <michael.a.thompson@oracle.com>
Closes-Bug: #1625700
DocImpact

Change-Id: I9454ca98d9b058368129123109ccc56f95519874
      d1673ad1
    • Eduardo Gonzalez's avatar
      Fix senlin api bind host · 9e324268
      Eduardo Gonzalez authored 
      Change-Id: I4f24bcc69e02eaa961b5791b3986e969368c50a8
Closes-Bug: #1625691
      9e324268
  15. Sep 20, 2016
  17. Sep 19, 2016