Facts define the group key to judge in incloud roles,
remove when statement does not execute to speed up execution

Partially-Implements: blueprint performance-improvements
Change-Id: If22255f1adc07ab16b46f8ad1280efdf7d713d28

The ipmi-exporter code blocks had too much indentation.

Change-Id: I2cf3ab4873d9df2dfe1375cf7e2e0e5dc6571120

We run some nova tasks once per cell, using a condition to match a
single host in the cell. In other similar tasks, we use run_once, which
will fail all hosts if the task fails. Typically these tasks are
critical, and that is desirable. However, with the approach used in
nova-cell to support multiple cells, if a once-per-cell task fails, then
other hosts will continue to execute, which could lead to unexpected
results.

This change adds any_errors_fatal to the plays or blocks that run these
tasks.

Closes-Bug: #1948694

Change-Id: I2a5871ccd4e8198171ef3239ce95f475f3e4b051

Change-Id: Ide82b7a7fa6752b60f2c9c31cdc4c79183fc62f6

When running in virtual environment a bootstrapping task will
install 'docker' python module in the environment. After that
prechecks and deploy phase will not find the module because
their 'ansible interpreter' is host wide. With this fix it is
advised to set an interpreter to the one in virtual environment

Closes-Bug: #1969812
Change-Id: I1bb6a3af3fa6346fff0a262e0c53d12c544f46db

There are no 5.* versions of ansible for CentOS 8 Stream yet.
One should use pip install 'ansible>=4,<6' according to the
current documentation.

Closes-Bug: #1969617
Change-Id: Ie4f502f955dac5ae9ee8ddb4779c2fa2e26840d9

We have only one value for install_type now and it gets removed from
image names.

Change-Id: I8bf95fd7aa9dd26b80d618ca0fcb097003b4cb0a

In fluentd v1.0, "format" became a deprecated parameter,
replaced by "<parse>"

Change-Id: I0825e81fcd90fbc7f64c8df3ea9ae199ad79294a

This avoids polluting job logs.

Depends-On: https://review.opendev.org/c/openstack/kolla/+/837872
Change-Id: I0bf134cd91ba35083a59787c537fc49dce998597

This uses the same approach as the mariadb role (and others).

Closes-Bug: #1928193
Co-Authored-By: John Garbutt <johng@stackhpc.com>
Change-Id: I79a7a8c80327cfd9ef31d17fe71f450a181a638c

Adds the ability to configure the Prometheus Pushgateway options
alongside the rest of kolla-ansible's configurations.

Closes-Bug: #1968597
Signed-off-by: Juan Pablo Suazo <jsuazo@whitestack.com>
Change-Id: I2d20288267ceda95076229628db10299ddbde31f

Currently the ovs-dpdkctl.sh file is present in the tools
directory and the "Copying ovs-dpdkctl tool" task accesses it.

This is bad practice. Files copied from a role should either be
referenced by an absolute path or be part of the role itself.

This change moves the ovs-dpdkctl.sh file in the files
directory of the role.

Change-Id: I01459d39207e54f270f32f37b4a5153c5a819347

With the install_type going away and actually removed from job
definitions, we have to stop relying on it - to fix otherwise
broken jobs (swift and when doing kolla builds with k-a).

Change-Id: If13c4e276d3eec29a552ed229af95f5cf016100c

Signed-off-by: Bernd Mueller <mueller@b1-systems.de>
Change-Id: I90d98be9dfb14942ffb4f5293cf52a96a643ee90

Only upgrade jobs need it set. And template uses it only on upgrades.

Change-Id: I61d2174756746f0c68d9879122c7712416ae3f88

Add fqcn-builtins to the skip list for now, we will watch how the
discussion about this evolves and defer updating all code according to
that [0].

[0] https://github.com/ansible/ansible-lint/issues/2050



Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I6dcdec4f029b87bad41530ad45d285909c8351f7

These are not needed for unit tests and we want to avoid conflicts when
running with older python versions that we still test against.

We intentionally duplicate ansible and reno as requirements in order to
avoid having to install more items than necessary.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: I0ec83c3e4ae38f911b922a3bade65429d91169eb

Change-Id: Ia2f549ba119ac09c4d1e4279baf594a42480511f