Skip to content
Snippets Groups Projects
  1. Jun 28, 2023
  2. Jul 29, 2022
  3. Jul 27, 2022
    • k-s-dean's avatar
      adds firewalld configuration based on enabled services · 8553e52a
      k-s-dean authored
      This change introduces automated configuration of firewalld and adds
      a new filter for extracting services from the project_services dict.
      the filter selects any enabled services and their haproxy element
      and returns them so they can be iterated over.
      This commit also enables automated configuration of firewalld from enabled
      openstack services and adds them to the defined zone and reloads the
      system firewall.
      
      Change-Id: Iea3680142711873984efff2b701347b6a56dd355
      8553e52a
  4. Mar 24, 2022
  5. Nov 09, 2021
  6. Jun 23, 2021
    • Mark Goddard's avatar
      Use ansible_facts to reference facts · ade5bfa3
      Mark Goddard authored
      By default, Ansible injects a variable for every fact, prefixed with
      ansible_. This can result in a large number of variables for each host,
      which at scale can incur a performance penalty. Ansible provides a
      configuration option [0] that can be set to False to prevent this
      injection of facts. In this case, facts should be referenced via
      ansible_facts.<fact>.
      
      This change updates all references to Ansible facts within Kolla Ansible
      from using individual fact variables to using the items in the
      ansible_facts dictionary. This allows users to disable fact variable
      injection in their Ansible configuration, which may provide some
      performance improvement.
      
      This change disables fact variable injection in the ansible
      configuration used in CI, to catch any attempts to use the injected
      variables.
      
      [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars
      
      Change-Id: I7e9d5c9b8b9164d4aee3abb4e37c8f28d98ff5d1
      Partially-Implements: blueprint performance-improvements
      ade5bfa3
  7. Jul 28, 2020
    • Mark Goddard's avatar
      Performance: use a single config file for fluentd · 56a07702
      Mark Goddard authored
      Currently we generate multiple fluentd configuration files for inputs,
      filters, formatters and outputs.
      These are then included from the main td-agent.conf configuration file.
      With a large number of hosts, this can take a long time to template.
      
      Benchmarking of templating is available at [1].
      
      This change switches to a single fluentd configuration file, with the
      include done locally. For the default template files included with Kolla
      Ansible we use Jinja includes, but this does not work with templates in
      a different directory. We therefore use the Ansible template lookup
      plugin, which has a slightly higher overhead than a jinja include, but
      far lower than generating multiple templates. This should drastically
      improve the performance of this task.
      
      [1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/template.md
      
      Partially-Implements: blueprint performance-improvements
      
      Change-Id: Ia8623be0aa861fea3e54d2c9e1c971dfd8e3afa9
      56a07702
  8. May 19, 2020
    • Radosław Piliszek's avatar
      Fix kolla_address in IPv6 fully-routed topo case · 0674236e
      Radosław Piliszek authored
      This includes some lightweight refactoring to avoid code
      duplication.
      
      This patch is made to be backportable to Train.
      We now include Ansible in testing since Ussuri so the comments
      about the bool filter are wrong.
      
      Change-Id: Ia2e0f7f24988763bacfeafefb7977021f5949f4e
      Closes-bug: #1848941
      0674236e
  9. Apr 04, 2020
    • Andreas Jaeger's avatar
      Update hacking for Python3 · 45448976
      Andreas Jaeger authored
      The repo is Python 3 now, so update hacking to version 3.0 which
      supports Python 3.
      
      Fix problems found by updated hacking version.
      
      Remove hacking and friends from lower-constraints, they are not needed
      during installation.
      
      Change-Id: I7ef5ac8a89e94f5da97780198619b6facc86ecfe
      45448976
  10. Apr 02, 2020
    • Radosław Piliszek's avatar
      Use unittest.mock instead of PyPI mock · 5648ad6e
      Radosław Piliszek authored
      Now that py2 is gone, oslotest dropped dependency on mock and will
      soon affect Ussuri CI [1], let's use unittest.mock built in py3.
      
      This also fixes py38 jobs and proactively prevents py36 and py37
      failing due to [1]. This is because we never included mock in
      test-requirements (but in lower-constraints where it does not
      really belong at all) and instead relied on oslotest to bring
      it in.
      
      [1] https://review.opendev.org/716322
      
      Change-Id: I30e82e2d87418272a71c7ee089a8acdaf8872158
      5648ad6e
  11. Mar 20, 2020
    • Mark Goddard's avatar
      Fix service_mapped_to_host filter · 35966c91
      Mark Goddard authored
      The service_mapped_to_host filter is used to check if a service is
      mapped to a host, based on the group for the service or its
      host_in_groups attribute if one exists. We check if the service's group
      is in the 'groups' list. However, to get the list of groups to which a
      host belongs, we should use the 'group_names' list.
      
      This filter is currently only used in neutron IPv6 module loading, so
      the effects are minimal.
      
      Change-Id: I37409ca8d273b0426df0a648db222dc5432e738a
      Closes-Bug: #1868285
      35966c91
  12. Oct 18, 2019
    • Doug Szumski's avatar
      Add unit tests for Nova Cells filters · 8e068099
      Doug Szumski authored
      This moves the Nova Cells filters alongside the service filters
      for ease of testing.
      
      Partially Implements: blueprint support-nova-cells
      Change-Id: I32d35c065812c6b46c64bacdf283a0bdad0f8a0f
      8e068099
  13. Oct 16, 2019
    • Radosław Piliszek's avatar
      Implement IPv6 support in the control plane · bc053c09
      Radosław Piliszek authored
      Introduce kolla_address filter.
      Introduce put_address_in_context filter.
      
      Add AF config to vars.
      
      Address contexts:
      - raw (default): <ADDR>
      - memcache: inet6:[<ADDR>]
      - url: [<ADDR>]
      
      Other changes:
      
      globals.yml - mention just IP in comment
      
      prechecks/port_checks (api_intf) - kolla_address handles validation
      
      3x interface conditional (swift configs: replication/storage)
      
      2x interface variable definition with hostname
      (haproxy listens; api intf)
      
      1x interface variable definition with hostname with bifrost exclusion
      (baremetal pre-install /etc/hosts; api intf)
      
      neutron's ml2 'overlay_ip_version' set to 6 for IPv6 on tunnel network
      
      basic multinode source CI job for IPv6
      
      prechecks for rabbitmq and qdrouterd use proper NSS database now
      
      MariaDB Galera Cluster WSREP SST mariabackup workaround
      (socat and IPv6)
      
      Ceph naming workaround in CI
      TODO: probably needs documenting
      
      RabbitMQ IPv6-only proto_dist
      
      Ceph ms switch to IPv6 mode
      
      Remove neutron-server ml2_type_vxlan/vxlan_group setting
      as it is not used (let's avoid any confusion)
      and could break setups without proper multicast routing
      if it started working (also IPv4-only)
      
      haproxy upgrade checks for slaves based on ipv6 addresses
      
      TODO:
      
      ovs-dpdk grabs ipv4 network address (w/ prefix len / submask)
      not supported, invalid by default because neutron_external has no address
      No idea whether ovs-dpdk works at all atm.
      
      ml2 for xenapi
      Xen is not supported too well.
      This would require working with XenAPI facts.
      
      rp_filter setting
      This would require meddling with ip6tables (there is no sysctl param).
      By default nothing is dropped.
      Unlikely we really need it.
      
      ironic dnsmasq is configured IPv4-only
      dnsmasq needs DHCPv6 options and testing in vivo.
      
      KNOWN ISSUES (beyond us):
      
      One cannot use IPv6 address to reference the image for docker like we
      currently do, see: https://github.com/moby/moby/issues/39033
      (docker_registry; docker API 400 - invalid reference format)
      workaround: use hostname/FQDN
      
      RabbitMQ may fail to bind to IPv6 if hostname resolves also to IPv4.
      This is due to old RabbitMQ versions available in images.
      IPv4 is preferred by default and may fail in the IPv6-only scenario.
      This should be no problem in real life as IPv6-only is indeed IPv6-only.
      Also, when new RabbitMQ (3.7.16/3.8+) makes it into images, this will
      no longer be relevant as we supply all the necessary config.
      See: https://github.com/rabbitmq/rabbitmq-server/pull/1982
      
      For reliable runs, at least Ansible 2.8 is required (2.8.5 confirmed
      to work well). Older Ansible versions are known to miss IPv6 addresses
      in interface facts. This may affect redeploys, reconfigures and
      upgrades which run after VIP address is assigned.
      See: https://github.com/ansible/ansible/issues/63227
      
      Bifrost Train does not support IPv6 deployments.
      See: https://storyboard.openstack.org/#!/story/2006689
      
      
      
      Change-Id: Ia34e6916ea4f99e9522cd2ddde03a0a4776f7e2c
      Implements: blueprint ipv6-control-plane
      Signed-off-by: default avatarRadosław Piliszek <radoslaw.piliszek@gmail.com>
      bc053c09
  14. Sep 16, 2019
    • Mark Goddard's avatar
      Add custom filters for checking services · af2e7fd7
      Mark Goddard authored
      These filters can be used to capture a lot of the logic that we
      currently have in 'when' statements, about which services are enabled
      for a particular host.
      
      In order to use these filters, it is necessary to install the
      kolla_ansible python module, and not just the dependencies listed in
      requirements.txt. The CI test and quickstart install from source
      documentation has been updated accordingly.
      
      Ansible is not currently in OpenStack global requirements, so for unit
      tests we avoid a direct dependency on Ansible and provide fakes where
      necessary.
      
      Change-Id: Ib91cac3c28e2b5a834c9746b1d2236a309529556
      af2e7fd7
Loading