Revert "Allow setting any_errors_fatal true for gather-facts"
This reverts commit 5b431f0f. Reason for revert: the any_errors_fatal play parameter is not templated by Ansible (tested up to ansible-core 2.15.9). This behaviour is demonstrated in [1]. This means that "{{ kolla_ansible_setup_any_errors_fatal }}" is always interpreted as 'true', regardless of the value of kolla_ansible_setup_any_errors_fatal. This is particularly bad because the default value of kolla_ansible_setup_any_errors_fatal is false. We now have gather_facts_max_fail_percentage which can be set to 0 to provide the same functionality. [1] https://github.com/markgoddard/ansible-experiments/tree/master/15-fatal-errors Change-Id: I2e0ea49701b5900eae26434bcdb6b1bb44507ee7
Showing
- ansible/gather-facts.yml 0 additions, 2 deletionsansible/gather-facts.yml
- ansible/group_vars/all.yml 0 additions, 8 deletionsansible/group_vars/all.yml
- etc/kolla/globals.yml 0 additions, 8 deletionsetc/kolla/globals.yml
- releasenotes/notes/remove-any-errors-fatal-664fc2207074f0ef.yaml 14 additions, 0 deletions...notes/notes/remove-any-errors-fatal-664fc2207074f0ef.yaml
- tests/templates/globals-default.j2 0 additions, 4 deletionstests/templates/globals-default.j2
Loading
Please register or sign in to comment