Optimize reconfigure action for rally

Change-Id: I2fb2f4cd88638dfc5ccc261a0b113094cba60715
Partially-implements: blueprint better-reconfigure

ansible/roles/rally/defaults/main.yml

 ---
 project_name: "rally"
 
+rally_services:
+  rally:
+    container_name: "rally"
+    image: "{{ rally_image_full }}"
+    enabled: true
+    group: "rally"
+    volumes:
+      - "{{ node_config_directory }}/rally/:{{ container_config_directory }}/:ro"
+      - "/etc/localtime:/etc/localtime:ro"
+      - "kolla_logs:/var/log/kolla/"
+
 
 ########
 # Docker

ansible/roles/rally/handlers/main.yml

+- name: Restart rally container
+  vars:
+    service_name: "rally"
+    service: "{{ rally_services[service_name] }}"
+    config_json: "{{ rally_config_jsons.results|selectattr('item.key', 'equalto', service_name)|first }}"
+    rally_conf: "{{ rally_confs.results|selectattr('item.key', 'equalto', service_name)|first }}"
+    policy_json: "{{ rally_policy_jsons.results|selectattr('item.key', 'equalto', service_name)|first }}"
+    rally_container: "{{ check_rally_containers.results|selectattr('item.key', 'equalto', service_name)|first }}"
+  kolla_docker:
+    action: "recreate_or_restart_container"
+    common_options: "{{ docker_common_options }}"
+    name: "{{ service.container_name }}"
+    image: "{{ service.image }}"
+    privileged: "{{ service.privileged | default(False) }}"
+    volumes: "{{ service.volumes|reject('equalto', '')|list }}"
+  when:
+    - action != "config"
+    - inventory_hostname in groups[service.group]
+    - service.enabled | bool
+    - config_json.changed | bool
+      or rally_conf.changed | bool
+      or policy_json.changed | bool
+      or rally_container.changed | bool

ansible/roles/rally/tasks/bootstrap_service.yml

 ---
 - name: Running rally bootstrap container
+  vars:
+    rally: "{{ rally_services['rally'] }}"
   kolla_docker:
     action: "start_container"
     common_options: "{{ docker_common_options }}"
@@ -7,14 +9,11 @@
     environment:
       KOLLA_BOOTSTRAP:
       KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
-    image: "{{ rally_image_full }}"
+    image: "{{ rally.image }}"
     labels:
       BOOTSTRAP:
     name: "bootstrap_rally"
     restart_policy: "never"
-    volumes:
-      - "{{ node_config_directory }}/rally/:{{ container_config_directory }}/:ro"
-      - "/etc/localtime:/etc/localtime:ro"
-      - "kolla_logs:/var/log/kolla/"
+    volumes: "{{ rally.volumes }}"
   run_once: True
-  delegate_to: "{{ groups['rally'][0] }}"
+  delegate_to: "{{ groups[rally.group][0] }}"

ansible/roles/rally/tasks/config.yml

 ---
 - name: Ensuring config directories exist
   file:
-    path: "{{ node_config_directory }}/{{ item }}"
+    path: "{{ node_config_directory }}/{{ item.key }}"
     state: "directory"
     recurse: yes
-  with_items:
-    - "rally"
+  when: inventory_hostname in groups[item.value.group]
+  with_dict: "{{ rally_services }}"
 
 - name: Copying over config.json files for services
   template:
-    src: "{{ item }}.json.j2"
-    dest: "{{ node_config_directory }}/{{ item }}/config.json"
-  with_items:
-    - "rally"
+    src: "{{ item.key }}.json.j2"
+    dest: "{{ node_config_directory }}/{{ item.key }}/config.json"
+  register: rally_config_jsons
+  when:
+    - item.value.enabled | bool
+    - inventory_hostname in groups[item.value.group]
+  with_dict: "{{ rally_services }}"
+  notify:
+    - Restart rally container
 
 - name: Copying over rally.conf
   merge_configs:
     vars:
-      project_name: "rally"
+      service_name: "{{ item.key }}"
     sources:
       - "{{ role_path }}/templates/rally.conf.j2"
       - "{{ node_custom_config }}/rally.conf"
-    dest: "{{ node_config_directory }}/{{ item }}/rally.conf"
-  with_items:
-    - "rally"
+    dest: "{{ node_config_directory }}/{{ item.key }}/{{ item.key }}.conf"
+  register: rally_confs
+  when:
+    - item.value.enabled | bool
+    - inventory_hostname in groups[item.value.group]
+  with_dict: "{{ rally_services }}"
+  notify:
+    - Restart rally container
 
 - name: Check if policies shall be overwritten
   local_action: stat path="{{ node_custom_config }}/rally/policy.json"
@@ -32,6 +42,28 @@
 - name: Copying over existing policy.json
   template:
     src: "{{ node_custom_config }}/rally/policy.json"
-    dest: "{{ node_config_directory }}/rally/policy.json"
+    dest: "{{ node_config_directory }}/{{ item.key }}/policy.json"
+  register: rally_policy_jsons
+  when:
+    - rally_policy.stat.exists
+    - inventory_hostname in groups[item.value.group]
+    - item.value.enabled | bool
+  with_dict: "{{ rally_services }}"
+  notify:
+    - Restart rally container
+
+- name: Check rally containers
+  kolla_docker:
+    action: "compare_container"
+    common_options: "{{ docker_common_options }}"
+    name: "{{ item.value.container_name }}"
+    image: "{{ item.value.image }}"
+    volumes: "{{ item.value.volumes }}"
+  register: check_rally_containers
   when:
-    rally_policy.stat.exists
+    - action != "config"
+    - inventory_hostname in groups[item.value.group]
+    - item.value.enabled | bool
+  with_dict: "{{ rally_services }}"
+  notify:
+    - Restart rally container

ansible/roles/rally/tasks/deploy.yml

 ---
 - include: config.yml
+
 - include: bootstrap.yml
-- include: start.yml
+
+- name: Flush handlers
+  meta: flush_handlers

ansible/roles/rally/tasks/pull.yml

@@ -3,4 +3,8 @@
   kolla_docker:
     action: "pull_image"
     common_options: "{{ docker_common_options }}"
-    image: "{{ rally_image_full }}"
+    image: "{{ item.value.image }}"
+  when:
+    - inventory_hostname in groups[item.value.group]
+    - item.value.enabled | bool
+  with_dict: "{{ rally_services }}"

ansible/roles/rally/tasks/reconfigure.yml

 ---
-- name: Ensuring the containers up
-  kolla_docker:
-    name: "{{ item.name }}"
-    action: "get_container_state"
-  register: container_state
-  failed_when: container_state.Running == false
-  when: inventory_hostname in groups[item.group]
-  with_items:
-    - { name: rally, group: rally }
-
-- include: config.yml
-
-- name: Check the configs
-  command: docker exec {{ item.name }} /usr/local/bin/kolla_set_configs --check
-  changed_when: false
-  failed_when: false
-  register: check_results
-  when: inventory_hostname in groups[item.group]
-  with_items:
-    - { name: rally, group: rally }
-
-# NOTE(jeffrey4l): when config_strategy == 'COPY_ALWAYS'
-# and container env['KOLLA_CONFIG_STRATEGY'] == 'COPY_ONCE',
-# just remove the container and start again
-- name: Containers config strategy
-  kolla_docker:
-    name: "{{ item.name }}"
-    action: "get_container_env"
-  register: container_envs
-  when: inventory_hostname in groups[item.group]
-  with_items:
-    - { name: rally, group: rally }
-
-- name: Remove the containers
-  kolla_docker:
-    name: "{{ item[0]['name'] }}"
-    action: "remove_container"
-  register: remove_containers
-  when:
-    - config_strategy == "COPY_ONCE" or item[1]['KOLLA_CONFIG_STRATEGY'] == 'COPY_ONCE'
-    - item[2]['rc'] == 1
-    - inventory_hostname in groups[item[0]['group']]
-  with_together:
-    - [{ name: rally, group: rally }]
-    - "{{ container_envs.results }}"
-    - "{{ check_results.results }}"
-
-- include: start.yml
-  when: remove_containers.changed
-
-- name: Restart containers
-  kolla_docker:
-    name: "{{ item[0]['name'] }}"
-    action: "restart_container"
-  when:
-    - config_strategy == 'COPY_ALWAYS'
-    - item[1]['KOLLA_CONFIG_STRATEGY'] != 'COPY_ONCE'
-    - item[2]['rc'] == 1
-    - inventory_hostname in groups[item[0]['group']]
-  with_together:
-    - [{ name: rally, group: rally }]
-    - "{{ container_envs.results }}"
-    - "{{ check_results.results }}"
+- include: deploy.yml

ansible/roles/rally/tasks/start.yml

----
-- name: Starting rally container
-  kolla_docker:
-    action: "start_container"
-    common_options: "{{ docker_common_options }}"
-    image: "{{ rally_image_full }}"
-    name: "rally"
-    volumes:
-      - "{{ node_config_directory }}/rally/:{{ container_config_directory }}/:ro"
-      - "/etc/localtime:/etc/localtime:ro"
-      - "kolla_logs:/var/log/kolla/"

ansible/roles/rally/tasks/upgrade.yml

@@ -3,4 +3,5 @@
 
 - include: bootstrap_service.yml
 
-- include: start.yml
+- name: Flush handlers
+  meta: flush_handlers