Move cinder precheck into its own role

And remove the unnecessary blanks.

Change-Id: Id2b5f8119c446b36c91ec0e63246c90a60459e24
Partially-implements: blueprint condition-pre-check

ansible/roles/cinder/tasks/precheck.yml

 ---
+- name: Get container facts
+  kolla_container_facts:
+    name:
+      - cinder_api
+  register: container_facts
+
+- name: Checking free port for Cinder API
+  wait_for:
+    host: "{{ hostvars[inventory_hostname]['ansible_' + api_interface]['ipv4']['address'] }}"
+    port: "{{ cinder_api_port }}"
+    connect_timeout: 1
+    state: stopped
+  when:
+    - container_facts['cinder_api'] is not defined
+    - inventory_hostname in groups['cinder-api']

ansible/roles/haproxy/tasks/precheck.yml

@@ -25,6 +25,17 @@
     - "{{ 'barbican_api' not in haproxy_stat }}"
     - inventory_hostname in groups['haproxy']
 
+- name: Checking free port for Cinder API HAProxy
+  wait_for:
+    host: "{{ kolla_internal_vip_address }}"
+    port: "{{ cinder_api_port }}"
+    connect_timeout: 1
+    state: stopped
+  when:
+    - enable_cinder | bool
+    - "{{ 'cinder_api' not in haproxy_stat }}"
+    - inventory_hostname in groups['haproxy']
+
 - name: Checking free port for Cloudkitty API HAProxy
   wait_for:
     host: "{{ kolla_internal_vip_address }}"

ansible/roles/prechecks/tasks/port_checks.yml

@@ -93,26 +93,6 @@
     - enable_congress | bool
     - inventory_hostname in groups['haproxy']
 
-- name: Checking free port for Cinder API
-  wait_for:
-    host: "{{ hostvars[inventory_hostname]['ansible_' + api_interface]['ipv4']['address'] }}"
-    port: "{{ cinder_api_port }}"
-    connect_timeout: 1
-    state: stopped
-  when:
-    - enable_cinder | bool
-    - inventory_hostname in groups['cinder-api']
-
-- name: Checking free port for Cinder API HAProxy
-  wait_for:
-    host: "{{ kolla_internal_vip_address }}"
-    port: "{{ cinder_api_port }}"
-    connect_timeout: 1
-    state: stopped
-  when:
-    - enable_cinder | bool
-    - inventory_hostname in groups['haproxy']
-
 - name: Checking free port for Etcd Peer
   wait_for:
     host: "{{ hostvars[inventory_hostname]['ansible_' + api_interface]['ipv4']['address'] }}"