Skip to content
Snippets Groups Projects
Commit 6b283430 authored by Sam Yaple's avatar Sam Yaple
Browse files

Incorrect parsed variable name

database_user_create was not correctly referenced when parsing the
variable names. This could never actually lead to a situation that
reported a false change, but it could break an operation if you were
using the --step option with ansible and skipped the database create
task.

TrivialFix
Backport: Liberty

Change-Id: Idf69fffcc3814f509448ccea11b7d175f074ccf1
parent b8a90b4b
No related branches found
No related tags found
No related merge requests found
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
priv='{{ cinder_database_name }}.*:ALL' priv='{{ cinder_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
priv='{{ glance_database_name }}.*:ALL' priv='{{ glance_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
priv='{{ heat_database_name }}.*:ALL' priv='{{ heat_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
priv='{{ ironic_database_name }}.*:ALL' priv='{{ ironic_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
priv='{{ keystone_database_name }}.*:ALL' priv='{{ keystone_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -24,7 +24,7 @@ ...@@ -24,7 +24,7 @@
priv='{{ murano_database_name }}.*:ALL' priv='{{ murano_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
priv='{{ neutron_database_name }}.*:ALL' priv='{{ neutron_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
priv='{{ nova_database_name }}.*:ALL' priv='{{ nova_database_name }}.*:ALL'
append_privs='yes'" append_privs='yes'"
register: database_user_create register: database_user_create
changed_when: "{{ database.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}" changed_when: "{{ database_user_create.stdout.find('localhost | SUCCESS => ') != -1 and (database_user_create.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
failed_when: database_user_create.stdout.split()[2] != 'SUCCESS' failed_when: database_user_create.stdout.split()[2] != 'SUCCESS'
run_once: True run_once: True
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment