Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
K
Kolla Ansible
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Very Demiurge Very Mindful
Kolla Ansible
Commits
4d1b3e24
Commit
4d1b3e24
authored
8 years ago
by
Jenkins
Committed by
Gerrit Code Review
8 years ago
Browse files
Options
Downloads
Plain Diff
Merge "py3:Remove six.iterXXX"
parents
9d37b789
2fb98a6b
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
kolla/image/build.py
+1
-1
1 addition, 1 deletion
kolla/image/build.py
tests/test_build.py
+1
-3
1 addition, 3 deletions
tests/test_build.py
with
2 additions
and
4 deletions
kolla/image/build.py
+
1
−
1
View file @
4d1b3e24
...
@@ -861,7 +861,7 @@ class KollaWorker(object):
...
@@ -861,7 +861,7 @@ class KollaWorker(object):
return
return
def
list_children
(
images
,
ancestry
):
def
list_children
(
images
,
ancestry
):
children
=
six
.
next
(
six
.
itervalues
(
ancestry
))
children
=
six
.
next
(
ancestry
.
values
(
))
for
image
in
images
:
for
image
in
images
:
if
image
.
status
not
in
[
STATUS_MATCHED
]:
if
image
.
status
not
in
[
STATUS_MATCHED
]:
continue
continue
...
...
This diff is collapsed.
Click to expand it.
tests/test_build.py
+
1
−
3
View file @
4d1b3e24
...
@@ -18,7 +18,6 @@ from mock import patch
...
@@ -18,7 +18,6 @@ from mock import patch
from
oslo_log
import
fixture
as
log_fixture
from
oslo_log
import
fixture
as
log_fixture
from
oslo_log
import
log
as
logging
from
oslo_log
import
log
as
logging
from
oslotest
import
base
from
oslotest
import
base
import
six
import
testtools
import
testtools
sys
.
path
.
append
(
sys
.
path
.
append
(
...
@@ -28,7 +27,6 @@ from kolla.image import build
...
@@ -28,7 +27,6 @@ from kolla.image import build
LOG
=
logging
.
getLogger
(
__name__
)
LOG
=
logging
.
getLogger
(
__name__
)
@six.add_metaclass
(
abc
.
ABCMeta
)
class
BuildTest
(
object
):
class
BuildTest
(
object
):
excluded_images
=
abc
.
abstractproperty
()
excluded_images
=
abc
.
abstractproperty
()
...
@@ -46,7 +44,7 @@ class BuildTest(object):
...
@@ -46,7 +44,7 @@ class BuildTest(object):
bad_results
,
good_results
,
unmatched_results
=
build
.
run_build
()
bad_results
,
good_results
,
unmatched_results
=
build
.
run_build
()
failures
=
0
failures
=
0
for
image
,
result
in
six
.
iteritems
(
bad_results
):
for
image
,
result
in
bad_results
.
items
(
):
if
image
in
self
.
excluded_images
:
if
image
in
self
.
excluded_images
:
if
result
is
'
error
'
:
if
result
is
'
error
'
:
continue
continue
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment