This allows use of repositories and proxies protected with HTTP basic
authentication.

Change-Id: I0ec4ec3e9d60bb1431b44dd6718415214ad80025

These are currently not included in the regex we generate so aren't
built as part of the complete set.

Change-Id: I4f79b1b0887df72b11b768593ba45d89e75ce0d6
Closes-Bug: #2052428

Initial fix [1] was not reloading NetworkManager config, which caused
MichaelRigart.interfaces role to clean up resolv.conf after interface
bounce.

[1] https://review.opendev.org/c/openstack/kayobe/+/902561
Related-Bug: #2044537

Change-Id: I5644ab2595a30cfff82f03d5ca4aa501a8b36ef8

This has now been removed from upstream docker-ce packages.

```
the devicemapper storage-driver has been deprecated and removed
```

and has shown deprecation warnings for some time.

This change also includes some fixes necessary for CI to pass:

* update the Zuul previous_release variable to 2023.2

Closes-Bug: #2051233
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/906858
Change-Id: I263f59ea77e39accffe4febe0d47e56b35d9800e

Prompts the user to confirm before deprovisioning any overcloud hosts.
The user is given a list of hosts which will be deprovisioned. Automatic
confirmation can be achieved by setting ``confirm_deprovison`` to
``yes``.

Change-Id: I6eea5bb7c268912e6f39627f64c92715877311a3

When ``resolv_is_managed`` is set, Kayobe templates resolv.conf. This
patch stops NetworkManager from overriding these changes.

Closes-Bug: #2044537
Change-Id: I90b61dfe03d53c58327d2b15e70b7b8489bdfb47

This reverts commit 99f5b649.

Reason for revert: 2023.2 has been branched and released

Change-Id: I38fc5dcadda5103d63a11022825e8e167408677d

The latest Rocky-9-GenericCloud image does not include the git package.

Change-Id: I47a54b822d45ab5e1e64fa5e0f8111c0edadcb36

Fix a logic issue when seed SNAT is not enabled. In this circumstance
Bifrost was generating ConfigDrive data with the default gateway unset
even when one is available on the admin network. This regression was
introduced in Ib847d3420dee374cec067cd8af519b510be04120 [1].

[1] https://review.opendev.org/c/openstack/kayobe/+/898434

Closes-Bug: #2045926
Change-Id: Ifd9f9cd389ac09448fc91dba74f8f09595698b55

We no longer use these variables since we switched to the kolla Ansible
collection.

TrivialFix

Change-Id: I50238dd694edc7ee02be4bfdc56ebf3a603e05d2

Switch all dependencies to use the OpenStack 2023.2 release.

This commit should be reverted on the master branch once the
Kayobe stable/2023.2 branch has been cut and RC1 released.

Change-Id: I749a1ac30fa15cf7faa456fcb90c4ddbbef77cc9

Change-Id: I5cd9dacea10f0e00b3d481704f0949b6f5c4a69e

This variable was configuring enable_host_ntp in kolla-ansible, which
was removed in the Xena release.

Change-Id: I737598d3bbe40b933b4b727eccc3b2a76ed97cdb

Adds support for configuring vGPUs on NVIDIA hardware.

Closes-Bug: #2028843
Change-Id: I4c8481f7429dbf50d51e26bd7acee24e16ee6c79

The docker Python package was dropped from kolla requirements [1], but
we still need to install it to build container images.

[1] https://review.opendev.org/c/openstack/kolla/+/896644

Change-Id: I241884497f4fb707385eb12d5fcc187ed839f754

This fix was added when upgrading from CentOS Linux 8.2 to 8.3. This is
likely not required on currently supported operating systems.

Change-Id: Ic2c47ae4514d98ff18c5d17ba62b50c47f3929c1

Change-Id: I73fad29af6a57b29afea46947d1ae90546253a2a

I missed this when I refactored the code to fallback
to templating. We need to deduplicate before picking
the strategy for the fallback to work for symlinked files.

Change-Id: Iddd6c90a6daa41e1d1cdaa6b598491792c13394d
Closes-Bug: #2042689

Change-Id: I2577245440d510ab19f48915479a8e3575b996b7

Updating requirements.yml with latest os-networks role

Following up:
Ia3550644e5fc3e83f792e46d42b4c35d5eec4705

Change-Id: I9cb1b4c5329dc9db8562cf317616101d35f13edb

This is a backwards compatability improvement, since it was previously
permitted to have a config file that templated to invalid yaml/ini.

Change-Id: I53a0894cc64e83c7342a82ad987b7e5a4696ece2
Closes-Bug: #2042690

This change bumps up the maximum supported version of Ansible to 8.x
(ansible-core 2.15.x) and minimum to 7.x (ansible-core 2.14.x).

Depends on:
https://github.com/stackhpc/ansible-role-systemd-networkd/pull/10

https://github.com/stackhpc/ansible-role-dell-powerconnect-switch/pull/13

https://github.com/stackhpc/ansible-role-mellanox-switch/pull/8

gateway_ip was being set to empty string. This was triggering neutron
""Invalid input for gateway_ip. Reason: '' is not a valid IP address."
Omitting by default.

Installing openstack.cloud collection.
Upgrade failed as Ansible in kayobe-venv was not upgraded.

Change-Id: Ia3550644e5fc3e83f792e46d42b4c35d5eec4705

Setting network mode to host.
Enables testing without additional configuration of the host.

Change-Id: I46406d414290ed785a4644c88cbc76ff074e96a2

This can result in duplicated configuration options.

Change-Id: I4dd6ffae027345b8c1cc217a63e85f8af7fc9746
Closes-Bug: #2042689

I8bf75ce44b9ec1fdd477fcddf2deebf2929d9fc1 added a workaround to remove
incorrectly named DNF repository files.

This workaround has been in place since the Antelope release and can now
be removed.

Change-Id: I7ba61ffa8aaabcedf1c5249e5f39f39257410f9a

Ie59f0c729381e5bea112ab7f5d0c738a9488b772 changed the provision-net and
cleaning-net to be non-shared when they are VLAN networks. It also
added some transitional tasks to modify existing VLAN networks to unset
the shared property.

This change removes the transitional code since it has been in place for
over 3 years.

This change also slightly refactors the code to use only a 'tasks' list.

Change-Id: I6d358502d37e6a2d0098ad4733840613e93b4279

Match ML2/OVS agents only when OVN is not enabled.

Change-Id: Ia2ba7414202de6750b18ada47e7a5bb0b636e7b3

We no longer support EL8 or network-scripts.

Debian systems never used this role, so also removing those tasks.

Change-Id: I17b93c75a1ff8eb8d636247696f4a1709ca486d5

Currently only supported on Dell OS9 and OS10 switches, and provides no
CLI integration.

Change-Id: Ia9242ed823868cba3a27fb9344a3b01283528d87

Kayobe has fairly coarse-grained default groups - controller, compute,
etc, which work well in the majority of cases. Kolla Ansible allows much
more fine-grained placement on a per-service basis, e.g.
ironic-conductor. If the operator has taken advantage of this
fine-grained placement, then it is possible that some of the assumptions
in Kayobe may be incorrect. This is one downside of the split between
Kayobe and Kolla Ansible.

For example, Ironic conductor services may have been moved to a subset
of the top level 'controllers' group. In this case, we would not want
the Ironic networks to be mapped to all hosts in the controllers group -
only those running Ironic conductor services. The same argument can be
made if the loadbalancer services (HAProxy & keepalived) or Neutron
dataplane services (e.g. L3 & DHCP agents) have been separated from the
top level 'network' group.

This change abstracts the placement of Ironic conductor Ironic
inspector, loadbalancer and network services into separate variables,
rather than referencing the top level 'controllers' and 'network' groups
directly. These variables may be updated by the operator to match the
service placement.

Change-Id: Idbf181c795ee98ad653f11ae483f9dab4ef1b599

Fixes an issue when user forgot to combine
'kolla_ansible_custom_passwords',
'kolla_ansible_default_custom_passwords' and own dictionary with
custom passwords in configuration files. Now
'kolla_ansible_extra_custom_passwords' should provide only user
custom passwords to add or override in the passwords.yml.

Change-Id: I4813a1f6ab9cb566596e806bd0ada6dff342d119
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>

Kolla Ansible renamed kolla_internal_fqdn_cacert to
kolla_admin_openrc_cacert in Victoria, after which we no longer set the
variable correctly in globals.yml. This would lead to a missing
OS_CACERT in admin-openrc.sh and public-openrc.sh.

This change fixes the issue by renaming the relevant Kayobe variables to
match and passing through the correct variable. Backwards compatibility
is provided until the end of the deprecation period.

kolla_public_openrc_cacert -> kolla_external_fqdn_cacert
kolla_admin_openrc_cacert -> kolla_internal_fqdn_cacert

Story: 2010486
Task: 47054

Change-Id: I9e1cc20579cf80525d6ef732a1aac99a65bc171b
Co-Authored-By: Maksim Malchuk <maksim.malchuk@gmail.com>

Support for Dell OS 10 was added in Networking Generic Switch in the
2023.1 release[1].

[1] https://review.opendev.org/c/openstack/networking-generic-switch/+/860067

Change-Id: Id3cd5e081dd5c40897ddaada65cfb184d56345b6

Change-Id: I12ad980ef6d30ea98966c0f4eaf047e8d57a40e7
Closes-Bug: #2039558

This variable is not supported since
I61a61ca59652b13687c2247d5881012b51f666a7, but was not removed from
etc/kayobe/kolla.yml in that change.

This change also adds the replacement variable docker_registry_insecure
to etc/kayobe/docker.yml.

TrivialFix
Change-Id: I3fa96f0276e08a6678e5d743399d01bc19a8dd1b

We are seeing an issue on Rocky Linux 9 where VLAN interfaces on bridges
have their MTU set to MTU-1 after rebooting. This is likely related to
how MTU is set by NetworkManager for bridges: it first sets the MTU to
MTU-1 before setting it to the correct value [1].

We can work around this issue by not explicitly setting the MTU
configuration on the VLAN interface if it is the same as the parent
bridge. It will be automatically inherited from the parent.

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/864872e9a8c694ee7472154bf45f869040310b71

Closes-Bug: #2039947
Change-Id: I23366f4de7842e7c2fe40e431fac76f26e9892de

Follow on to Ie17ef9ce1147cbaec2e42db932c7d59293b49b1b

Adds seed_deploy_containers_registry_attempt_login variable to seed.yml,
which acts as a redirection of deploy_containers_registry_attempt_login
so that the variable is more descriptive, declared in a better location,
and extensible to other groups

Change-Id: I86d8f13062ff8e664919cd5d63bc17bdafb32e0c

Stop configuring the seed host as gateway when seed SNAT is disabled
(which is the default since Xena), otherwise overcloud hosts may take a
long time to gather facts until their network configuration is applied
(probably because DNS servers are thought to be reachable until the
gateway is changed or removed).

Closes-Bug: #2039461
Change-Id: Ib847d3420dee374cec067cd8af519b510be04120

Change-Id: I7ef0c5240585bfdc27fbdf6b32edd5b51ce2d147

Back in the Ussuri release, we changed the Bifrost kernel location to
use ipa.kernel instead of ipa.vmlinuz. While this works fine for newly
discovered nodes, any node added to Bifrost in Train or earlier will
have kept ipa.vmlinuz as its deploy kernel.

This can cause issues since upgrading Bifrost or building new deployment
images will update ipa.kernel, but not ipa.vmlinuz, resulting in nodes
booting with an old kernel and a new ramdisk.

Fix by adding a new rule updating the legacy kernel location and
documenting how to update node information.

Change-Id: I6ae44dcae78424b4638762d015cf24336444707f