Change-Id: If7d6e58b19f98ccb7cc4c209e458cb6f4f4765ad

The chrony container removal was performed in the Xena cycle, so we no
longer require this task in the 'overcloud host configure' command.

Change-Id: I86fcc75e844eb922f62c90c45a105519845cc1a7

Also synchronise Ansible settings between Kayobe and Kolla Ansible.

Change-Id: Idaea4a984391a8cd05a5b0eee254ac6bad531a3e

This reverts commit f00a65ea.

Reason for revert: fix for kolla-ansible installation with
openstack.kolla has merged.

Change-Id: I361c68904eb66e9728b4a902a0998e4bc06d2dcd

This change uses the new Galaxy requirements file in Kolla Ansible to
install the openstack.kolla collection.

Cross-project dependencies on ansible-collection-kolla are supported.

Story: 2009854
Task: 44504

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/819430
Change-Id: Iac185dd2bbbca128c6cf71b2734e94b3e1c6133b

This patch adds the openstack.kolla collection to the Galaxy
requirements. It is installed from the OpenDev git repository. The
collection is not yet used by Kayobe.

Zuul cross-project dependencies on the ansible-collection-kolla
repository are supported (and used in this commit).

Story: 2009854
Task: 44503

Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/820165/
Change-Id: I91cbac839f816a00ac54bc4a350f44b5ae457cc3

Ansible failure handling is different when executing multiple top-level
playbooks (CLI arguments) vs. multiple plays within a top-level
playbook. If any hosts have failed or are unreachable at the end of a
top-level playbook, then ansible-playbook exits non-zero.

In contrast, execution will continue at the end of a mid-playbook play
if there are hosts that have not failed or become unreachable. This is
documented in [1].

Currently, Kayobe executes multiple top-level playbooks, most notably in
the host configure commands where there is a long list of them. This has
implications when working at scale, where failures are more common. If a
host fails at any point, then execution of the command will stop at the
end of the current playbook. This means that the command must be run
again for all hosts. Additionally, if any hosts are unreachable, then
the command is unable to progress at all without removing them from the
inventory.

This change refactors the host configure and host upgrade commands to
use a single top-level playbook.

[1] https://github.com/markgoddard/ansible-experiments/tree/master/14-error-handling

Story: 2009854
Task: 44482

Change-Id: Ia63d66097b10b6ddda30ad693636143f8b1a85e0

Drop Kayobe jobs until we support installing kolla-ansible with
openstack.kolla collection
(Iac185dd2bbbca128c6cf71b2734e94b3e1c6133b).

Change-Id: Ia6cc7e2f7a9a9fb0a1c3e0fdf07e7cdd1cbd431c

We keep hitting the OOM killer in the TLS job, and the switch to UEFI
mode in bare metal testing seems like the most likely culprit.

This change keeps in place most of the changes of
Id1b4e9775c834b8b97e086241ee8b247977225a2, but removes the override of
ironic_boot_mode in the TLS job.

Change-Id: Id35894be893183b0b84e6dacb81e1b72e4a828f9

Story: 2007872
Task: 44139

Change-Id: I1a161a4f241cccac3f39ab7a3e11bccac02f9a07
Co-Authored-By: Pierre Riteau <pierre@stackhpc.com>

* Cinder ZFSSA backend was dropped in Xena
* iscsid is no longer required for Ironic since the Ironic iscsi deploy
  interface was removed in Xena

Change-Id: Ia9ade04b1aa9ad102e637d2ddf638b28b2d11305

Previously we were seeing issues with ipmitool and virtualbmc on Ubuntu:

  Error setting Chassis Boot Parameter 5\nError setting Chassis Boot Parameter 0

The dependent change fixes these issues, and this change enables bare
metal testing in Ubuntu CI.

Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/829006

Change-Id: I96827fc32c1594ca9a0535e259929c49d3f0e704

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/826723
Change-Id: I52ffa0b23ce2ae54fbfe5879a25b128ca1864195

Change-Id: Idd53d689e0e9baad571b2f0f4005f3efa3e21830

This fixes a bug that caused the role to fail on NVMe only hosts.

Change-Id: I697e83fbc6b1bd044b0e7e42e7c3c6c7468ccfb2

Set the Ironic boot mode to legacy BIOS explicitly in Tenks config in
anticipation of an upcoming change to the default boot mode.

Override the boot mode to UEFI in the overcloud TLS job to improve
coverage. This requires enabling iPXE booting.

Depends-On: https://review.opendev.org/c/openstack/tenks/+/827479/

Change-Id: Id1b4e9775c834b8b97e086241ee8b247977225a2

The ntp role attempts to mask NTP services that may conflict with
chrony. Currently we are seeing the following failure:

    TASK ntp : Mask alternative NTP clients to prevent conflicts
    Could not find the requested service systemd-timesyncd.service: host

The service_facts module shows that the service is not found:

    "systemd-timesyncd.service": {
        "name": "systemd-timesyncd.service",
        "source": "systemd",
        "state": "stopped",
        "status": "not-found"
    },

According to the Internet, this can happen if there are After/Before
dependencies in one service on another that does not exist.

This change fixes the handling of these not-found services to avoid the
error.

Story: 2009821
Task: 44401

Depends-On: https://review.opendev.org/c/openstack/kayobe/+/827404

Change-Id: I4b8a42704f2b0a145ee9dec433d91df67628cd9d

Currently we use the HEAD reference for OpenStack requirements. This can
create images that are incompatible with your version of OpenStack.

See:
https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/688911

Change-Id: I42026fafb1be0071f5ec94e81881c4a3bdd34af8
Story: 2009810
Task: 44371

This change bumps up the maximum supported Ansible version to 5.x
(ansible-core 2.12.x) and minimum to 4.x. This synchronises Kayobe with
Kolla Ansible (see change Ia373f9cc3bb69eba0288bbb3e497e8cadb7cc4d3).

ansible 5 / ansible-core 2.12 raises the minimum version of Python to
3.8, so CentOS Stream 8 environments will typically get ansible 4 /
ansible-core 2.11.

Change-Id: If4477e7fa4c022ead6cda4a34a72b342f115936f

Variable untemplated_dirs has been added to allow for
defining directories under kayobe/kolla/config which should be copied
instead of templated by kolla-openstack role.

This is needed to support custom themes for horizon -
change If9982c8e18be31772cb031ef72b7eebd4d768be5

Change-Id: I350f58c8a82f0f31608b34054e804c5c198d6806

This playbook is no longer necessary following the removal of the iSCSI
deploy driver from Ironic.

Change-Id: I9e99c04173acb7adb0d0e367b6db388b86baf5f2