Diskimage builder supports specifying a list of packages to install via
-p. We currently support this for the root image, but not IPA images.

This change adds a new configuration option, 'ipa_build_dib_packages',
that should be a list of additional packages to install in locally built
IPA images. This affects the following commands:

kayobe seed deployment image build
kayobe overcloud deployment image build

This depends on
https://github.com/stackhpc/ansible-role-os-images/pull/25.

Also adds an example to the documentation for the equivalent option for
root image.

Change-Id: I04191d9541894b6a264e966c9ecb1056e0edade4
Story: 2006855
Task: 37446

Depends-On: https://review.opendev.org/690559/

Change-Id: I4e766424607317e5817d26461f7a1e180e9b2146
Story: 2004337
Task: 37378
Task: 37381

As per the kolla_sources documentation:
https://docs.openstack.org/kayobe/latest/configuration/kolla.html#source-code-locations

Change-Id: I39b59e3fed94d4fc56514c98ae1d9d1c0ad6bebc

If ironic_serial_console_autoenable is set to true, ironic compute node
serial consoles are automatically enabled during kayobe overcloud post
configure. However, the baremetal-compute-serial-console.yml playbook
expects a variable called cmd to be defined, and set to 'enable' in
order to enable serial consoles. This patch fixes the issue.

We also add a conditional to only import the playbook when ironic is
enabled in the overcloud.

Change-Id: Ice26a113f9023b1a25a4af0552d07c5e95e64556
Story: 2006662
Task: 36924

Not setting cpu-mode will reduce the number of TCG emulated features.
Hopefully this will make CI more reliable.

Change-Id: I24a8832c02db6ba019ab8f5c2b9d7216a9b7d213

The is one of community goals that each project should produce a
single PDF file. The pdf should be in the output of openstack-tox-docs
job.

TeX packages are required to build PDF locally, following is
recommended:

* inkscape
* texlive-latex-base
* texlive-latex-extra
* texlive-fonts-recommended

More about the goal:
https://governance.openstack.org/tc/goals/train/pdf-doc-generation.html
https://etherpad.openstack.org/p/train-pdf-support-goal
https://etherpad.openstack.org/p/pdf-goal-train-common-problems

Change-Id: Ib8a238f5ad4329527147be72331b87f57877f68e

This is a new group, added to kolla ansible for multiple nova cells
support.

Depends-On: https://review.opendev.org/675659
Depends-On: https://review.opendev.org/688697

Change-Id: I65e0175402441ba6422f12ebd4baa06640b9181b
Story: 2004291
Task: 37132

This is to resolve the following issue in CI:

    c/_cffi_backend.c:15:17: fatal error: ffi.h: No such file or directory
     #include <ffi.h>
                     ^
    compilation terminated.
    error: command 'gcc' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/zuul/kayobe-venv/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-PV3WhJ/cffi/setup.py'"'"'; __file__='"'"'/tmp/pip-install-PV3WhJ/cffi/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-ZvlZVY/install-record.txt --single-version-externally-managed --compile --install-headers /home/zuul/kayobe-venv/include/site/python2.7/cffi Check the logs for full command output.

Change-Id: I1bd724be7dc77058870f37cb1c9404472fa466ca
see: https://zuul.opendev.org/t/openstack/build/c20a316a699b4073abf75960634ebfcd

Docker sometimes fails to reply if it has just been started.

Change-Id: I5ae37b8f264437a9e49b09da459e604191f9ed3e
Story: 2006718
Task: 37089

TASK [image-download : Ensure the image is downloaded] *************************
task path: /home/zuul/kayobe-venv/share/kayobe/ansible/roles/image-download/tasks/main.yml:19
fatal: [localhost]: FAILED! => {
    "msg": "The field 'vars' has an invalid value, which includes an undefined variable. The error was: 'dict object' has no attribute 'content'\n\nThe error appears to have been in '/home/zuul/kayobe-venv/share/kayobe/ansible/roles/image-download/tasks/main.yml': line 19, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Ensure the image is downloaded\n      ^ here\n"
}
	to retry, use: --limit @/home/zuul/kayobe-venv/share/kayobe/ansible/kolla-openstack.retry

PLAY RECAP *********************************************************************
controller0                : ok=3    changed=0    unreachable=0    failed=0
localhost                  : ok=6    changed=2    unreachable=0    failed=1

Change-Id: I45fb193b423c7e874aa70cd5f0252e0b0f4e2f05
Story: 2006715
Task: 37086

Please see: https://docs.openstack.org/ironic/latest/configuration/sample-config.html

Change-Id: Idc96523a5108712a072b14889b1fba0f05c381e8
Story: 2006707
Task: 37067

Change-Id: I3caa80da7c44704a3b6559d98f928d95e83289e5
Story: #2006212
Task: #35802

See https://github.com/sphinx-doc/sphinx/issues/6440 for upstream details

Change-Id: Ia2c3c6f3d38474465fc012bc4b798a5da0d3aadb

In an environment where ironic is disabled, but IPA images are built
locally for the seed, the following task will fail in a number of
commands, e.g. kayobe overcloud service deploy:

Validate the presence of locally built Ironic Python Agent (IPA) images

We need to only execute this task when ironic is enabled.

Change-Id: I61067164a003bcdf6079cdaca36f0e1755186f60
Story: 2006669
Task: 36935

For more detail, see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006478.html

Change-Id: I90662a9816c4f4af5a4a481d0e815bf6a398f8d3

Change-Id: Id8cf5f8e50af438e2d8f0077225c38175e38b662
Story: 2002046
Task: 19692

Docker CE has added a default DROP policy to the FORWARD chain.  When
nova-compute runs on the controller, kolla ansible sets the
net.bridge.bridge-nf-call-iptables sysctl to 1, which causes iptables to
process frames forwarded across bridges.

Currently, the kayobe-overcloud-centos job is failing quite frequently
with timeouts when deploying bare metal compute. Experimentation with
iptables hasn't revealed why this only happens sometimes, or exactly
what traffic is being blocked, but opening up the firewall does seem to
fix the issue. We won't see this in production since control and compute
services are on separate hosts.

This change updates the iptables configuration used in CI to forward all
frames on the bridge, breth1.

Change-Id: If96437b73b9b5c58600ba1b004f53ee0c1f14398
Story: 2006534
Task: 36590

Change-Id: Icd99fa0a262d7f42346cfcfc5013cf7c91c34459

Depends-On: https://review.opendev.org/669298
Change-Id: Ia4138179132d3a284b0c4bcc882b87bde22c9cc4

Update .git review and zuul configuration.

Change-Id: I8efee18cf28344a6af44acbe1ca1d4470f7258fe

Change-Id: I6f56ba2d6e3c5e5f91e83bd12d8a09c04845cd62

This controls which release we are upgrading from.

Change-Id: I76f0db99cbfc0dea8cf16f0db370c8865e7dae03

We don't need to provide additional quotes for passing these arguments
to playbooks, since this is now done automatically via
kayobe.utils.quote_and_escape.

Change-Id: I9588b58449e8c8f8eab85ce01b4e130adc150ac6
Story: 2006475
Task: 36416