The centos binary images now include nova 23.0.0 packages.

Change-Id: I0c7d57231a63e1f9ff3fdcdef1be7fff57160e08

Switch all dependencies to use the OpenStack Wallaby release.

This commit should be reverted on the master branch once the
Kayobe stable/wallaby branch has been cut and RC1 released.

Change-Id: I977943e81a79e4a40cca04d80d786ca49afd3d39

An initial version of the mrlesmithjr.mdadm role was released 2 days
ago. There are only minimal changes compared to the commit we were
using. This should avoid the following issue seen in CI:

[WARNING]: - mrlesmithjr.mdadm was NOT installed successfully: - the specified
version (5be3ee7d330aa17317897bd104dc87ff0df11915) of mrlesmithjr.mdadm was not
found in the list of available versions ([{'id': 152374, 'url': '', 'related':
{}, 'summary_fields': {}, 'created': '2021-04-24T02:51:30.453954Z', 'modified':
'2021-04-24T02:51:30.453980Z', 'name': 'v0.1.0', 'version': '0.1.0',
'commit_date': '2021-04-23T22:50:00-04:00', 'commit_sha':
'b8a9853b7eafa9afc62bbb7728f64fd5dc9f54de', 'download_url':
'https://github.com/mrlesmithjr/ansible-mdadm/archive/v0.1.0.tar.gz', 'active':
None}]).
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

Change-Id: I3d85b341cf541cfb9b486021e66b316833fe9130

Cleaning was disabled by default in Bifrost
(Ie1198768889bd468176cd68c8ccb48791c724262) until the Victoria release,
when the default was changed. The 'kayobe overcloud provision' command
does not handle cleaning states when moving nodes from manageable to
available. This can lead to provisioning failures.

This change disables cleaning to maintain backwards
compatibility with earlier versions of Kayobe.

Change-Id: I23eb5116d8d1944167a0d50cafe5b99f766ad687
Story: 2008850
Task: 42363

Warn in the documentation that it is an experimental feature.

Change-Id: I46ea01ef9a3f6e322489e6d2a28f99d05656e0f2

If we try to create a new environment from a shared configuration inside
the same repository, we can produce an infinite loop by copying the
environment into itself. Ignore any existing environments directory
during environment creation.

Change-Id: Ic9d3d03192f515a055e41351a0bf25da7a7b0684
Story: 2002009
Task: 40038

Based on the discussions from recent Kolla meetings [1][2][3],
we established that, to avoid the DockerHub pull limit issues
in our CI, we will try using quay.io.

The images have already been published via Kolla CI
for master/Wallaby [4] and Victoria [5].

This change applies only to CI.
The user-facing move is yet to be discussed.

[1] http://eavesdrop.openstack.org/meetings/kolla/2021/kolla.2021-03-17-15.00.log.html#l-102
[2] http://eavesdrop.openstack.org/meetings/kolla/2021/kolla.2021-03-24-15.00.log.html#l-137
[3] http://eavesdrop.openstack.org/meetings/kolla/2021/kolla.2021-03-31-15.01.log.html#l-50
[4] https://review.opendev.org/c/openstack/kolla/+/781130
[5] https://review.opendev.org/c/openstack/kolla/+/781899

See related Kolla Ansible change
I22e11a994801447526ac26fc2815a1679876225e

Change-Id: Id6690dc9a486af0ed7d42555d84cf77d6de0b6af

This change adds support for policy-based routing via systemd-networkd.
Due to differences in the configuration mechanism, routing policy
rules are configured via dicts for Ubuntu, while remaining as strings
on CentOS. Ideally we would support both formats.

Story: 2004960
Task: 42217

Change-Id: I77aec0160eb7e4dd763326bfe6e3d9a44b248108

This change adds support for network configuration via systemd-networkd
on Ubuntu systems.

This is implemented via an Ansible Galaxy role,
stackhpc.systemd_networkd which was forked from
aruhier.systemd_networkd. Several improvements were made in
https://github.com/stackhpc/ansible-role-systemd-networkd/pull/1,
including:

* Add support for removing unexpected config files
* Use become where necessary
* Refactor config generation into a single task to improve performance

The systemd_networkd role does not add much abstraction on top of the
systemd-networkd configuration file format, which provides a lot of
flexibility at the expense of additional code in Kayobe. This code is
implemented as filter plugins, similarly to the existing
MichaelRigart.interfaces role.

This patch includes support for:

* Ethernet interfaces
* bridges
* bonds
* VLANs
* virtual Ethernet pairs (to connect Linux bridges and OVS bridges)
* static IP addresses
* static routes
* MTU

Some network attributes are currently not supported for
systemd-networkd:

* rules
* route options
* ethtool_opts
* zone
* allowed addresses

Story: 2004960
Task: 41881

Change-Id: I248b5bb9ce5a80a07a2a311cb3aca6daca920720

Change-Id: Idf5419d9020d491c310d2c09c495b0a420578214

Timezone configuration is using time.yml since the Ussuri release.

Change-Id: I8f99adf19d192db318e8d76d611c3a15adc9ef08

All instances of 'kayobe control host bootstrap' in the development
scripts use a helper function, except for during seed_hypervisor_deploy.
The helper adds a retry mechanism to combat flakiness often seen during
Ansible Galaxy installs.

This change fixes the issue.

TrivialFix

Change-Id: I954cb604a18874744b3673ebf2e2c29caa18ce8f

Change-Id: Ie74b1ee61d4cfa19ea710153694349c7ea61d78e
Story: 2002009
Task: 40039

The network.yml playbook is reduced in complexity, now performing
validation before including a role specific to the OS family of the host
(network-redhat or network-debian). This will allow the network
configuration to diverge between OS families without adding excessive
conditionals.  Currently the content of the roles is identical.

Story: 2004960

Change-Id: Iaa69e5303e554e6b30a23a3e84e36d09972888c9

Change-Id: I8d3d51ea25459f1831ac75a062cd8e7c54204de4
Story: 2008795
Task: 42216

This change switches CentOS CI jobs to use CentOS stream 8 nodepool
images. Kolla containers switched to CentOS stream already.

Depends-On: https://review.opendev.org/c/openstack/kayobe/+/784926
Depends-On: https://review.opendev.org/c/openstack/kayobe/+/784853

Story: 2008795
Task: 42196

Change-Id: I02c76344bcb0b350fd96010becca52f259e1ee6f

A bug has been introduced to the which package in CentOS Stream 8 which
causes it to fail when used with the following bash options:

set -u
set -o pipefail

Then, when running which we see the following output:

environment: line 1: _declare: unbound variable

As found by Pierre, this seems to be caused by the implementation of
which as a bash function which references an unbound variable
(_declare). It's tracked in Fedora by
https://bugzilla.redhat.com/show_bug.cgi?id=1944877#

.

This change works around the issue by using the /usr/bin/which binary.

Co-Authored-By: Pierre Riteau <pierre@stackhpc.com>

Change-Id: I468d4e0460c13791b9f01d5854ef45472528c6fe
Story: 2008795
Task: 42215

When running kolla-ansible using a Kayobe environment, write the
environment name to $KOLLA_CONFIG_PATH/.environment. In later
executions, check that the environment name is the same. Warn user to
clean up $KOLLA_CONFIG_PATH otherwise.

Change-Id: Ibbb1fdcad4034620ff8fbfe184d803bcc86f53f9
Story: 2002009
Task: 42185

Passing the Kayobe or Kolla Ansible inventories as comma-separated host
list was never supported since we check that inventory directories
exist.

Also fix the check for the Kolla Ansible inventory directory, which was
using the wrong variable (parsed_args.kolla_venv).

Change-Id: I215f927d8249aadd9cc7bb44893e0bdf5f26510a

When inventory arguments are not passed but an environment is specified,
detect if there are inventory directories present in the shared Kayobe
configuration directory and in the environment directory. Using
os.path.exists() is sufficient because we validate these paths later
with utils.is_readable_dir().

Change-Id: Ieb2b7ff07cd43029399e9e19002b82940246f8c4
Story: 2002009
Task: 41739

Change-Id: I875d73cfe056dc505beffdec9bf348b3dc8bd910
Story: 2002009
Task: 41738

Change-Id: I2f33bda5f2f84bbbb0f40240d2575a0b69ddceea
Story: 2002009
Task: 40038