From fa96fd1a2f85c8286467ba11d0177df638550e8a Mon Sep 17 00:00:00 2001
From: Mark Goddard <mark@stackhpc.com>
Date: Mon, 31 Oct 2022 09:40:40 +0000
Subject: [PATCH] Fix ironic interface option for ironic-inspector

The correct option to use is valid_interfaces [1], not os_endpoint_type.
The os_endpoint_type option was removed in Train.

[1] https://docs.openstack.org/ironic-inspector/wallaby/configuration/sample-config.html

Change-Id: I3906d7b9a2bebfe5c323cba5f80add3e932468c8
Closes-Bug: #1995246
Related-Bug: #1990675
---
 ansible/roles/ironic/templates/ironic-inspector.conf.j2     | 2 +-
 .../notes/ironic-inspector-interface-dff250cfbce1df28.yaml  | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 releasenotes/notes/ironic-inspector-interface-dff250cfbce1df28.yaml

diff --git a/ansible/roles/ironic/templates/ironic-inspector.conf.j2 b/ansible/roles/ironic/templates/ironic-inspector.conf.j2
index 7675784ef..278c7144d 100644
--- a/ansible/roles/ironic/templates/ironic-inspector.conf.j2
+++ b/ansible/roles/ironic/templates/ironic-inspector.conf.j2
@@ -27,7 +27,7 @@ user_domain_id = {{ default_user_domain_id }}
 project_name = service
 username = {{ ironic_inspector_keystone_user }}
 password = {{ ironic_inspector_keystone_password }}
-os_endpoint_type = internalURL
+valid_interfaces = internal
 cafile = {{ openstack_cacert }}
 region_name = {{ openstack_region_name }}
 {% else %}
diff --git a/releasenotes/notes/ironic-inspector-interface-dff250cfbce1df28.yaml b/releasenotes/notes/ironic-inspector-interface-dff250cfbce1df28.yaml
new file mode 100644
index 000000000..08c050b28
--- /dev/null
+++ b/releasenotes/notes/ironic-inspector-interface-dff250cfbce1df28.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes an issue with ``ironic-inspector`` using the wrong option to
+    configure the interface used to communicate with the Ironic API.
+    `LP#1995246 <https://bugs.launchpad.net/kolla-ansible/+bug/1995246>`_
-- 
GitLab