From ecc1e4a6eb34dc8e8341e40daa5f4aaa7796c22b Mon Sep 17 00:00:00 2001
From: Minho Ban <mhban@samsung.com>
Date: Wed, 18 Jul 2018 09:17:12 +0900
Subject: [PATCH] remove uid, gid from rsyncd.conf for swift user

The rsync prior to v3.1.0 the uid/gid parameter have no effect at
all if it runs as normal(non-root) user.

Since v3.1.0 these parameter are problematic for normal user
because now rsync, regardless of root or non-root, if the
parameters are given then it just tries to call setgroups() which
is not possible for normal user so errors may occur.

    swift-object-replicator: @ERROR: setgroups failed\u0000
    swift-object-replicator: rsync error: error starting
    client-server protocol (code 5) at main.c(1648)
    [sender=3.1.2]\u0000

Either way, these parameters are not needed for swift-rsync
container.

Change-Id: Ia7fe9f06d7a21a55f52b90c2cc1b2498300e6532
Signed-off-by: Minho Ban <mhban@samsung.com>
---
 ansible/roles/swift/templates/rsyncd.conf.j2 | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ansible/roles/swift/templates/rsyncd.conf.j2 b/ansible/roles/swift/templates/rsyncd.conf.j2
index d7125981f..2797f9761 100644
--- a/ansible/roles/swift/templates/rsyncd.conf.j2
+++ b/ansible/roles/swift/templates/rsyncd.conf.j2
@@ -1,5 +1,3 @@
-uid = swift
-gid = swift
 address = {{ api_interface_address }}
 
 {% if inventory_hostname in groups['swift-account-server'] %}
-- 
GitLab