diff --git a/kolla_ansible/cli/commands.py b/kolla_ansible/cli/commands.py index 9b7078ff7e54ebaea230539c68b1836222f1f79c..fa3b1908cc801def2faaef8bccbcfcad5cebae63 100644 --- a/kolla_ansible/cli/commands.py +++ b/kolla_ansible/cli/commands.py @@ -201,7 +201,8 @@ class OctaviaCertificates(KollaAnsibleMixin, Command): def take_action(self, parsed_args): extra_vars = {} - if hasattr(parsed_args, "check_expiry"): + if hasattr(parsed_args, "check_expiry") \ + and parsed_args.check_expiry is not None: self.app.LOG.info("Checking if certificates expire " "within given number of days.") extra_vars["octavia_certs_check_expiry"] = "yes" diff --git a/tests/run.yml b/tests/run.yml index a93917f53b7fcd5ff4912f2eca882f2b79090cf5..b169800ac49d5dc160a4b9a1e2bd773b2c28f8f9 100644 --- a/tests/run.yml +++ b/tests/run.yml @@ -323,7 +323,7 @@ - name: Create TLS certificates for octavia shell: | source {{ kolla_ansible_venv_path }}/bin/activate - kolla-ansible octavia-certificates + kolla-ansible octavia-certificates -i {{ kolla_inventory_path }} -vvvv when: scenario in ['octavia'] args: executable: /bin/bash diff --git a/tests/test-octavia.sh b/tests/test-octavia.sh index 032230bbe77766811b52644fd53df802cc12a51b..d58b9592dc774a2cf0233e1897dafa332ead5fdc 100644 --- a/tests/test-octavia.sh +++ b/tests/test-octavia.sh @@ -11,7 +11,7 @@ export PYTHONUNBUFFERED=1 function check_certificate_expiry { RAW_INVENTORY=/etc/kolla/inventory source $KOLLA_ANSIBLE_VENV_PATH/bin/activate - kolla-ansible octavia-certificates --check-expiry 7 + kolla-ansible octavia-certificates -i ${RAW_INVENTORY} --check-expiry 7 deactivate }