From 39eafd068b46991494684f5880a8873d288f9ccb Mon Sep 17 00:00:00 2001
From: Pierre Riteau <pierre@stackhpc.com>
Date: Mon, 26 Sep 2022 10:52:38 +0200
Subject: [PATCH] Fix interface option for ironic-neutron-agent

The correct option to use is valid_interfaces [1], not os_endpoint_type.

[1] https://docs.openstack.org/networking-baremetal/latest/configuration/ironic-neutron-agent/config.html#ironic

Closes-Bug: #1990675
Change-Id: I35e7d3072c6340f4ecbe02f8961158bcb663954e
---
 ansible/roles/neutron/templates/ironic_neutron_agent.ini.j2 | 2 +-
 .../ironic-neutron-agent-interface-75fd4fbb1d3eb843.yaml    | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 releasenotes/notes/ironic-neutron-agent-interface-75fd4fbb1d3eb843.yaml

diff --git a/ansible/roles/neutron/templates/ironic_neutron_agent.ini.j2 b/ansible/roles/neutron/templates/ironic_neutron_agent.ini.j2
index 5906991f3..cfb9405f3 100644
--- a/ansible/roles/neutron/templates/ironic_neutron_agent.ini.j2
+++ b/ansible/roles/neutron/templates/ironic_neutron_agent.ini.j2
@@ -6,6 +6,6 @@ user_domain_id = {{ default_user_domain_id }}
 project_name = service
 username = {{ ironic_keystone_user }}
 password = {{ ironic_keystone_password }}
-os_endpoint_type = internalURL
+valid_interfaces = internal
 region_name = {{ openstack_region_name }}
 cafile = {{ openstack_cacert }}
diff --git a/releasenotes/notes/ironic-neutron-agent-interface-75fd4fbb1d3eb843.yaml b/releasenotes/notes/ironic-neutron-agent-interface-75fd4fbb1d3eb843.yaml
new file mode 100644
index 000000000..d71d9c540
--- /dev/null
+++ b/releasenotes/notes/ironic-neutron-agent-interface-75fd4fbb1d3eb843.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes an issue with ``ironic-neutron-agent`` using the wrong option to
+    configure the interface used to communicate with the Ironic API.
+    `LP#1990675 <https://bugs.launchpad.net/kolla-ansible/+bug/1990675>`_
-- 
GitLab