Skip to content
Snippets Groups Projects
  • Mark Goddard's avatar
    de00bf49
    Simplify handler conditionals · de00bf49
    Mark Goddard authored
    Currently, we have a lot of logic for checking if a handler should run,
    depending on whether config files have changed and whether the
    container configuration has changed. As rm_work pointed out during
    the recent haproxy refactor, these conditionals are typically
    unnecessary - we can rely on Ansible's handler notification system
    to only trigger handlers when they need to run. This removes a lot
    of error prone code.
    
    This patch removes conditional handler logic for all services. It is
    important to ensure that we no longer trigger handlers when unnecessary,
    because without these checks in place it will trigger a restart of the
    containers.
    
    Implements: blueprint simplify-handlers
    
    Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
    de00bf49
    History
    Simplify handler conditionals
    Mark Goddard authored
    Currently, we have a lot of logic for checking if a handler should run,
    depending on whether config files have changed and whether the
    container configuration has changed. As rm_work pointed out during
    the recent haproxy refactor, these conditionals are typically
    unnecessary - we can rely on Ansible's handler notification system
    to only trigger handlers when they need to run. This removes a lot
    of error prone code.
    
    This patch removes conditional handler logic for all services. It is
    important to ensure that we no longer trigger handlers when unnecessary,
    because without these checks in place it will trigger a restart of the
    containers.
    
    Implements: blueprint simplify-handlers
    
    Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd