Skip to content
Snippets Groups Projects
  • Mark Goddard's avatar
    70b515bf
    Catch errors and changes in kolla_toolbox module · 70b515bf
    Mark Goddard authored
    The kolla_toolbox Ansible module executes as-hoc ansible commands in the
    kolla_toolbox container, and parses the output to make it look as if
    ansible-playbook executed the command. Currently however, this module
    sometimes fails to catch failures of the underlying command, and also
    sometimes shows tasks as 'ok' when the underlying command was changed.
    This has been tested both before and after the upgrade to ansible 2.8.
    
    This change fixes this issue by configuring ansible to emit output in
    JSON format, to make parsing simpler. We can now pick up errors and
    changes, and signal them to the caller.
    
    This change also adds an ansible playbook, tests/test-kolla-toolbox.yml,
    that can be executed to test the module. It's not currently integrated
    with any CI jobs.
    
    Note that this change cannot be backported as the JSON output callback
    plugin was added in Ansible 2.5.
    
    Change-Id: I8236dd4165f760c819ca972b75cbebc62015fada
    Closes-Bug: #1844114
    70b515bf
    History
    Catch errors and changes in kolla_toolbox module
    Mark Goddard authored
    The kolla_toolbox Ansible module executes as-hoc ansible commands in the
    kolla_toolbox container, and parses the output to make it look as if
    ansible-playbook executed the command. Currently however, this module
    sometimes fails to catch failures of the underlying command, and also
    sometimes shows tasks as 'ok' when the underlying command was changed.
    This has been tested both before and after the upgrade to ansible 2.8.
    
    This change fixes this issue by configuring ansible to emit output in
    JSON format, to make parsing simpler. We can now pick up errors and
    changes, and signal them to the caller.
    
    This change also adds an ansible playbook, tests/test-kolla-toolbox.yml,
    that can be executed to test the module. It's not currently integrated
    with any CI jobs.
    
    Note that this change cannot be backported as the JSON output callback
    plugin was added in Ansible 2.5.
    
    Change-Id: I8236dd4165f760c819ca972b75cbebc62015fada
    Closes-Bug: #1844114