From b7e95c83d3ea22bdccb5a5440e677c8a36f4cf61 Mon Sep 17 00:00:00 2001
From: Mark Goddard <mark@stackhpc.com>
Date: Tue, 16 May 2023 14:55:52 +0100
Subject: [PATCH] Fix firewalld configuration for monitoring hosts
There was a stray double quote in the firewalld config for monitoring
hosts, resulting in the following error when firewalld is enabled:
ValueError: No closing quotation
Closes-Bug: 2019867
Change-Id: I201faf14da5d143670250052ab15fc285f24868c
---
ansible/inventory/group_vars/monitoring/firewall | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ansible/inventory/group_vars/monitoring/firewall b/ansible/inventory/group_vars/monitoring/firewall
index a1b15152..41c3c411 100644
--- a/ansible/inventory/group_vars/monitoring/firewall
+++ b/ansible/inventory/group_vars/monitoring/firewall
@@ -19,7 +19,7 @@ firewalld_zones: >
firewalld_default_zone: >-
{{ controller_firewalld_default_zone
if inventory_hostname in groups['controllers'] else
- monitoring_firewalld_default_zone }}"
+ monitoring_firewalld_default_zone }}
# A list of firewall rules to apply. Each item is a dict containing arguments
# to pass to the firewalld module. Arguments are omitted if not provided, with
@@ -30,4 +30,4 @@ firewalld_default_zone: >-
firewalld_rules: >
{{ controller_firewalld_rules
if inventory_hostname in groups['controllers'] else
- monitoring_firewalld_rules }}"
+ monitoring_firewalld_rules }}
--
GitLab