From 916ffba691cfae80490b7accedd26eb65328f6ea Mon Sep 17 00:00:00 2001
From: Pierre Riteau <pierre@stackhpc.com>
Date: Mon, 22 May 2023 14:52:57 +0200
Subject: [PATCH] CI: Enable bare metal testing for Ubuntu upgrades

More than one year ago, change I96827fc32c1594ca9a0535e259929c49d3f0e704
enabled bare metal testing on Ubuntu, but only for non-upgrade jobs. It
should be safe to test during upgrade jobs too.

Change-Id: I9c698916999b30bf3fd8f7dfe5add7d332a84b6c
---
 playbooks/kayobe-overcloud-upgrade-base/run.yml | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/playbooks/kayobe-overcloud-upgrade-base/run.yml b/playbooks/kayobe-overcloud-upgrade-base/run.yml
index 04257e4e..9fde3231 100644
--- a/playbooks/kayobe-overcloud-upgrade-base/run.yml
+++ b/playbooks/kayobe-overcloud-upgrade-base/run.yml
@@ -81,12 +81,6 @@
             cmd: dev/overcloud-test-baremetal.sh &> {{ logs_dir }}/ansible/overcloud-test-bm-pre-upgrade
             chdir: "{{ previous_kayobe_src_dir }}"
             executable: /bin/bash
-          # FIXME(mgoddard): Bare metal testing is unreliable on Ubuntu - some jobs
-          # see IPMI failures such as the following:
-          # ipmitool chassis bootdev pxe
-          # Error setting Chassis Boot Parameter 5\nError setting Chassis Boot
-          # Parameter 0\n
-          when: ansible_facts.os_family != 'Debian'
 
         # Upgrade Kayobe, and use it to perform an upgrade of the control plane.
 
@@ -114,12 +108,6 @@
             cmd: dev/overcloud-test-baremetal.sh &> {{ logs_dir }}/ansible/overcloud-test-bm-post-upgrade
             chdir: "{{ kayobe_src_dir }}"
             executable: /bin/bash
-          # FIXME(mgoddard): Bare metal testing is unreliable on Ubuntu - some jobs
-          # see IPMI failures such as the following:
-          # ipmitool chassis bootdev pxe
-          # Error setting Chassis Boot Parameter 5\nError setting Chassis Boot
-          # Parameter 0\n
-          when: ansible_facts.os_family != 'Debian'
 
       environment:
         KAYOBE_CONFIG_SOURCE_PATH: "{{ kayobe_config_src_dir }}"
-- 
GitLab