From 6c5fbcf9423d230439af4591c6f8e8d77d90d643 Mon Sep 17 00:00:00 2001
From: Mark Goddard <mark@stackhpc.com>
Date: Mon, 20 May 2019 15:41:05 +0100
Subject: [PATCH] Remove release notes readthedocs webhook job

This was found not to work, and prevents releases from being made.

The cause of the issue is that the trigger-readthedocs-webhook job (in
project-config) is marked as 'final', meaning that a non-trusted Zuul
config source can't override its variables. Instead, you're supposed to
use the trigger-readthedocs-webhook project template, but only one
instance of this can be instantiated by design.

Let's revert to manually updating the release notes for now.

Change-Id: I271c972c7fdde23085f3026137806bb1e3048e5e
---
 doc/source/development/releases.rst |  9 ++++++++-
 zuul.d/project.yaml                 | 19 -------------------
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/doc/source/development/releases.rst b/doc/source/development/releases.rst
index 5ace24f9..01778889 100644
--- a/doc/source/development/releases.rst
+++ b/doc/source/development/releases.rst
@@ -124,4 +124,11 @@ Post-release activites
 An email will be sent to the release-announce mailing list about the new
 release.
 
-The release notes and documentation are built automatically via a webhook.
+The documentation on readthedocs is built automatically via a webhook.
+
+.. TODO: Setup RTD integration for release notes. This was attempted
+         previously but had issues with getting the zuul job to execute
+         twice with different webhook IDs, and broke the release pipeline.
+
+The release notes need to be rebuilt manually since there is no readthedocs
+webhook integration for these yet.
diff --git a/zuul.d/project.yaml b/zuul.d/project.yaml
index cca4c730..8bad558c 100644
--- a/zuul.d/project.yaml
+++ b/zuul.d/project.yaml
@@ -31,22 +31,3 @@
         - kayobe-overcloud-upgrade-centos
         - kayobe-seed-centos
         - kayobe-seed-upgrade-centos
-
-    post:
-      jobs:
-        - trigger-readthedocs-webhook:
-            vars:
-              rtd_project_name: kayobe-release-notes
-              rtd_webhook_id: '74820'
-    pre-release:
-      jobs:
-        - trigger-readthedocs-webhook:
-            vars:
-              rtd_project_name: kayobe-release-notes
-              rtd_webhook_id: '74820'
-    release:
-      jobs:
-        - trigger-readthedocs-webhook:
-            vars:
-              rtd_project_name: kayobe-release-notes
-              rtd_webhook_id: '74820'
-- 
GitLab