diff --git a/kayobe/tests/unit/cli/test_commands.py b/kayobe/tests/unit/cli/test_commands.py index 5986de76b5d29a13d6c3afd79c9809c0da0f11ab..f0f4b06789de225b133e5491a5ecb3080dabbbed 100644 --- a/kayobe/tests/unit/cli/test_commands.py +++ b/kayobe/tests/unit/cli/test_commands.py @@ -34,6 +34,8 @@ class TestApp(cliff.app.App): class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(ansible, "install_galaxy_roles", autospec=True) @mock.patch.object(ansible, "install_galaxy_collections", autospec=True) @mock.patch.object(ansible, "passwords_yml_exists", autospec=True) @@ -63,7 +65,7 @@ class TestCase(unittest.TestCase): ignore_limit=True ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(ansible, "install_galaxy_roles", autospec=True) @mock.patch.object(ansible, "install_galaxy_collections", autospec=True) @@ -101,7 +103,7 @@ class TestCase(unittest.TestCase): ignore_limit=True ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -109,7 +111,7 @@ class TestCase(unittest.TestCase): "post-deploy", ) ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(ansible, "install_galaxy_roles", autospec=True) @mock.patch.object(ansible, "install_galaxy_collections", autospec=True) @@ -141,7 +143,7 @@ class TestCase(unittest.TestCase): ignore_limit=True ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -161,7 +163,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -181,7 +183,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -203,7 +205,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -225,7 +227,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) def test_physical_network_configure_enable_disable_disco(self): command = commands.PhysicalNetworkConfigure(TestApp(), []) @@ -256,7 +258,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -281,7 +283,7 @@ class TestCase(unittest.TestCase): } ) ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -295,7 +297,7 @@ class TestCase(unittest.TestCase): mock.call(mock.ANY, [utils.get_data_files_path( "ansible", "network-connectivity.yml")]), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -322,7 +324,7 @@ class TestCase(unittest.TestCase): limit="seed-hypervisor", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -350,7 +352,7 @@ class TestCase(unittest.TestCase): extra_vars={"wipe_disks": True}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -376,7 +378,7 @@ class TestCase(unittest.TestCase): "show_output": True} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -402,7 +404,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -428,7 +430,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -454,7 +456,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -476,7 +478,7 @@ class TestCase(unittest.TestCase): limit="seed-hypervisor", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -527,7 +529,7 @@ class TestCase(unittest.TestCase): extra_vars={'kayobe_action': 'deploy'}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -535,7 +537,7 @@ class TestCase(unittest.TestCase): "bootstrap-servers", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -589,7 +591,7 @@ class TestCase(unittest.TestCase): ] print(expected_calls) print(mock_run.call_args_list) - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -597,7 +599,7 @@ class TestCase(unittest.TestCase): "bootstrap-servers", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -623,7 +625,7 @@ class TestCase(unittest.TestCase): "show_output": True} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -649,7 +651,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -675,7 +677,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -701,7 +703,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -723,7 +725,7 @@ class TestCase(unittest.TestCase): limit="seed", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -751,7 +753,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -778,7 +780,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -806,7 +808,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -827,7 +829,7 @@ class TestCase(unittest.TestCase): extra_vars={}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -848,7 +850,7 @@ class TestCase(unittest.TestCase): extra_vars={"ipa_image_force_rebuild": True}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -888,7 +890,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -896,7 +898,7 @@ class TestCase(unittest.TestCase): "deploy-bifrost", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -945,7 +947,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -953,7 +955,7 @@ class TestCase(unittest.TestCase): "upgrade-bifrost", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -980,7 +982,7 @@ class TestCase(unittest.TestCase): extra_vars={'infra_vm_limit': 'infra-vms'} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -1001,7 +1003,7 @@ class TestCase(unittest.TestCase): extra_vars={'infra_vm_limit': 'infra-vms'} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1028,7 +1030,7 @@ class TestCase(unittest.TestCase): limit="infra-vms", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1056,7 +1058,7 @@ class TestCase(unittest.TestCase): extra_vars={"wipe_disks": True}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1078,7 +1080,7 @@ class TestCase(unittest.TestCase): limit="infra-vms", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1104,7 +1106,7 @@ class TestCase(unittest.TestCase): "show_output": True} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1130,7 +1132,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbook") @@ -1143,7 +1145,7 @@ class TestCase(unittest.TestCase): self.assertEqual(0, result) expected_calls = [] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1168,7 +1170,7 @@ class TestCase(unittest.TestCase): utils.get_data_files_path("ansible", "ip-allocation.yml"), ), ] - self.assertEqual(expected_calls, mock_run_one.call_args_list) + self.assertListEqual(expected_calls, mock_run_one.call_args_list) expected_calls = [ mock.call( @@ -1178,7 +1180,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1201,7 +1203,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1224,7 +1226,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1245,7 +1247,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1274,7 +1276,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1282,7 +1284,7 @@ class TestCase(unittest.TestCase): "gather-facts" ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1328,7 +1330,7 @@ class TestCase(unittest.TestCase): limit="overcloud", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1336,7 +1338,7 @@ class TestCase(unittest.TestCase): "bootstrap-servers", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1384,7 +1386,7 @@ class TestCase(unittest.TestCase): limit="overcloud", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1392,7 +1394,7 @@ class TestCase(unittest.TestCase): "bootstrap-servers", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1418,7 +1420,7 @@ class TestCase(unittest.TestCase): "show_output": True} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1444,7 +1446,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1470,7 +1472,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1496,7 +1498,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1518,7 +1520,7 @@ class TestCase(unittest.TestCase): limit="overcloud", ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1539,7 +1541,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1548,7 +1550,7 @@ class TestCase(unittest.TestCase): extra_args=[] ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1570,7 +1572,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1579,7 +1581,7 @@ class TestCase(unittest.TestCase): extra_args=["--incremental"] ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1608,7 +1610,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1617,7 +1619,7 @@ class TestCase(unittest.TestCase): extra_vars={} ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1647,7 +1649,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1658,7 +1660,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1678,7 +1680,7 @@ class TestCase(unittest.TestCase): extra_vars={} ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1726,7 +1728,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1742,7 +1744,7 @@ class TestCase(unittest.TestCase): "post-deploy", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1784,7 +1786,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1796,7 +1798,7 @@ class TestCase(unittest.TestCase): "deploy-containers", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1826,7 +1828,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1834,7 +1836,7 @@ class TestCase(unittest.TestCase): "prechecks", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1882,7 +1884,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1898,7 +1900,7 @@ class TestCase(unittest.TestCase): "post-deploy", ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -1939,7 +1941,7 @@ class TestCase(unittest.TestCase): }, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -1948,7 +1950,7 @@ class TestCase(unittest.TestCase): extra_args=["--yes-i-really-really-mean-it"], ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2011,7 +2013,7 @@ class TestCase(unittest.TestCase): ignore_limit=True, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) expected_calls = [ mock.call( @@ -2027,7 +2029,7 @@ class TestCase(unittest.TestCase): "post-deploy" ), ] - self.assertEqual(expected_calls, mock_kolla_run.call_args_list) + self.assertListEqual(expected_calls, mock_kolla_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2057,7 +2059,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2085,7 +2087,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2112,7 +2114,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2134,7 +2136,7 @@ class TestCase(unittest.TestCase): extra_vars={}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2156,7 +2158,7 @@ class TestCase(unittest.TestCase): extra_vars={"overcloud_host_image_force_rebuild": True}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2178,7 +2180,7 @@ class TestCase(unittest.TestCase): extra_vars={}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2200,7 +2202,7 @@ class TestCase(unittest.TestCase): extra_vars={"ipa_image_force_rebuild": True}, ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2229,7 +2231,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2249,7 +2251,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2268,7 +2270,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2287,7 +2289,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2306,7 +2308,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2325,7 +2327,7 @@ class TestCase(unittest.TestCase): ], ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2348,7 +2350,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2374,7 +2376,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2397,7 +2399,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2423,7 +2425,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2445,7 +2447,7 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) @mock.patch.object(commands.KayobeAnsibleMixin, "run_kayobe_playbooks") @@ -2470,11 +2472,13 @@ class TestCase(unittest.TestCase): } ), ] - self.assertEqual(expected_calls, mock_run.call_args_list) + self.assertListEqual(expected_calls, mock_run.call_args_list) class TestHookDispatcher(unittest.TestCase): + maxDiff = None + @mock.patch('kayobe.cli.commands.os.path') def test_hook_ordering(self, mock_path): mock_command = mock.MagicMock() diff --git a/kayobe/tests/unit/test_ansible.py b/kayobe/tests/unit/test_ansible.py index 1f4a13d5297080d1bb78f723dabcbde09706fef0..5656ac378cdb9c236578a93e47471dc1654cfdfe 100644 --- a/kayobe/tests/unit/test_ansible.py +++ b/kayobe/tests/unit/test_ansible.py @@ -30,6 +30,8 @@ from kayobe import vault @mock.patch.dict(os.environ, clear=True) class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(utils, "run_command") @mock.patch.object(ansible, "_get_vars_files") @mock.patch.object(ansible, "_validate_args") @@ -157,7 +159,7 @@ class TestCase(unittest.TestCase): mock.call(expected_cmd, check_output=False, quiet=False, env=expected_env) ] - self.assertEqual(expected_calls, mock_run.mock_calls) + self.assertListEqual(expected_calls, mock_run.mock_calls) mock_vars.assert_called_once_with( ["/path/to/config", "/path/to/config/environments/test-env"]) @@ -477,7 +479,7 @@ class TestCase(unittest.TestCase): force=False), mock.call("/etc/kayobe/ansible/requirements.yml", "/etc/kayobe/ansible/roles", force=False)] - self.assertEqual(expected_calls, mock_install.call_args_list) + self.assertListEqual(expected_calls, mock_install.call_args_list) mock_is_readable.assert_called_once_with( "/etc/kayobe/ansible/requirements.yml") mock_mkdirs.assert_called_once_with("/etc/kayobe/ansible/roles") @@ -500,7 +502,7 @@ class TestCase(unittest.TestCase): force=True), mock.call("/etc/kayobe/ansible/requirements.yml", "/etc/kayobe/ansible/roles", force=True)] - self.assertEqual(expected_calls, mock_install.call_args_list) + self.assertListEqual(expected_calls, mock_install.call_args_list) mock_is_readable.assert_called_once_with( "/etc/kayobe/ansible/requirements.yml") mock_mkdirs.assert_called_once_with("/etc/kayobe/ansible/roles") @@ -563,7 +565,7 @@ class TestCase(unittest.TestCase): force=False), mock.call("/etc/kayobe/ansible/requirements.yml", "/etc/kayobe/ansible/collections", force=False)] - self.assertEqual(expected_calls, mock_install.call_args_list) + self.assertListEqual(expected_calls, mock_install.call_args_list) mock_is_readable.assert_called_once_with( "/etc/kayobe/ansible/requirements.yml") mock_mkdirs.assert_called_once_with("/etc/kayobe/ansible/collections") @@ -586,7 +588,7 @@ class TestCase(unittest.TestCase): force=True), mock.call("/etc/kayobe/ansible/requirements.yml", "/etc/kayobe/ansible/collections", force=True)] - self.assertEqual(expected_calls, mock_install.call_args_list) + self.assertListEqual(expected_calls, mock_install.call_args_list) mock_is_readable.assert_called_once_with( "/etc/kayobe/ansible/requirements.yml") mock_mkdirs.assert_called_once_with("/etc/kayobe/ansible/collections") @@ -715,7 +717,7 @@ class TestCase(unittest.TestCase): mock.call("/etc/kayobe/environments/test-env/inventory"), mock.call("/etc/kayobe/ansible.cfg"), ] - self.assertEqual(expected_calls, mock_exists.mock_calls) + self.assertListEqual(expected_calls, mock_exists.mock_calls) mock_run.assert_called_once_with(expected_cmd, check_output=False, quiet=False, env=expected_env) mock_vars.assert_called_once_with( @@ -754,7 +756,7 @@ class TestCase(unittest.TestCase): mock.call("/etc/kayobe/environments/test-env/inventory"), mock.call("/etc/kayobe/ansible.cfg"), ] - self.assertEqual(expected_calls, mock_exists.mock_calls) + self.assertListEqual(expected_calls, mock_exists.mock_calls) mock_run.assert_called_once_with(expected_cmd, check_output=False, quiet=False, env=expected_env) mock_vars.assert_called_once_with( @@ -793,7 +795,7 @@ class TestCase(unittest.TestCase): mock.call("/etc/kayobe/environments/test-env/inventory"), mock.call("/etc/kayobe/ansible.cfg"), ] - self.assertEqual(expected_calls, mock_exists.mock_calls) + self.assertListEqual(expected_calls, mock_exists.mock_calls) mock_run.assert_called_once_with(expected_cmd, check_output=False, quiet=False, env=expected_env) mock_vars.assert_called_once_with( diff --git a/kayobe/tests/unit/test_environment.py b/kayobe/tests/unit/test_environment.py index 376615b9b0eb1b8a69abc2d0295d0e16d65222bf..8e93d1abf9ed8a3709c12361121dde0cea45f027 100644 --- a/kayobe/tests/unit/test_environment.py +++ b/kayobe/tests/unit/test_environment.py @@ -24,6 +24,8 @@ from kayobe import utils class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(utils, "is_readable_dir") def test_unreadable_environments_directory(self, mock_readable_dir): mock_readable_dir.return_value = { @@ -78,7 +80,7 @@ class TestCase(unittest.TestCase): mock.call("/path/to/config/environments"), mock.call("/path/to/config/environments/foo"), ] - self.assertEqual(expected_calls, mock_mkdir.call_args_list) + self.assertListEqual(expected_calls, mock_mkdir.call_args_list) mock_copy_dir.assert_called_once_with( "/path/to/foo", "/path/to/config/environments/foo", exclude=["environments"]) diff --git a/kayobe/tests/unit/test_kolla_ansible.py b/kayobe/tests/unit/test_kolla_ansible.py index 6ab0dcd4299b8f8848a52aec974f8ed55da5068c..1876c04d15db9c5e7c89765b8afb6a7746b865d8 100644 --- a/kayobe/tests/unit/test_kolla_ansible.py +++ b/kayobe/tests/unit/test_kolla_ansible.py @@ -28,6 +28,8 @@ from kayobe import vault @mock.patch.dict(os.environ, clear=True) class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(utils, "run_command") @mock.patch.object(kolla_ansible, "_validate_args") def test_run(self, mock_validate, mock_run): @@ -122,7 +124,7 @@ class TestCase(unittest.TestCase): check_output=True, universal_newlines=True), mock.call(expected_cmd, shell=True, quiet=False, env=expected_env) ] - self.assertEqual(expected_calls, mock_run.mock_calls) + self.assertListEqual(expected_calls, mock_run.mock_calls) @mock.patch.object(utils, "run_command") @mock.patch.object(kolla_ansible, "_validate_args") @@ -259,7 +261,7 @@ class TestCase(unittest.TestCase): mock.call("/etc/kayobe/kolla/ansible.cfg"), mock.call("/etc/kayobe/ansible.cfg"), ] - self.assertEqual(mock_readable.call_args_list, expected_calls) + self.assertListEqual(mock_readable.call_args_list, expected_calls) @mock.patch.object(utils, "run_command") @mock.patch.object(utils, "is_readable_file") diff --git a/kayobe/tests/unit/test_utils.py b/kayobe/tests/unit/test_utils.py index e1b4e2b0281fb9f6416e34ee009c97a77f4ec785..b63ce1808a1259a2768a9aeba1da1673d0d96151 100644 --- a/kayobe/tests/unit/test_utils.py +++ b/kayobe/tests/unit/test_utils.py @@ -25,6 +25,8 @@ from kayobe import utils class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(utils, "run_command") def test_galaxy_role_install(self, mock_run): utils.galaxy_role_install("/path/to/role/file", "/path/to/roles") diff --git a/kayobe/tests/unit/test_vault.py b/kayobe/tests/unit/test_vault.py index dbb151afd8d8c4e0faf4424b30decd4dfd8348a1..00f373af8732219064223d4f242f8f959f391b5f 100644 --- a/kayobe/tests/unit/test_vault.py +++ b/kayobe/tests/unit/test_vault.py @@ -23,6 +23,8 @@ from kayobe import vault class TestCase(unittest.TestCase): + maxDiff = None + @mock.patch.object(vault.utils, "run_command", autospec=True) def test__get_vault_password_helper(self, mock_run): mock_run.return_value = "fake-password\n"